Gfrktyl

I am new to programming and I tasked myself with the challenge of making a dice rolling game. It goes from 1 to 6 and it first asks you if you're interested in playing. Then it rolls. Then it spits out the number, and asks if you want to play again.

I got it to work, however, I can guarantee that it could be shorter. I am COMPLETELY stumped on this part. I would honestly like critique on how to clean up my programming. I know I'm brand new, but I would like to learn efficiency as well as the basics if possible.

I programmed in Python version 3.

import random

game_start = input("Would you like to roll the dice?")



def dice_roll():

    print("Your number is: " + str(random.randint(1,6)))

    global play_again

    play_again = input("Would you like to play again?")



if game_start == "yes":

    dice_roll()

    while play_again == "yes":

        dice_roll()

elif game_start == "no":

    print("Game Over")

else:

    print("Input not recognized")

import random



def dice_roll():

    while True:

        print("Your number is: " + str(random.randint(1,6)))

        play_again = input("Would you like to play again? ")

        while play_again != 'yes':

            if play_again == 'no':

                return print("Game Over")

            else:

                print("Input not recognized")

                play_again = input("Would you like to play again? ")



def main():

    game_start = input("Would you like to roll the dice?")

    if game_start == 'yes':

        dice_roll()

    else:

        print('too bad')



if __name__ == '__main__':

    main()

the while inside dice_roll() will roll the dice as long as you want to play again. I made your inicial input part of main(), so if you want to use this program from another one, it doesn't do anything, but you still get to use the dice_roll() function.

Perhaps you could put it all in one loop. Maybe roll it all into the function or put the function code where the 'while' loop is.

Something like: if yes, then print("Your number is: " + str(random.randint(1,6)))

Also, you might not need a "no" option at all. It could just have what you wrote for "yes" and have anything else be "game over". But I see that maybe the "input not recognized" is a part of your task.

Merge game_start and play_again into one variable - note they already mean almost the same thing, and you never need both at the same time. So call it play or wants_to_play or keep_playing etc.

That will allow you to collapse some of your repeated if statements and loops.

Note also that dice_roll doesn't just roll the dice - it also asks if you want to play again. Don't do that - a function should just do one thing, not two. Maybe dice_roll should just do print("Your number is: " + str(random.randint(1,6))), or, in fact, maybe it should just return random.randint(1,6) and let other code worry about display - imagine if you wanted to make a GUI - try to keep the UI code from spreading everywhere.

so think how the game should work (this is not python):

wants_to_play = ask "do you want to play"

while wants_to_play

   roll dice, display roll

   wants_to_play = ask "play again"

That should be all there is basically, right?
Can you fill it in from there? Turn that into Python?

P.S. maybe ask could be a function, that handles the bad input etc, and converts the answer to true/false.