Rendering elements (which can change numbers) using jQuery





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







1












$begingroup$


Currently when the user selects some tags in my app I generate them in a function, like this:



// Show tags that are currently used in search
var htmlNodes = '<ul class="tags">';

// If no pinned nodes, reset not found nodes
if (graphFactory.existPinnedNodes() == false) {
graphFactory.updateNotFoundNodes();
}

// Add not found nodes as tags (gray)
for (let x = 0; x < graphFactory.getNotFoundNodes().length; x++) {
htmlNodes = htmlNodes + '<li><a class="notfound" href="#">' + graphFactory.getNotFoundNodes()[x] + '</a></li>';
}

// Add pinned nodes as tags (blue)
for (let q = 0; q < graphFactory.getPinnedNodes().length; q++) {
htmlNodes = htmlNodes + '<li><a href="#">' + graphFactory.getPinnedNodes()[q] + '</a></li>';
}

htmlNodes = htmlNodes + '<div class="tagsend"></div></ul>';
$('#pinnednodeslist').html(htmlNodes);


Basically I create a <ul> of class tags, add some li elements with a specific tag each, and then render it into the #pinnednodeslist element.



As you can see, the number of <li> elements might change, depending on the number of getPinnedNodes or getNotFoundNodes, so I wonder if I have to reconstruct this html every time or if there is a more efficient way to do that...



Maybe a better way is that I don't have to mix so much HTML with my code?



For instance, I was thinking to leave all the elements there and just make them invisible, simply adding a class to show them and the html content to display within... But maybe you know of some other better way to do that?










share|improve this question









New contributor




Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$



















    1












    $begingroup$


    Currently when the user selects some tags in my app I generate them in a function, like this:



    // Show tags that are currently used in search
    var htmlNodes = '<ul class="tags">';

    // If no pinned nodes, reset not found nodes
    if (graphFactory.existPinnedNodes() == false) {
    graphFactory.updateNotFoundNodes();
    }

    // Add not found nodes as tags (gray)
    for (let x = 0; x < graphFactory.getNotFoundNodes().length; x++) {
    htmlNodes = htmlNodes + '<li><a class="notfound" href="#">' + graphFactory.getNotFoundNodes()[x] + '</a></li>';
    }

    // Add pinned nodes as tags (blue)
    for (let q = 0; q < graphFactory.getPinnedNodes().length; q++) {
    htmlNodes = htmlNodes + '<li><a href="#">' + graphFactory.getPinnedNodes()[q] + '</a></li>';
    }

    htmlNodes = htmlNodes + '<div class="tagsend"></div></ul>';
    $('#pinnednodeslist').html(htmlNodes);


    Basically I create a <ul> of class tags, add some li elements with a specific tag each, and then render it into the #pinnednodeslist element.



    As you can see, the number of <li> elements might change, depending on the number of getPinnedNodes or getNotFoundNodes, so I wonder if I have to reconstruct this html every time or if there is a more efficient way to do that...



    Maybe a better way is that I don't have to mix so much HTML with my code?



    For instance, I was thinking to leave all the elements there and just make them invisible, simply adding a class to show them and the html content to display within... But maybe you know of some other better way to do that?










    share|improve this question









    New contributor




    Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      Currently when the user selects some tags in my app I generate them in a function, like this:



      // Show tags that are currently used in search
      var htmlNodes = '<ul class="tags">';

      // If no pinned nodes, reset not found nodes
      if (graphFactory.existPinnedNodes() == false) {
      graphFactory.updateNotFoundNodes();
      }

      // Add not found nodes as tags (gray)
      for (let x = 0; x < graphFactory.getNotFoundNodes().length; x++) {
      htmlNodes = htmlNodes + '<li><a class="notfound" href="#">' + graphFactory.getNotFoundNodes()[x] + '</a></li>';
      }

      // Add pinned nodes as tags (blue)
      for (let q = 0; q < graphFactory.getPinnedNodes().length; q++) {
      htmlNodes = htmlNodes + '<li><a href="#">' + graphFactory.getPinnedNodes()[q] + '</a></li>';
      }

      htmlNodes = htmlNodes + '<div class="tagsend"></div></ul>';
      $('#pinnednodeslist').html(htmlNodes);


      Basically I create a <ul> of class tags, add some li elements with a specific tag each, and then render it into the #pinnednodeslist element.



      As you can see, the number of <li> elements might change, depending on the number of getPinnedNodes or getNotFoundNodes, so I wonder if I have to reconstruct this html every time or if there is a more efficient way to do that...



      Maybe a better way is that I don't have to mix so much HTML with my code?



      For instance, I was thinking to leave all the elements there and just make them invisible, simply adding a class to show them and the html content to display within... But maybe you know of some other better way to do that?










      share|improve this question









      New contributor




      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Currently when the user selects some tags in my app I generate them in a function, like this:



      // Show tags that are currently used in search
      var htmlNodes = '<ul class="tags">';

      // If no pinned nodes, reset not found nodes
      if (graphFactory.existPinnedNodes() == false) {
      graphFactory.updateNotFoundNodes();
      }

      // Add not found nodes as tags (gray)
      for (let x = 0; x < graphFactory.getNotFoundNodes().length; x++) {
      htmlNodes = htmlNodes + '<li><a class="notfound" href="#">' + graphFactory.getNotFoundNodes()[x] + '</a></li>';
      }

      // Add pinned nodes as tags (blue)
      for (let q = 0; q < graphFactory.getPinnedNodes().length; q++) {
      htmlNodes = htmlNodes + '<li><a href="#">' + graphFactory.getPinnedNodes()[q] + '</a></li>';
      }

      htmlNodes = htmlNodes + '<div class="tagsend"></div></ul>';
      $('#pinnednodeslist').html(htmlNodes);


      Basically I create a <ul> of class tags, add some li elements with a specific tag each, and then render it into the #pinnednodeslist element.



      As you can see, the number of <li> elements might change, depending on the number of getPinnedNodes or getNotFoundNodes, so I wonder if I have to reconstruct this html every time or if there is a more efficient way to do that...



      Maybe a better way is that I don't have to mix so much HTML with my code?



      For instance, I was thinking to leave all the elements there and just make them invisible, simply adding a class to show them and the html content to display within... But maybe you know of some other better way to do that?







      javascript jquery interface






      share|improve this question









      New contributor




      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 24 mins ago









      Jamal

      30.6k11121227




      30.6k11121227






      New contributor




      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 20 hours ago









      Dmitry ParanyushkinDmitry Paranyushkin

      1062




      1062




      New contributor




      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Dmitry Paranyushkin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes












          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Dmitry Paranyushkin is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217377%2frendering-elements-which-can-change-numbers-using-jquery%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Dmitry Paranyushkin is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Dmitry Paranyushkin is a new contributor. Be nice, and check out our Code of Conduct.













          Dmitry Paranyushkin is a new contributor. Be nice, and check out our Code of Conduct.












          Dmitry Paranyushkin is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217377%2frendering-elements-which-can-change-numbers-using-jquery%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Сан-Квентин

          Алькесар

          Josef Freinademetz