Poker Game: Unit testing different poker hands without violating DRY principles
0
$begingroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
edited 10 mins ago
t3chb0t
35k753124
asked 1 hour ago
Asel SAsel S
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
edited 10 mins ago
t3chb0t
35k753124
asked 1 hour ago
Asel SAsel S
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
1 hour ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
1 hour ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
10 mins ago
$begingroup$
By the code that I'm testing, do you mean the code for the OnePair() method? If not, could you please clarify?
$endgroup$
– Asel S
6 mins ago
add a comment |
0
0
0
$begingroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
edited 10 mins ago
t3chb0t
35k753124
asked 1 hour ago
Asel SAsel S
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I'm currently in the process of refactoring an old poker game which violates many of the SOLID principles.
I was trying to use the TDD approach to refactoring and I found myself having to hard code a player's hand every time I wrote a unit test for a specific poker hand check.
For example, here are the unit tests for a one pair poker hand check:
[Test]
public void OnePair_IsLowPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Ace),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Five),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsLowerMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Eight),
new CardSpade(Rank.Ace),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Jack),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHigherMiddlePair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Queen),
new CardDiamond(Rank.Ace),
new CardHeart(Rank.Ace),
new CardClub(Rank.Three)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
[Test]
public void OnePair_IsHighPair_ReturnsTrue()
{
SuperCard testHand =
{
new CardClub(Rank.Jack),
new CardSpade(Rank.Deuce),
new CardDiamond(Rank.Six),
new CardHeart(Rank.Ace),
new CardClub(Rank.Ace)
};
bool result = PokerHandEvaluator.OnePair(testHand);
Assert.That(result == true);
}
This is what the class diagram (at the project's current stage) looks like:
My question is how I should go about extracting a method (or methods) out of the testHand initialization.
c# unit-testing nunit
c# unit-testing nunit
edited 10 mins ago
t3chb0t
35k753124
asked 1 hour ago
Asel SAsel S
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 10 mins ago
t3chb0t
35k753124
asked 1 hour ago
Asel SAsel S
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 10 mins ago
t3chb0t
35k753124
edited 10 mins ago
t3chb0t
35k753124
edited 10 mins ago
t3chb0t
35k753124
35k753124
asked 1 hour ago
Asel SAsel S
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Asel SAsel S
165
asked 1 hour ago
Asel SAsel S
165
165
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
1 hour ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
1 hour ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
10 mins ago
$begingroup$
By the code that I'm testing, do you mean the code for the OnePair() method? If not, could you please clarify?
$endgroup$
– Asel S
6 mins ago
add a comment |
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
1 hour ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
1 hour ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
10 mins ago
$begingroup$
By the code that I'm testing, do you mean the code for the OnePair() method? If not, could you please clarify?
$endgroup$
– Asel S
6 mins ago
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
1 hour ago
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
1 hour ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
1 hour ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
1 hour ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
10 mins ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
10 mins ago
$begingroup$
By the code that I'm testing, do you mean the code for the OnePair() method? If not, could you please clarify?
$endgroup$
– Asel S
6 mins ago
$begingroup$
By the code that I'm testing, do you mean the code for the OnePair() method? If not, could you please clarify?
$endgroup$
– Asel S
6 mins ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216313%2fpoker-game-unit-testing-different-poker-hands-without-violating-dry-principles%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216313%2fpoker-game-unit-testing-different-poker-hands-without-violating-dry-principles%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
$begingroup$
Maybe make a "CreateHand()" function that takes a string like "AcAs5dJh3c"?
$endgroup$
– AShelly
1 hour ago
$begingroup$
A CreateHand() is essentially what I'm trying to go for here but I'm not sure how to implement your idea. Can you please share some pseudocode or code?
$endgroup$
– Asel S
1 hour ago
$begingroup$
You also need to post the code you are testing. The tests are worthless without it.
$endgroup$
– t3chb0t
10 mins ago
$begingroup$
By the code that I'm testing, do you mean the code for the OnePair() method? If not, could you please clarify?
$endgroup$
– Asel S
6 mins ago