Gfrktyl

I'm developing a code that will measure the speed in which you answer math questions, it's still very early and I'm quite new to
python. I'm experiencing some issues in what I have so far, here's the
code, I've used sample code from other sources to help assist me in
this fun project. If you have any constructive criticism and fixes to
the issues I'm having please comment. Note: it is still very rough
around the edges and some parts might duplicate sorry! any help would
be appreciated

    import random, time



num_of_players = int(input("How many players? "))

players = [{

            'name':input(f"Player {i+1}: "),

            'points':0

            } for i in range(num_of_players)]



rounds = int(input("How many rounds? "))

for i in range(0,rounds):

    print("-"*20 + f"nIt is now round {i}!n" + "-"*20)



    for player in players:

        input(f"It is now {player['name']}'s turn.nPress enter when ready.")



        def display_intro():

            title = "** A Simple Math Quiz **"

            print("*" * len(title))

            print(title)

            print("*" * len(title))





        def display_menu():

            menu_list = ["1. Addition", "2. Subtraction", "3. Multiplication", "4. Integer Division", "5. Exit"]

            print(menu_list[0])

            print(menu_list[1])

            print(menu_list[2])

            print(menu_list[3])

            print(menu_list[4])





        def display_separator():

            print("-" * 24)





        def get_user_input():

            user_input = int(input("Enter your choice: "))

            while user_input > 5 or user_input <= 0:

                print("Invalid menu option.")

                user_input = int(input("Please try again: "))

            else:

                return user_input





        def get_user_solution(problem):

            time.sleep(random.randint(1,8))

            then = time.time()

            print(problem, end="")

            result = int(input(" = "))

            reaction_time = time.time()-then

            print(f"{reaction_time*1000:.0f} ms")

            player["points"] += reaction_time

            return result





        def check_solution(user_solution, solution, count):

            if user_solution == solution:

                count = count + 1

                print("Correct.")

                return count

            else:

                print("Incorrect.")

                return count





        def menu_option(index, count):

            number_one = random.randrange(1, 21)

            number_two = random.randrange(1, 21)

            if index is 1:

                problem = str(number_one) + " + " + str(number_two)

                solution = number_one + number_two

                user_solution = get_user_solution(problem)

                count = check_solution(user_solution, solution, count)

                return count

            elif index is 2:

                problem = str(number_one) + " - " + str(number_two)

                solution = number_one - number_two

                user_solution = get_user_solution(problem)

                count = check_solution(user_solution, solution, count)

                return count

            elif index is 3:

                problem = str(number_one) + " * " + str(number_two)

                solution = number_one * number_two

                user_solution = get_user_solution(problem)

                count = check_solution(user_solution, solution, count)

                return count

            else:

                problem = str(number_one) + " // " + str(number_two)

                solution = number_one // number_two

                user_solution = get_user_solution(problem)

                count = check_solution(user_solution, solution, count)

                return count





        def display_result(total, correct):

            if total > 0:

                result = correct / total

                percentage = round((result * 100), 2)

            if total == 0:

                percentage = 0

            print("You answered", total, "questions with", correct, "correct.")

            print("Your score is ", percentage, "%. Thank you.", sep = "")



            winner = min(players,key=lambda a: a['points'])['name']

            print("The winner is...")

            time.sleep(0.5)

            print(f"{winner}!")





        def main():

            display_intro()

            display_menu()

            display_separator()



            option = get_user_input()

            total = 0

            correct = 0

            while option != 5:

                total = total + 1

                correct = menu_option(option, correct)

                option = get_user_input()



            print("Exit the quiz.")

            display_separator()

            display_result(total, correct)



        main()

Code organisation

Having many functions defined in the middle of the core loop make things very hard to understand. It would be much easier and much more conventional to define all functions before the loop. One of the issues you might encounter is that functions will rely on variables they know nothing about such as players. A simple solution could be to add these as parameters.

Also, main is a very confusing name for a function which is not the first thing launched. I guess play_turn would be a better name.

At this stage, we'd have something like:

Disclaimer: I've changed various details (removed fstrings because I don't have Python 3.6 available, etc)

import random, time



SIMU = True  # hack for testing purposes



def display_intro():

    title = "** A Simple Math Quiz **"

    print("*" * len(title))

    print(title)

    print("*" * len(title))



def display_menu():

    menu_list = ["1. Addition", "2. Subtraction", "3. Multiplication", "4. Integer Division", "5. Exit"]

    print(menu_list[0])

    print(menu_list[1])

    print(menu_list[2])

    print(menu_list[3])

    print(menu_list[4])







def display_separator():

    print("-" * 24)



def get_user_input():

    user_input = int(input("Enter your choice: "))

    while user_input > 5 or user_input <= 0:

        print("Invalid menu option.")

        user_input = int(input("Please try again: "))

    else:

        return user_input



def check_solution(user_solution, solution, count):

    if user_solution == solution:

        count = count + 1

        print("Correct.")

        return count

    else:

        print("Incorrect.")

        return count



def get_user_solution(problem, player):

   if not SIMU:

       time.sleep(random.randint(1,8))

   then = time.time()

   print(problem, end="")

   result = int(input(" = "))

   reaction_time = time.time()-then

   print(" ms")

   player["points"] += reaction_time

   return result



def menu_option(index, count, player):

    number_one = random.randrange(1, 21)

    number_two = random.randrange(1, 21)

    if index is 1:

        problem = str(number_one) + " + " + str(number_two)

        solution = number_one + number_two

        user_solution = get_user_solution(problem, player)

        count = check_solution(user_solution, solution, count)

        return count

    elif index is 2:

        problem = str(number_one) + " - " + str(number_two)

        solution = number_one - number_two

        user_solution = get_user_solution(problem, player)

        count = check_solution(user_solution, solution, count)

        return count

    elif index is 3:

        problem = str(number_one) + " * " + str(number_two)

        solution = number_one * number_two

        user_solution = get_user_solution(problem, player)

        count = check_solution(user_solution, solution, count)

        return count

    else:

        problem = str(number_one) + " // " + str(number_two)

        solution = number_one // number_two

        user_solution = get_user_solution(problem, player)

        count = check_solution(user_solution, solution, count)

        return count



def display_result(total, correct):

    if total > 0:

        result = correct / total

        percentage = round((result * 100), 2)

    if total == 0:

        percentage = 0

    print("You answered", total, "questions with", correct, "correct.")

    print("Your score is ", percentage, "%. Thank you.", sep = "")



    winner = min(players,key=lambda a: a['points'])['name']

    print("The winner is...")

    time.sleep(0.5)

    print("{winner}!")



def play_turn(player):

    if SIMU:

        print("It is now 's turn.nBe ready.")

    else:

        input("It is now 's turn.nPress enter when ready.")

    display_intro()

    display_menu()

    display_separator()



    option = get_user_input()

    total = 0

    correct = 0

    while option != 5:

        total = total + 1

        correct = menu_option(option, correct, player)

        option = get_user_input()



    print("Exit the quiz.")

    display_separator()

    display_result(total, correct)



def play_round(players):

    print("-"*20 + "nIt is now round !n" + "-"*20)



    for player in players:

        play_turn(player)



def play_game():

    if SIMU:

        players = [{'name': name, 'points': 0} for name in ('foo', 'bar', 'foobar')]

        nb_rounds = 1

    else:

        players = [{

                'name':input("Player: "),

                'points':0

                } for i in range(int(input("How many players? ")))]

        nb_rounds =  int(input("How many rounds? "))

    for i in range(0, nb_rounds):

        play_round(players)



play_game()

Now, it it easier to improve these functions.

Improve display_intro

We could compute the length and the border string in a single place:

def display_intro():

    title = "** A Simple Math Quiz **"

    border = "*" * len(title)

    print(border)

    print(title)

    print(border)

Improve display_menu

It is a good idea to have the menu in a proper data structure. It would be even better too iterate over it instead of using indices: it would be more concise, more efficient and easier to maintain (you do not have to remember to add/remove lines when you add/remove elements from the menu).

def display_menu():

    menu_list = ["1. Addition", "2. Subtraction", "3. Multiplication", "4. Integer Division", "5. Exit"]

    for menu_item in menu_list:

        print(menu_item)

Also, we could have the numbers generated automatically but we'll come back to this.

Improve check_solution

You have the same thing returned in both branches. You could have it in a single place:

def check_solution(user_solution, solution, count):

    if user_solution == solution:

        count = count + 1

        print("Correct.")

    else:

        print("Incorrect.")

    return count

Improve menu_option

The main thing one can see is that it contains highly duplicated code.

Let's extract out the common part to make things clearer:

def menu_option(index, count, player):

    number_one = random.randrange(1, 21)

    number_two = random.randrange(1, 21)

    if index is 1:

        op_str = " + "

        res = number_one + number_two

    elif index is 2:

        op_str = " - "

        res = number_one - number_two

    elif index is 3:

        op_str = " * "

        res = number_one * number_two

    else:

        op_str = " // "

        res = number_one // number_two

    problem = str(number_one) + op_str + str(number_two)

    user_solution = get_user_solution(problem, player)

    count = check_solution(user_solution, res, count)

    return count

This can still be improved, I'll come back to this.

Improving display_result

You could use elif at the beginning because the 2 cases are mutually exclusive:

if total > 0:

    result = correct / total

    percentage = round((result * 100), 2)

elif total == 0:

    percentage = 0

However, I'd rather have this written:

if total == 0:

    percentage = 0

else:

    result = correct / total

    percentage = round((result * 100), 2)

To be continued