Typescript logger class
2
Looking for a critique of this simple logger class I'm working on in my transition to TypeScript.
The purpose of the logging class is to just print to a console either info, warn or error messages.
The main things I'm after feedback on are my usage of the TypeScript type system. I.e interfaces/types/whatever else could be done different or better.
interface LoggerConfig {
prefix?: string;
prefixColor?: TextColor.White;
displayConsole?: boolean;
outputExternal?: boolean;
}
type LogFn = (msg: string) => void;
interface Log {
config: LoggerConfig;
log: (msg: string, logColor: TextColor, override?: LoggerConfig) => void;
info: LogFn;
warn: LogFn;
error: LogFn;
}
class Logger implements Log {
config: LoggerConfig = {
prefix: 'console :: ',
prefixColor: TextColor.Green,
displayConsole: false,
outputExternal: false,
};
constructor(userConfig: LoggerConfig = {}) {
this.config = {...this.config, ...userConfig};
}
log(msg: string, logColor: TextColor, override?: LoggerConfig) {
const config = override ? {...this.config, ...override} : this.config;
const {displayConsole, outputExternal, prefix, prefixColor} = config;
if (displayConsole) {
showConsole();
}
if (outputExternal) {
external.printToConsole(`${prefix} ${msg}`);
}
print(prefixColor + prefix + logColor + ' ' + msg);
}
info(msg: string) {
this.log(msg, TextColor.White);
}
warn(msg: string) {
this.log(msg, TextColor.Yellow, {displayConsole: true});
}
error(msg: string) {
this.log(msg, TextColor.Red, {displayConsole: true, outputExternal: true});
}
}
const logger = new Logger({prefix: 'testLogger :: '})
logging typescript
edited Dec 23 at 22:09
200_success
128k15150412
asked Dec 23 at 21:45
user3238415
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
2
Looking for a critique of this simple logger class I'm working on in my transition to TypeScript.
The purpose of the logging class is to just print to a console either info, warn or error messages.
The main things I'm after feedback on are my usage of the TypeScript type system. I.e interfaces/types/whatever else could be done different or better.
interface LoggerConfig {
prefix?: string;
prefixColor?: TextColor.White;
displayConsole?: boolean;
outputExternal?: boolean;
}
type LogFn = (msg: string) => void;
interface Log {
config: LoggerConfig;
log: (msg: string, logColor: TextColor, override?: LoggerConfig) => void;
info: LogFn;
warn: LogFn;
error: LogFn;
}
class Logger implements Log {
config: LoggerConfig = {
prefix: 'console :: ',
prefixColor: TextColor.Green,
displayConsole: false,
outputExternal: false,
};
constructor(userConfig: LoggerConfig = {}) {
this.config = {...this.config, ...userConfig};
}
log(msg: string, logColor: TextColor, override?: LoggerConfig) {
const config = override ? {...this.config, ...override} : this.config;
const {displayConsole, outputExternal, prefix, prefixColor} = config;
if (displayConsole) {
showConsole();
}
if (outputExternal) {
external.printToConsole(`${prefix} ${msg}`);
}
print(prefixColor + prefix + logColor + ' ' + msg);
}
info(msg: string) {
this.log(msg, TextColor.White);
}
warn(msg: string) {
this.log(msg, TextColor.Yellow, {displayConsole: true});
}
error(msg: string) {
this.log(msg, TextColor.Red, {displayConsole: true, outputExternal: true});
}
}
const logger = new Logger({prefix: 'testLogger :: '})
logging typescript
edited Dec 23 at 22:09
200_success
128k15150412
asked Dec 23 at 21:45
user3238415
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
2
2
2
Looking for a critique of this simple logger class I'm working on in my transition to TypeScript.
The purpose of the logging class is to just print to a console either info, warn or error messages.
The main things I'm after feedback on are my usage of the TypeScript type system. I.e interfaces/types/whatever else could be done different or better.
interface LoggerConfig {
prefix?: string;
prefixColor?: TextColor.White;
displayConsole?: boolean;
outputExternal?: boolean;
}
type LogFn = (msg: string) => void;
interface Log {
config: LoggerConfig;
log: (msg: string, logColor: TextColor, override?: LoggerConfig) => void;
info: LogFn;
warn: LogFn;
error: LogFn;
}
class Logger implements Log {
config: LoggerConfig = {
prefix: 'console :: ',
prefixColor: TextColor.Green,
displayConsole: false,
outputExternal: false,
};
constructor(userConfig: LoggerConfig = {}) {
this.config = {...this.config, ...userConfig};
}
log(msg: string, logColor: TextColor, override?: LoggerConfig) {
const config = override ? {...this.config, ...override} : this.config;
const {displayConsole, outputExternal, prefix, prefixColor} = config;
if (displayConsole) {
showConsole();
}
if (outputExternal) {
external.printToConsole(`${prefix} ${msg}`);
}
print(prefixColor + prefix + logColor + ' ' + msg);
}
info(msg: string) {
this.log(msg, TextColor.White);
}
warn(msg: string) {
this.log(msg, TextColor.Yellow, {displayConsole: true});
}
error(msg: string) {
this.log(msg, TextColor.Red, {displayConsole: true, outputExternal: true});
}
}
const logger = new Logger({prefix: 'testLogger :: '})
logging typescript
edited Dec 23 at 22:09
200_success
128k15150412
asked Dec 23 at 21:45
user3238415
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Looking for a critique of this simple logger class I'm working on in my transition to TypeScript.
The purpose of the logging class is to just print to a console either info, warn or error messages.
The main things I'm after feedback on are my usage of the TypeScript type system. I.e interfaces/types/whatever else could be done different or better.
interface LoggerConfig {
prefix?: string;
prefixColor?: TextColor.White;
displayConsole?: boolean;
outputExternal?: boolean;
}
type LogFn = (msg: string) => void;
interface Log {
config: LoggerConfig;
log: (msg: string, logColor: TextColor, override?: LoggerConfig) => void;
info: LogFn;
warn: LogFn;
error: LogFn;
}
class Logger implements Log {
config: LoggerConfig = {
prefix: 'console :: ',
prefixColor: TextColor.Green,
displayConsole: false,
outputExternal: false,
};
constructor(userConfig: LoggerConfig = {}) {
this.config = {...this.config, ...userConfig};
}
log(msg: string, logColor: TextColor, override?: LoggerConfig) {
const config = override ? {...this.config, ...override} : this.config;
const {displayConsole, outputExternal, prefix, prefixColor} = config;
if (displayConsole) {
showConsole();
}
if (outputExternal) {
external.printToConsole(`${prefix} ${msg}`);
}
print(prefixColor + prefix + logColor + ' ' + msg);
}
info(msg: string) {
this.log(msg, TextColor.White);
}
warn(msg: string) {
this.log(msg, TextColor.Yellow, {displayConsole: true});
}
error(msg: string) {
this.log(msg, TextColor.Red, {displayConsole: true, outputExternal: true});
}
}
const logger = new Logger({prefix: 'testLogger :: '})
logging typescript
logging typescript
edited Dec 23 at 22:09
200_success
128k15150412
asked Dec 23 at 21:45
user3238415
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited Dec 23 at 22:09
200_success
128k15150412
asked Dec 23 at 21:45
user3238415
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited Dec 23 at 22:09
200_success
128k15150412
edited Dec 23 at 22:09
200_success
128k15150412
edited Dec 23 at 22:09
200_success
128k15150412
128k15150412
asked Dec 23 at 21:45
user3238415
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked Dec 23 at 21:45
user3238415
111
asked Dec 23 at 21:45
user3238415
111
111
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
user3238415 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
user3238415 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210243%2ftypescript-logger-class%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
user3238415 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
user3238415 is a new contributor. Be nice, and check out our Code of Conduct.
user3238415 is a new contributor. Be nice, and check out our Code of Conduct.
user3238415 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210243%2ftypescript-logger-class%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
