Is WebsiteApp_ConfigIncludeSitecore.Upgrade82.config required after upgrading to Sitecore 9.x?












4














On our Sitecore 9.0.x environments we have a file at WebsiteApp_ConfigIncludeSitecore.Upgrade82.config with the following contents.



<configuration xmlns:patch="http://www.sitecore.net/xmlconfig/" xmlns:set="http://www.sitecore.net/xmlconfig/set/">
<sitecore>
<services>
<register serviceType="Sitecore.Abstractions.BaseFactory, Sitecore.Kernel" implementationType="Sitecore.Upgrade82.Configuration.BackwardCompatibleFactory, Sitecore.Upgrade82" lifetime="Singleton"/>
</services>
</sitecore>
</configuration>


Is there any reason to keep this file after upgrading to Sitecore 9.x? If not, is there anything else related to this file that can also be removed?










share|improve this question





























    4














    On our Sitecore 9.0.x environments we have a file at WebsiteApp_ConfigIncludeSitecore.Upgrade82.config with the following contents.



    <configuration xmlns:patch="http://www.sitecore.net/xmlconfig/" xmlns:set="http://www.sitecore.net/xmlconfig/set/">
    <sitecore>
    <services>
    <register serviceType="Sitecore.Abstractions.BaseFactory, Sitecore.Kernel" implementationType="Sitecore.Upgrade82.Configuration.BackwardCompatibleFactory, Sitecore.Upgrade82" lifetime="Singleton"/>
    </services>
    </sitecore>
    </configuration>


    Is there any reason to keep this file after upgrading to Sitecore 9.x? If not, is there anything else related to this file that can also be removed?










    share|improve this question



























      4












      4








      4







      On our Sitecore 9.0.x environments we have a file at WebsiteApp_ConfigIncludeSitecore.Upgrade82.config with the following contents.



      <configuration xmlns:patch="http://www.sitecore.net/xmlconfig/" xmlns:set="http://www.sitecore.net/xmlconfig/set/">
      <sitecore>
      <services>
      <register serviceType="Sitecore.Abstractions.BaseFactory, Sitecore.Kernel" implementationType="Sitecore.Upgrade82.Configuration.BackwardCompatibleFactory, Sitecore.Upgrade82" lifetime="Singleton"/>
      </services>
      </sitecore>
      </configuration>


      Is there any reason to keep this file after upgrading to Sitecore 9.x? If not, is there anything else related to this file that can also be removed?










      share|improve this question















      On our Sitecore 9.0.x environments we have a file at WebsiteApp_ConfigIncludeSitecore.Upgrade82.config with the following contents.



      <configuration xmlns:patch="http://www.sitecore.net/xmlconfig/" xmlns:set="http://www.sitecore.net/xmlconfig/set/">
      <sitecore>
      <services>
      <register serviceType="Sitecore.Abstractions.BaseFactory, Sitecore.Kernel" implementationType="Sitecore.Upgrade82.Configuration.BackwardCompatibleFactory, Sitecore.Upgrade82" lifetime="Singleton"/>
      </services>
      </sitecore>
      </configuration>


      Is there any reason to keep this file after upgrading to Sitecore 9.x? If not, is there anything else related to this file that can also be removed?







      configuration upgrade






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Dec 27 '18 at 13:45

























      asked Dec 27 '18 at 13:23









      James Skemp

      682215




      682215






















          2 Answers
          2






          active

          oldest

          votes


















          5














          I have had that config after an upgrade as well - and you should have a Sitecore.Upgrade82 dll in your bin folder that comes with it.



          So if you delete the config, you can delete that dll as well.



          But can you delete it? Well, it depends I think. I did and everything was still working but I also used a clean config set from a 9 setup. I decompiled the Upgrade82 dll and it appears to handle config changes. It's main piece of code is



          if (xmlAttribute2 != null && xmlAttribute2.Value.StartsWith("Sitecore.Data.Database"))
          xmlAttribute2.Value = xmlAttribute2.Value.Replace("Sitecore.Data.Database", "Sitecore.Data.DefaultDatabase");


          called on attibutes "type".



          I checked an old 8.1 solution and there you will find the database configs like this:



          <database id="core" singleInstance="true" type="Sitecore.Data.Database, Sitecore.Kernel">


          In 8.2 and up you will find:



          <database id="core" singleInstance="true" type="Sitecore.Data.DefaultDatabase, Sitecore.Kernel">


          So I guess the code is make the old config still work.



          My conclusion: check your config and if you don't have the Sitecore.Data.Database as a type you should be able to delete the config and the dll. That's what I did and it still works..






          share|improve this answer





























            1














            I've never seen neither Sitecore.Upgrade82.config nor Sitecore.Upgrade82.dll. Isn't it something custom built for your website?



            How to check if it's still needed?




            1. Check your code repository when this config file was added. There should some descriptive commit message explaining why this config was added. Unless you're unlucky and whoever added the config didn't bother with explaining why.

            2. The config mentions Sitecore.Upgrade82 assembly. Most probably there will be Sitecore.Upgrade82.dll in bin folder. Decompile the dll and check what is its responsibility. Check if your site would still work without the config and that dll.


            What else may be removed?



            If the answer to the point 2 above is yes, you can definitely remove the Sitecore.Upgrade82.dll file as well. Most probably those are the only 2 things which should be removed, but ideally check your source repository for other things included in the same commit.






            share|improve this answer

















            • 2




              The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
              – Gatogordo
              Dec 27 '18 at 14:11










            • Thanks Gert, good to know :)
              – Marek Musielak
              Dec 27 '18 at 15:48











            Your Answer








            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "664"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fsitecore.stackexchange.com%2fquestions%2f15704%2fis-website-app-config-include-sitecore-upgrade82-config-required-after-upgrading%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            2 Answers
            2






            active

            oldest

            votes








            2 Answers
            2






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            5














            I have had that config after an upgrade as well - and you should have a Sitecore.Upgrade82 dll in your bin folder that comes with it.



            So if you delete the config, you can delete that dll as well.



            But can you delete it? Well, it depends I think. I did and everything was still working but I also used a clean config set from a 9 setup. I decompiled the Upgrade82 dll and it appears to handle config changes. It's main piece of code is



            if (xmlAttribute2 != null && xmlAttribute2.Value.StartsWith("Sitecore.Data.Database"))
            xmlAttribute2.Value = xmlAttribute2.Value.Replace("Sitecore.Data.Database", "Sitecore.Data.DefaultDatabase");


            called on attibutes "type".



            I checked an old 8.1 solution and there you will find the database configs like this:



            <database id="core" singleInstance="true" type="Sitecore.Data.Database, Sitecore.Kernel">


            In 8.2 and up you will find:



            <database id="core" singleInstance="true" type="Sitecore.Data.DefaultDatabase, Sitecore.Kernel">


            So I guess the code is make the old config still work.



            My conclusion: check your config and if you don't have the Sitecore.Data.Database as a type you should be able to delete the config and the dll. That's what I did and it still works..






            share|improve this answer


























              5














              I have had that config after an upgrade as well - and you should have a Sitecore.Upgrade82 dll in your bin folder that comes with it.



              So if you delete the config, you can delete that dll as well.



              But can you delete it? Well, it depends I think. I did and everything was still working but I also used a clean config set from a 9 setup. I decompiled the Upgrade82 dll and it appears to handle config changes. It's main piece of code is



              if (xmlAttribute2 != null && xmlAttribute2.Value.StartsWith("Sitecore.Data.Database"))
              xmlAttribute2.Value = xmlAttribute2.Value.Replace("Sitecore.Data.Database", "Sitecore.Data.DefaultDatabase");


              called on attibutes "type".



              I checked an old 8.1 solution and there you will find the database configs like this:



              <database id="core" singleInstance="true" type="Sitecore.Data.Database, Sitecore.Kernel">


              In 8.2 and up you will find:



              <database id="core" singleInstance="true" type="Sitecore.Data.DefaultDatabase, Sitecore.Kernel">


              So I guess the code is make the old config still work.



              My conclusion: check your config and if you don't have the Sitecore.Data.Database as a type you should be able to delete the config and the dll. That's what I did and it still works..






              share|improve this answer
























                5












                5








                5






                I have had that config after an upgrade as well - and you should have a Sitecore.Upgrade82 dll in your bin folder that comes with it.



                So if you delete the config, you can delete that dll as well.



                But can you delete it? Well, it depends I think. I did and everything was still working but I also used a clean config set from a 9 setup. I decompiled the Upgrade82 dll and it appears to handle config changes. It's main piece of code is



                if (xmlAttribute2 != null && xmlAttribute2.Value.StartsWith("Sitecore.Data.Database"))
                xmlAttribute2.Value = xmlAttribute2.Value.Replace("Sitecore.Data.Database", "Sitecore.Data.DefaultDatabase");


                called on attibutes "type".



                I checked an old 8.1 solution and there you will find the database configs like this:



                <database id="core" singleInstance="true" type="Sitecore.Data.Database, Sitecore.Kernel">


                In 8.2 and up you will find:



                <database id="core" singleInstance="true" type="Sitecore.Data.DefaultDatabase, Sitecore.Kernel">


                So I guess the code is make the old config still work.



                My conclusion: check your config and if you don't have the Sitecore.Data.Database as a type you should be able to delete the config and the dll. That's what I did and it still works..






                share|improve this answer












                I have had that config after an upgrade as well - and you should have a Sitecore.Upgrade82 dll in your bin folder that comes with it.



                So if you delete the config, you can delete that dll as well.



                But can you delete it? Well, it depends I think. I did and everything was still working but I also used a clean config set from a 9 setup. I decompiled the Upgrade82 dll and it appears to handle config changes. It's main piece of code is



                if (xmlAttribute2 != null && xmlAttribute2.Value.StartsWith("Sitecore.Data.Database"))
                xmlAttribute2.Value = xmlAttribute2.Value.Replace("Sitecore.Data.Database", "Sitecore.Data.DefaultDatabase");


                called on attibutes "type".



                I checked an old 8.1 solution and there you will find the database configs like this:



                <database id="core" singleInstance="true" type="Sitecore.Data.Database, Sitecore.Kernel">


                In 8.2 and up you will find:



                <database id="core" singleInstance="true" type="Sitecore.Data.DefaultDatabase, Sitecore.Kernel">


                So I guess the code is make the old config still work.



                My conclusion: check your config and if you don't have the Sitecore.Data.Database as a type you should be able to delete the config and the dll. That's what I did and it still works..







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Dec 27 '18 at 14:07









                Gatogordo

                11.1k21555




                11.1k21555























                    1














                    I've never seen neither Sitecore.Upgrade82.config nor Sitecore.Upgrade82.dll. Isn't it something custom built for your website?



                    How to check if it's still needed?




                    1. Check your code repository when this config file was added. There should some descriptive commit message explaining why this config was added. Unless you're unlucky and whoever added the config didn't bother with explaining why.

                    2. The config mentions Sitecore.Upgrade82 assembly. Most probably there will be Sitecore.Upgrade82.dll in bin folder. Decompile the dll and check what is its responsibility. Check if your site would still work without the config and that dll.


                    What else may be removed?



                    If the answer to the point 2 above is yes, you can definitely remove the Sitecore.Upgrade82.dll file as well. Most probably those are the only 2 things which should be removed, but ideally check your source repository for other things included in the same commit.






                    share|improve this answer

















                    • 2




                      The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
                      – Gatogordo
                      Dec 27 '18 at 14:11










                    • Thanks Gert, good to know :)
                      – Marek Musielak
                      Dec 27 '18 at 15:48
















                    1














                    I've never seen neither Sitecore.Upgrade82.config nor Sitecore.Upgrade82.dll. Isn't it something custom built for your website?



                    How to check if it's still needed?




                    1. Check your code repository when this config file was added. There should some descriptive commit message explaining why this config was added. Unless you're unlucky and whoever added the config didn't bother with explaining why.

                    2. The config mentions Sitecore.Upgrade82 assembly. Most probably there will be Sitecore.Upgrade82.dll in bin folder. Decompile the dll and check what is its responsibility. Check if your site would still work without the config and that dll.


                    What else may be removed?



                    If the answer to the point 2 above is yes, you can definitely remove the Sitecore.Upgrade82.dll file as well. Most probably those are the only 2 things which should be removed, but ideally check your source repository for other things included in the same commit.






                    share|improve this answer

















                    • 2




                      The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
                      – Gatogordo
                      Dec 27 '18 at 14:11










                    • Thanks Gert, good to know :)
                      – Marek Musielak
                      Dec 27 '18 at 15:48














                    1












                    1








                    1






                    I've never seen neither Sitecore.Upgrade82.config nor Sitecore.Upgrade82.dll. Isn't it something custom built for your website?



                    How to check if it's still needed?




                    1. Check your code repository when this config file was added. There should some descriptive commit message explaining why this config was added. Unless you're unlucky and whoever added the config didn't bother with explaining why.

                    2. The config mentions Sitecore.Upgrade82 assembly. Most probably there will be Sitecore.Upgrade82.dll in bin folder. Decompile the dll and check what is its responsibility. Check if your site would still work without the config and that dll.


                    What else may be removed?



                    If the answer to the point 2 above is yes, you can definitely remove the Sitecore.Upgrade82.dll file as well. Most probably those are the only 2 things which should be removed, but ideally check your source repository for other things included in the same commit.






                    share|improve this answer












                    I've never seen neither Sitecore.Upgrade82.config nor Sitecore.Upgrade82.dll. Isn't it something custom built for your website?



                    How to check if it's still needed?




                    1. Check your code repository when this config file was added. There should some descriptive commit message explaining why this config was added. Unless you're unlucky and whoever added the config didn't bother with explaining why.

                    2. The config mentions Sitecore.Upgrade82 assembly. Most probably there will be Sitecore.Upgrade82.dll in bin folder. Decompile the dll and check what is its responsibility. Check if your site would still work without the config and that dll.


                    What else may be removed?



                    If the answer to the point 2 above is yes, you can definitely remove the Sitecore.Upgrade82.dll file as well. Most probably those are the only 2 things which should be removed, but ideally check your source repository for other things included in the same commit.







                    share|improve this answer












                    share|improve this answer



                    share|improve this answer










                    answered Dec 27 '18 at 13:48









                    Marek Musielak

                    9,61511035




                    9,61511035








                    • 2




                      The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
                      – Gatogordo
                      Dec 27 '18 at 14:11










                    • Thanks Gert, good to know :)
                      – Marek Musielak
                      Dec 27 '18 at 15:48














                    • 2




                      The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
                      – Gatogordo
                      Dec 27 '18 at 14:11










                    • Thanks Gert, good to know :)
                      – Marek Musielak
                      Dec 27 '18 at 15:48








                    2




                    2




                    The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
                    – Gatogordo
                    Dec 27 '18 at 14:11




                    The config does not come from custom code - it is a Sitecore one that is added during upgades (depends on the original version).
                    – Gatogordo
                    Dec 27 '18 at 14:11












                    Thanks Gert, good to know :)
                    – Marek Musielak
                    Dec 27 '18 at 15:48




                    Thanks Gert, good to know :)
                    – Marek Musielak
                    Dec 27 '18 at 15:48


















                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Sitecore Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fsitecore.stackexchange.com%2fquestions%2f15704%2fis-website-app-config-include-sitecore-upgrade82-config-required-after-upgrading%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Сан-Квентин

                    8-я гвардейская общевойсковая армия

                    Алькесар