Over-spinning Flickity JS slider
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
0
$begingroup$
I got a bit of a strange JS issue that I could use help on if anyone has time…
Basically if you flick the slider just the wrong way then it'll spin infinitely rather than just settle on a slide and stop. It's a bit hard to get it to do that. I think it has something to do with spinning past the gap between the first/last slide, but I can't quite tell where the problem is.
Do you see anything wrong with the code that might be the cause of that behaviour?
Here’s a reduced case:
https://codepen.io/Julix/pen/xexawP
and proof that it still works:
https://www.youtube.com/watch?v=RQQwsAq5BQU
Here's the JS code from that reduced case:
// Flickity slider from external js: flickity.pkgd.js
// Prev- and next classes from external js: https://codepen.io/desandro/pen/wWQQwN.js
"use strict";
var $carousel = $('.carousel-main').flickity({
"wrapAround": true,
"draggable": true,
"prevNextButtons": false,
"pageDots": false
});
var $nav = $('.carousel-nav').flickity({
"on": {
ready: choseCenterSlide,
scroll: choseCenterSlide
},
"asNavFor": ".carousel-main",
"wrapAround": true,
"percentPosition": false,
"draggable": true,
"pageDots": false,
"prevNextButtons": false
});
;
var navDragging = false;
$nav.on('dragStart.flickity', function () {
return navDragging = true;
});
$nav.on('settle.flickity', function () {
return navDragging = false;
});
$nav.data('flickity').resize();
function choseCenterSlide() {
// check if this.x is within slideableWidth
var currentX = this.x > 0 ? -this.slideableWidth + this.x : this.x < -this.slideableWidth ? this.slideableWidth + this.x : this.x; // calculate closest slide
var distances = this.slides.map(function (slide) {
return -slide.target;
});
var closestDistance = distances.reduce(function (prev, curr) {
return Math.abs(curr - currentX) < Math.abs(prev - currentX) ? curr : prev;
});
var closestSlideIndex = distances.indexOf(closestDistance); // early return
if (closestSlideIndex == this.scrollSlideIndex) return; // register
if (this.scrollSlideIndex == null) this.scrollSlideIndex = this.selectedIndex; // change scrollSlide
this.slides[this.scrollSlideIndex].cells.forEach(function (cell) {
cell.element.classList.remove('is-closest');
});
this.slides[closestSlideIndex].cells.forEach(function (cell) {
cell.element.classList.add('is-closest');
}); // update state variable
this.scrollSlideIndex = closestSlideIndex; // update selectedSlide
if (navDragging) {
this.select(this.scrollSlideIndex);
if (this.navCompanion) {
this.navCompanion.select(this.scrollSlideIndex);
}
}
}
javascript
asked 12 mins ago
JulixJulix
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I got a bit of a strange JS issue that I could use help on if anyone has time…
Basically if you flick the slider just the wrong way then it'll spin infinitely rather than just settle on a slide and stop. It's a bit hard to get it to do that. I think it has something to do with spinning past the gap between the first/last slide, but I can't quite tell where the problem is.
Do you see anything wrong with the code that might be the cause of that behaviour?
Here’s a reduced case:
https://codepen.io/Julix/pen/xexawP
and proof that it still works:
https://www.youtube.com/watch?v=RQQwsAq5BQU
Here's the JS code from that reduced case:
// Flickity slider from external js: flickity.pkgd.js
// Prev- and next classes from external js: https://codepen.io/desandro/pen/wWQQwN.js
"use strict";
var $carousel = $('.carousel-main').flickity({
"wrapAround": true,
"draggable": true,
"prevNextButtons": false,
"pageDots": false
});
var $nav = $('.carousel-nav').flickity({
"on": {
ready: choseCenterSlide,
scroll: choseCenterSlide
},
"asNavFor": ".carousel-main",
"wrapAround": true,
"percentPosition": false,
"draggable": true,
"pageDots": false,
"prevNextButtons": false
});
;
var navDragging = false;
$nav.on('dragStart.flickity', function () {
return navDragging = true;
});
$nav.on('settle.flickity', function () {
return navDragging = false;
});
$nav.data('flickity').resize();
function choseCenterSlide() {
// check if this.x is within slideableWidth
var currentX = this.x > 0 ? -this.slideableWidth + this.x : this.x < -this.slideableWidth ? this.slideableWidth + this.x : this.x; // calculate closest slide
var distances = this.slides.map(function (slide) {
return -slide.target;
});
var closestDistance = distances.reduce(function (prev, curr) {
return Math.abs(curr - currentX) < Math.abs(prev - currentX) ? curr : prev;
});
var closestSlideIndex = distances.indexOf(closestDistance); // early return
if (closestSlideIndex == this.scrollSlideIndex) return; // register
if (this.scrollSlideIndex == null) this.scrollSlideIndex = this.selectedIndex; // change scrollSlide
this.slides[this.scrollSlideIndex].cells.forEach(function (cell) {
cell.element.classList.remove('is-closest');
});
this.slides[closestSlideIndex].cells.forEach(function (cell) {
cell.element.classList.add('is-closest');
}); // update state variable
this.scrollSlideIndex = closestSlideIndex; // update selectedSlide
if (navDragging) {
this.select(this.scrollSlideIndex);
if (this.navCompanion) {
this.navCompanion.select(this.scrollSlideIndex);
}
}
}
javascript
asked 12 mins ago
JulixJulix
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I got a bit of a strange JS issue that I could use help on if anyone has time…
Basically if you flick the slider just the wrong way then it'll spin infinitely rather than just settle on a slide and stop. It's a bit hard to get it to do that. I think it has something to do with spinning past the gap between the first/last slide, but I can't quite tell where the problem is.
Do you see anything wrong with the code that might be the cause of that behaviour?
Here’s a reduced case:
https://codepen.io/Julix/pen/xexawP
and proof that it still works:
https://www.youtube.com/watch?v=RQQwsAq5BQU
Here's the JS code from that reduced case:
// Flickity slider from external js: flickity.pkgd.js
// Prev- and next classes from external js: https://codepen.io/desandro/pen/wWQQwN.js
"use strict";
var $carousel = $('.carousel-main').flickity({
"wrapAround": true,
"draggable": true,
"prevNextButtons": false,
"pageDots": false
});
var $nav = $('.carousel-nav').flickity({
"on": {
ready: choseCenterSlide,
scroll: choseCenterSlide
},
"asNavFor": ".carousel-main",
"wrapAround": true,
"percentPosition": false,
"draggable": true,
"pageDots": false,
"prevNextButtons": false
});
;
var navDragging = false;
$nav.on('dragStart.flickity', function () {
return navDragging = true;
});
$nav.on('settle.flickity', function () {
return navDragging = false;
});
$nav.data('flickity').resize();
function choseCenterSlide() {
// check if this.x is within slideableWidth
var currentX = this.x > 0 ? -this.slideableWidth + this.x : this.x < -this.slideableWidth ? this.slideableWidth + this.x : this.x; // calculate closest slide
var distances = this.slides.map(function (slide) {
return -slide.target;
});
var closestDistance = distances.reduce(function (prev, curr) {
return Math.abs(curr - currentX) < Math.abs(prev - currentX) ? curr : prev;
});
var closestSlideIndex = distances.indexOf(closestDistance); // early return
if (closestSlideIndex == this.scrollSlideIndex) return; // register
if (this.scrollSlideIndex == null) this.scrollSlideIndex = this.selectedIndex; // change scrollSlide
this.slides[this.scrollSlideIndex].cells.forEach(function (cell) {
cell.element.classList.remove('is-closest');
});
this.slides[closestSlideIndex].cells.forEach(function (cell) {
cell.element.classList.add('is-closest');
}); // update state variable
this.scrollSlideIndex = closestSlideIndex; // update selectedSlide
if (navDragging) {
this.select(this.scrollSlideIndex);
if (this.navCompanion) {
this.navCompanion.select(this.scrollSlideIndex);
}
}
}
javascript
asked 12 mins ago
JulixJulix
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I got a bit of a strange JS issue that I could use help on if anyone has time…
Basically if you flick the slider just the wrong way then it'll spin infinitely rather than just settle on a slide and stop. It's a bit hard to get it to do that. I think it has something to do with spinning past the gap between the first/last slide, but I can't quite tell where the problem is.
Do you see anything wrong with the code that might be the cause of that behaviour?
Here’s a reduced case:
https://codepen.io/Julix/pen/xexawP
and proof that it still works:
https://www.youtube.com/watch?v=RQQwsAq5BQU
Here's the JS code from that reduced case:
// Flickity slider from external js: flickity.pkgd.js
// Prev- and next classes from external js: https://codepen.io/desandro/pen/wWQQwN.js
"use strict";
var $carousel = $('.carousel-main').flickity({
"wrapAround": true,
"draggable": true,
"prevNextButtons": false,
"pageDots": false
});
var $nav = $('.carousel-nav').flickity({
"on": {
ready: choseCenterSlide,
scroll: choseCenterSlide
},
"asNavFor": ".carousel-main",
"wrapAround": true,
"percentPosition": false,
"draggable": true,
"pageDots": false,
"prevNextButtons": false
});
;
var navDragging = false;
$nav.on('dragStart.flickity', function () {
return navDragging = true;
});
$nav.on('settle.flickity', function () {
return navDragging = false;
});
$nav.data('flickity').resize();
function choseCenterSlide() {
// check if this.x is within slideableWidth
var currentX = this.x > 0 ? -this.slideableWidth + this.x : this.x < -this.slideableWidth ? this.slideableWidth + this.x : this.x; // calculate closest slide
var distances = this.slides.map(function (slide) {
return -slide.target;
});
var closestDistance = distances.reduce(function (prev, curr) {
return Math.abs(curr - currentX) < Math.abs(prev - currentX) ? curr : prev;
});
var closestSlideIndex = distances.indexOf(closestDistance); // early return
if (closestSlideIndex == this.scrollSlideIndex) return; // register
if (this.scrollSlideIndex == null) this.scrollSlideIndex = this.selectedIndex; // change scrollSlide
this.slides[this.scrollSlideIndex].cells.forEach(function (cell) {
cell.element.classList.remove('is-closest');
});
this.slides[closestSlideIndex].cells.forEach(function (cell) {
cell.element.classList.add('is-closest');
}); // update state variable
this.scrollSlideIndex = closestSlideIndex; // update selectedSlide
if (navDragging) {
this.select(this.scrollSlideIndex);
if (this.navCompanion) {
this.navCompanion.select(this.scrollSlideIndex);
}
}
}
javascript
javascript
asked 12 mins ago
JulixJulix
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
JulixJulix
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
JulixJulix
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
JulixJulix
1013
asked 12 mins ago
JulixJulix
1013
1013
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Julix is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Julix is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217298%2fover-spinning-flickity-js-slider%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Julix is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Julix is a new contributor. Be nice, and check out our Code of Conduct.
Julix is a new contributor. Be nice, and check out our Code of Conduct.
Julix is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217298%2fover-spinning-flickity-js-slider%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
