“First Python program: Tic-Tac-Toe (Followup)





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







0












$begingroup$


This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



'''python 3.7.4'''



import sys
from textwrap import dedent
import os
import random

os.system('CLS')

# board number setup
board = [0, 1, 2,
3, 4, 5,
6, 7, 8]


# Defines the board layout printed to the console
def board_layout():
print(dedent(f'''
*************
* {board[0]} | {board[1]} | {board[2]} *
*-----------*
* {board[3]} | {board[4]} | {board[5]} *
*-----------*
* {board[6]} | {board[7]} | {board[8]} *
*************
'''))


def main():
players = ('Player','NPC')
turn = 'Player'
change_turn = 0
for moves in range(9):
if turn == 'Player':
while True:
try:
board_layout()
player_move = int(input('Please select a spot: '))
if board[player_move] != 'x' and board[player_move] != 'o':
board[player_move] = 'x'
check_winner()
break
except IndexError:
print('please select valid spot')
if turn == 'NPC':
# npc move, chooses a random spot that is not taken
while True:
npc = random.randint(0, 8)
if board[npc] != 'o' and board[npc] != 'x':
board[npc] = 'o'
print('Computer chooses spot ', npc)
check_winner()
break
try:
change_turn += 1
turn = players[change_turn]
except:
change_turn = 0
turn = players[change_turn]
else:
print('You Tied')
end()





def end():
print('Thank you for playing')
answer = input('Would you like to play again?: Y/N')

if answer.lower() == 'n':
quit()
elif answer.lower() == 'y':
clear_board()
main()
else:
print('Please choose a valid option')
end()

def clear_board():
for i in range(9):
board[i] = i

# checks for a winner when called at end of each turn
def check_winner():

# list of lists with all the winning combinations for from the tic tac toe board
winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
[board[6], board[7], board[8]], [board[0], board[4], board[8]],
[board[2], board[4], board[6]],
[board[0], board[3], board[6]], [board[1], board[4], board[7]],
[board[2], board[5], board[8]]]

# iterates over the lists in winning_list
for i, j, k in winning_list:
# looks at the lists in winning_list to determine if a list has all x's for a win
if i == 'x' and j == 'x' and k == 'x':
print('X wins')
end()
# looks at the lists in winning_list to determine if a list has all o's for a win
elif i == 'o' and j == 'o' and k == 'o':
print('O wins')
end()


if __name__ == "__main__":
main()








share







New contributor




andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$



















    0












    $begingroup$


    This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
    I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



    '''python 3.7.4'''



    import sys
    from textwrap import dedent
    import os
    import random

    os.system('CLS')

    # board number setup
    board = [0, 1, 2,
    3, 4, 5,
    6, 7, 8]


    # Defines the board layout printed to the console
    def board_layout():
    print(dedent(f'''
    *************
    * {board[0]} | {board[1]} | {board[2]} *
    *-----------*
    * {board[3]} | {board[4]} | {board[5]} *
    *-----------*
    * {board[6]} | {board[7]} | {board[8]} *
    *************
    '''))


    def main():
    players = ('Player','NPC')
    turn = 'Player'
    change_turn = 0
    for moves in range(9):
    if turn == 'Player':
    while True:
    try:
    board_layout()
    player_move = int(input('Please select a spot: '))
    if board[player_move] != 'x' and board[player_move] != 'o':
    board[player_move] = 'x'
    check_winner()
    break
    except IndexError:
    print('please select valid spot')
    if turn == 'NPC':
    # npc move, chooses a random spot that is not taken
    while True:
    npc = random.randint(0, 8)
    if board[npc] != 'o' and board[npc] != 'x':
    board[npc] = 'o'
    print('Computer chooses spot ', npc)
    check_winner()
    break
    try:
    change_turn += 1
    turn = players[change_turn]
    except:
    change_turn = 0
    turn = players[change_turn]
    else:
    print('You Tied')
    end()





    def end():
    print('Thank you for playing')
    answer = input('Would you like to play again?: Y/N')

    if answer.lower() == 'n':
    quit()
    elif answer.lower() == 'y':
    clear_board()
    main()
    else:
    print('Please choose a valid option')
    end()

    def clear_board():
    for i in range(9):
    board[i] = i

    # checks for a winner when called at end of each turn
    def check_winner():

    # list of lists with all the winning combinations for from the tic tac toe board
    winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
    [board[6], board[7], board[8]], [board[0], board[4], board[8]],
    [board[2], board[4], board[6]],
    [board[0], board[3], board[6]], [board[1], board[4], board[7]],
    [board[2], board[5], board[8]]]

    # iterates over the lists in winning_list
    for i, j, k in winning_list:
    # looks at the lists in winning_list to determine if a list has all x's for a win
    if i == 'x' and j == 'x' and k == 'x':
    print('X wins')
    end()
    # looks at the lists in winning_list to determine if a list has all o's for a win
    elif i == 'o' and j == 'o' and k == 'o':
    print('O wins')
    end()


    if __name__ == "__main__":
    main()








    share







    New contributor




    andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
      I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



      '''python 3.7.4'''



      import sys
      from textwrap import dedent
      import os
      import random

      os.system('CLS')

      # board number setup
      board = [0, 1, 2,
      3, 4, 5,
      6, 7, 8]


      # Defines the board layout printed to the console
      def board_layout():
      print(dedent(f'''
      *************
      * {board[0]} | {board[1]} | {board[2]} *
      *-----------*
      * {board[3]} | {board[4]} | {board[5]} *
      *-----------*
      * {board[6]} | {board[7]} | {board[8]} *
      *************
      '''))


      def main():
      players = ('Player','NPC')
      turn = 'Player'
      change_turn = 0
      for moves in range(9):
      if turn == 'Player':
      while True:
      try:
      board_layout()
      player_move = int(input('Please select a spot: '))
      if board[player_move] != 'x' and board[player_move] != 'o':
      board[player_move] = 'x'
      check_winner()
      break
      except IndexError:
      print('please select valid spot')
      if turn == 'NPC':
      # npc move, chooses a random spot that is not taken
      while True:
      npc = random.randint(0, 8)
      if board[npc] != 'o' and board[npc] != 'x':
      board[npc] = 'o'
      print('Computer chooses spot ', npc)
      check_winner()
      break
      try:
      change_turn += 1
      turn = players[change_turn]
      except:
      change_turn = 0
      turn = players[change_turn]
      else:
      print('You Tied')
      end()





      def end():
      print('Thank you for playing')
      answer = input('Would you like to play again?: Y/N')

      if answer.lower() == 'n':
      quit()
      elif answer.lower() == 'y':
      clear_board()
      main()
      else:
      print('Please choose a valid option')
      end()

      def clear_board():
      for i in range(9):
      board[i] = i

      # checks for a winner when called at end of each turn
      def check_winner():

      # list of lists with all the winning combinations for from the tic tac toe board
      winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
      [board[6], board[7], board[8]], [board[0], board[4], board[8]],
      [board[2], board[4], board[6]],
      [board[0], board[3], board[6]], [board[1], board[4], board[7]],
      [board[2], board[5], board[8]]]

      # iterates over the lists in winning_list
      for i, j, k in winning_list:
      # looks at the lists in winning_list to determine if a list has all x's for a win
      if i == 'x' and j == 'x' and k == 'x':
      print('X wins')
      end()
      # looks at the lists in winning_list to determine if a list has all o's for a win
      elif i == 'o' and j == 'o' and k == 'o':
      print('O wins')
      end()


      if __name__ == "__main__":
      main()








      share







      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      This is the new code, I am unsure if I made the suggestions the the suggestion intended on my previous post First Python program: Tic-Tac-Toe.
      I have only been working on programming for about 3 weeks so anymore suggestions or insight on the original post of the suggestions would be more than welcomed.



      '''python 3.7.4'''



      import sys
      from textwrap import dedent
      import os
      import random

      os.system('CLS')

      # board number setup
      board = [0, 1, 2,
      3, 4, 5,
      6, 7, 8]


      # Defines the board layout printed to the console
      def board_layout():
      print(dedent(f'''
      *************
      * {board[0]} | {board[1]} | {board[2]} *
      *-----------*
      * {board[3]} | {board[4]} | {board[5]} *
      *-----------*
      * {board[6]} | {board[7]} | {board[8]} *
      *************
      '''))


      def main():
      players = ('Player','NPC')
      turn = 'Player'
      change_turn = 0
      for moves in range(9):
      if turn == 'Player':
      while True:
      try:
      board_layout()
      player_move = int(input('Please select a spot: '))
      if board[player_move] != 'x' and board[player_move] != 'o':
      board[player_move] = 'x'
      check_winner()
      break
      except IndexError:
      print('please select valid spot')
      if turn == 'NPC':
      # npc move, chooses a random spot that is not taken
      while True:
      npc = random.randint(0, 8)
      if board[npc] != 'o' and board[npc] != 'x':
      board[npc] = 'o'
      print('Computer chooses spot ', npc)
      check_winner()
      break
      try:
      change_turn += 1
      turn = players[change_turn]
      except:
      change_turn = 0
      turn = players[change_turn]
      else:
      print('You Tied')
      end()





      def end():
      print('Thank you for playing')
      answer = input('Would you like to play again?: Y/N')

      if answer.lower() == 'n':
      quit()
      elif answer.lower() == 'y':
      clear_board()
      main()
      else:
      print('Please choose a valid option')
      end()

      def clear_board():
      for i in range(9):
      board[i] = i

      # checks for a winner when called at end of each turn
      def check_winner():

      # list of lists with all the winning combinations for from the tic tac toe board
      winning_list = [[board[0], board[1], board[2]], [board[3], board[4], board[5], ],
      [board[6], board[7], board[8]], [board[0], board[4], board[8]],
      [board[2], board[4], board[6]],
      [board[0], board[3], board[6]], [board[1], board[4], board[7]],
      [board[2], board[5], board[8]]]

      # iterates over the lists in winning_list
      for i, j, k in winning_list:
      # looks at the lists in winning_list to determine if a list has all x's for a win
      if i == 'x' and j == 'x' and k == 'x':
      print('X wins')
      end()
      # looks at the lists in winning_list to determine if a list has all o's for a win
      elif i == 'o' and j == 'o' and k == 'o':
      print('O wins')
      end()


      if __name__ == "__main__":
      main()






      beginner python-3.x tic-tac-toe





      share







      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 4 mins ago









      andrewtwandrewtw

      215




      215




      New contributor




      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      andrewtw is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217304%2ffirst-python-program-tic-tac-toe-followup%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.













          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.












          andrewtw is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217304%2ffirst-python-program-tic-tac-toe-followup%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Сан-Квентин

          8-я гвардейская общевойсковая армия

          Алькесар