Nesting 3 divs within another div using JavaScript





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







0












$begingroup$


For a class that I'm in, we're creating digital Pokemon cards. I'm trying to create elements that are nested within another element and repeated multiple times. For example, I have currently:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


But, I only want 3 of the box divs to be inside the column div and then for this model to repeat for every 3 box divs so that it looks like this:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


And I want that to repeat until all of the box divs are filled into a column div.



The javascript that I used to make these divs is the following:



function createPokeCard(pokeData) {
let scene = document.createElement('div')
let card = document.createElement('div')

scene.className = 'scene'
card.className = 'box'

card.addEventListener( 'click', function() {
card.classList.toggle('is-flipped')
})

card.appendChild(cardFront(pokeData))
card.appendChild(cardBack(pokeData))
mainContainer.appendChild(card)
mainContainer.appendChild(section)
mainContainer.appendChild(columns)
mainContainer.appendChild(column)
section.appendChild(columns)
columns.appendChild(column)
columns.appendChild(card)
column.appendChild(card)
}


Can you review this code for best coding practices?










share|improve this question









New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$








  • 1




    $begingroup$
    Don't alter the HTML to suit your layout. Layout should be done using CSS.
    $endgroup$
    – 200_success
    yesterday










  • $begingroup$
    Sorry, can you explain a bit more in depth what you mean? I don't quite understand.
    $endgroup$
    – Ben
    yesterday


















0












$begingroup$


For a class that I'm in, we're creating digital Pokemon cards. I'm trying to create elements that are nested within another element and repeated multiple times. For example, I have currently:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


But, I only want 3 of the box divs to be inside the column div and then for this model to repeat for every 3 box divs so that it looks like this:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


And I want that to repeat until all of the box divs are filled into a column div.



The javascript that I used to make these divs is the following:



function createPokeCard(pokeData) {
let scene = document.createElement('div')
let card = document.createElement('div')

scene.className = 'scene'
card.className = 'box'

card.addEventListener( 'click', function() {
card.classList.toggle('is-flipped')
})

card.appendChild(cardFront(pokeData))
card.appendChild(cardBack(pokeData))
mainContainer.appendChild(card)
mainContainer.appendChild(section)
mainContainer.appendChild(columns)
mainContainer.appendChild(column)
section.appendChild(columns)
columns.appendChild(column)
columns.appendChild(card)
column.appendChild(card)
}


Can you review this code for best coding practices?










share|improve this question









New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$








  • 1




    $begingroup$
    Don't alter the HTML to suit your layout. Layout should be done using CSS.
    $endgroup$
    – 200_success
    yesterday










  • $begingroup$
    Sorry, can you explain a bit more in depth what you mean? I don't quite understand.
    $endgroup$
    – Ben
    yesterday














0












0








0





$begingroup$


For a class that I'm in, we're creating digital Pokemon cards. I'm trying to create elements that are nested within another element and repeated multiple times. For example, I have currently:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


But, I only want 3 of the box divs to be inside the column div and then for this model to repeat for every 3 box divs so that it looks like this:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


And I want that to repeat until all of the box divs are filled into a column div.



The javascript that I used to make these divs is the following:



function createPokeCard(pokeData) {
let scene = document.createElement('div')
let card = document.createElement('div')

scene.className = 'scene'
card.className = 'box'

card.addEventListener( 'click', function() {
card.classList.toggle('is-flipped')
})

card.appendChild(cardFront(pokeData))
card.appendChild(cardBack(pokeData))
mainContainer.appendChild(card)
mainContainer.appendChild(section)
mainContainer.appendChild(columns)
mainContainer.appendChild(column)
section.appendChild(columns)
columns.appendChild(column)
columns.appendChild(card)
column.appendChild(card)
}


Can you review this code for best coding practices?










share|improve this question









New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$




For a class that I'm in, we're creating digital Pokemon cards. I'm trying to create elements that are nested within another element and repeated multiple times. For example, I have currently:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


But, I only want 3 of the box divs to be inside the column div and then for this model to repeat for every 3 box divs so that it looks like this:



<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>
<div class="columns">
<div class="column">
<div class="box"></div>
<div class="box"></div>
<div class="box"></div>
</div>
</div>


And I want that to repeat until all of the box divs are filled into a column div.



The javascript that I used to make these divs is the following:



function createPokeCard(pokeData) {
let scene = document.createElement('div')
let card = document.createElement('div')

scene.className = 'scene'
card.className = 'box'

card.addEventListener( 'click', function() {
card.classList.toggle('is-flipped')
})

card.appendChild(cardFront(pokeData))
card.appendChild(cardBack(pokeData))
mainContainer.appendChild(card)
mainContainer.appendChild(section)
mainContainer.appendChild(columns)
mainContainer.appendChild(column)
section.appendChild(columns)
columns.appendChild(column)
columns.appendChild(card)
column.appendChild(card)
}


Can you review this code for best coding practices?







javascript html






share|improve this question









New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question









New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question








edited 3 mins ago









Emma

1651214




1651214






New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked yesterday









BenBen

111




111




New contributor




Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Ben is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.








  • 1




    $begingroup$
    Don't alter the HTML to suit your layout. Layout should be done using CSS.
    $endgroup$
    – 200_success
    yesterday










  • $begingroup$
    Sorry, can you explain a bit more in depth what you mean? I don't quite understand.
    $endgroup$
    – Ben
    yesterday














  • 1




    $begingroup$
    Don't alter the HTML to suit your layout. Layout should be done using CSS.
    $endgroup$
    – 200_success
    yesterday










  • $begingroup$
    Sorry, can you explain a bit more in depth what you mean? I don't quite understand.
    $endgroup$
    – Ben
    yesterday








1




1




$begingroup$
Don't alter the HTML to suit your layout. Layout should be done using CSS.
$endgroup$
– 200_success
yesterday




$begingroup$
Don't alter the HTML to suit your layout. Layout should be done using CSS.
$endgroup$
– 200_success
yesterday












$begingroup$
Sorry, can you explain a bit more in depth what you mean? I don't quite understand.
$endgroup$
– Ben
yesterday




$begingroup$
Sorry, can you explain a bit more in depth what you mean? I don't quite understand.
$endgroup$
– Ben
yesterday










0






active

oldest

votes












Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});






Ben is a new contributor. Be nice, and check out our Code of Conduct.










draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216942%2fnesting-3-divs-within-another-div-using-javascript%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes








Ben is a new contributor. Be nice, and check out our Code of Conduct.










draft saved

draft discarded


















Ben is a new contributor. Be nice, and check out our Code of Conduct.













Ben is a new contributor. Be nice, and check out our Code of Conduct.












Ben is a new contributor. Be nice, and check out our Code of Conduct.
















Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216942%2fnesting-3-divs-within-another-div-using-javascript%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Сан-Квентин

Алькесар

Josef Freinademetz