Parse tokens into statements for compiling efficiently
0
$begingroup$
I'm not going to throw the whole 881 sloc at you :P. You can see the code here on GitHub but I am going to ask about one part, and that is the makeExpression function.
func makeExpression(_ group: Subgroup) throws - > Expression {
// Set scope
scope = #function
print("(group)")
switch group.count {
case 1:
let tkn = group[0]
switch tkn.type {
case .literal:
return Expression(rep: try expressionRep(
for: tkn))
default:
return Expression(rep: .token(tkn))
}
case 3 where group[1].type == .dot:
let access = AccessStatement(object: group[0], key: group[2])
return Expression(rep: .access(access))
case 3...where group[1].type == .leftPar:
let name = group[0]
guard name.type == .identifier
else {
throw ErrorFC(.expectedIdentifier)
}
let args =
try parseCommaSeperated( in: Subgroup(group[1...]), end: [.rightPar]).map(makeExpression)
let call = CallStatement(name: name, args: args)
return Expression(rep: .call(call))
default:
throw ErrorFC(.anyError)
}
}
Note
type alias Subgroup = [Token]is used
I have been trying to figure out if the code is efficient. It is definitely not final as I have yet to support operators, but that is not part of this question. The code now is supposed to parse 3 expressions:
- Literals
- Dot-notation property access
- Function calls
Are there any more efficient ways of doing this?
performance parsing swift
asked 15 mins ago
Import AccelerateImport Accelerate
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I'm not going to throw the whole 881 sloc at you :P. You can see the code here on GitHub but I am going to ask about one part, and that is the makeExpression function.
func makeExpression(_ group: Subgroup) throws - > Expression {
// Set scope
scope = #function
print("(group)")
switch group.count {
case 1:
let tkn = group[0]
switch tkn.type {
case .literal:
return Expression(rep: try expressionRep(
for: tkn))
default:
return Expression(rep: .token(tkn))
}
case 3 where group[1].type == .dot:
let access = AccessStatement(object: group[0], key: group[2])
return Expression(rep: .access(access))
case 3...where group[1].type == .leftPar:
let name = group[0]
guard name.type == .identifier
else {
throw ErrorFC(.expectedIdentifier)
}
let args =
try parseCommaSeperated( in: Subgroup(group[1...]), end: [.rightPar]).map(makeExpression)
let call = CallStatement(name: name, args: args)
return Expression(rep: .call(call))
default:
throw ErrorFC(.anyError)
}
}
Note
type alias Subgroup = [Token]is used
I have been trying to figure out if the code is efficient. It is definitely not final as I have yet to support operators, but that is not part of this question. The code now is supposed to parse 3 expressions:
- Literals
- Dot-notation property access
- Function calls
Are there any more efficient ways of doing this?
performance parsing swift
asked 15 mins ago
Import AccelerateImport Accelerate
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I'm not going to throw the whole 881 sloc at you :P. You can see the code here on GitHub but I am going to ask about one part, and that is the makeExpression function.
func makeExpression(_ group: Subgroup) throws - > Expression {
// Set scope
scope = #function
print("(group)")
switch group.count {
case 1:
let tkn = group[0]
switch tkn.type {
case .literal:
return Expression(rep: try expressionRep(
for: tkn))
default:
return Expression(rep: .token(tkn))
}
case 3 where group[1].type == .dot:
let access = AccessStatement(object: group[0], key: group[2])
return Expression(rep: .access(access))
case 3...where group[1].type == .leftPar:
let name = group[0]
guard name.type == .identifier
else {
throw ErrorFC(.expectedIdentifier)
}
let args =
try parseCommaSeperated( in: Subgroup(group[1...]), end: [.rightPar]).map(makeExpression)
let call = CallStatement(name: name, args: args)
return Expression(rep: .call(call))
default:
throw ErrorFC(.anyError)
}
}
Note
type alias Subgroup = [Token]is used
I have been trying to figure out if the code is efficient. It is definitely not final as I have yet to support operators, but that is not part of this question. The code now is supposed to parse 3 expressions:
- Literals
- Dot-notation property access
- Function calls
Are there any more efficient ways of doing this?
performance parsing swift
asked 15 mins ago
Import AccelerateImport Accelerate
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I'm not going to throw the whole 881 sloc at you :P. You can see the code here on GitHub but I am going to ask about one part, and that is the makeExpression function.
func makeExpression(_ group: Subgroup) throws - > Expression {
// Set scope
scope = #function
print("(group)")
switch group.count {
case 1:
let tkn = group[0]
switch tkn.type {
case .literal:
return Expression(rep: try expressionRep(
for: tkn))
default:
return Expression(rep: .token(tkn))
}
case 3 where group[1].type == .dot:
let access = AccessStatement(object: group[0], key: group[2])
return Expression(rep: .access(access))
case 3...where group[1].type == .leftPar:
let name = group[0]
guard name.type == .identifier
else {
throw ErrorFC(.expectedIdentifier)
}
let args =
try parseCommaSeperated( in: Subgroup(group[1...]), end: [.rightPar]).map(makeExpression)
let call = CallStatement(name: name, args: args)
return Expression(rep: .call(call))
default:
throw ErrorFC(.anyError)
}
}
Note
type alias Subgroup = [Token]is used
I have been trying to figure out if the code is efficient. It is definitely not final as I have yet to support operators, but that is not part of this question. The code now is supposed to parse 3 expressions:
- Literals
- Dot-notation property access
- Function calls
Are there any more efficient ways of doing this?
performance parsing swift
performance parsing swift
asked 15 mins ago
Import AccelerateImport Accelerate
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 15 mins ago
Import AccelerateImport Accelerate
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 15 mins ago
Import AccelerateImport Accelerate
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 15 mins ago
Import AccelerateImport Accelerate
11
asked 15 mins ago
Import AccelerateImport Accelerate
11
11
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Import Accelerate is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Import Accelerate is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212952%2fparse-tokens-into-statements-for-compiling-efficiently%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Import Accelerate is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Import Accelerate is a new contributor. Be nice, and check out our Code of Conduct.
Import Accelerate is a new contributor. Be nice, and check out our Code of Conduct.
Import Accelerate is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212952%2fparse-tokens-into-statements-for-compiling-efficiently%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
