Avoiding if else statements and switch statements
$begingroup$
Consider I have a cron expression as "* * */2 * " I have to extract the recurrence on days ,hours and minutes if it is not "" . I have the below function which works as well.
public void CronDivision(string cron)
{
string days, value;
string cronDiv = cron.split(' ');
if(cronDiv[2] != "*")
{
days = "Days"
value = cronDiv[2].split('/')[1];
}
else if(cron[1] != "*)
{
//Similar logic
}
else if(cron[0] != "*)
{
//Similar logic
}
else if(cron[3] != "*)
{
//different logic for extracting weeks
}
else if(cron[3] != "*)
{
//different logic for extracting years
}
}
How do I generalize the above function so that I dont want to use if else/switch statements with hardcoded numbers like1,2,3 and so on after the division of cron expression.
Can it be made more readable without the obvious solution of splitting the actual cron expression and extracting it. Basically I need a cleaner approach for this problem without usage of numbers like 1,2,3 etc?
c# .net asp.net asp.net-mvc
asked 3 mins ago
user1907849user1907849
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Consider I have a cron expression as "* * */2 * " I have to extract the recurrence on days ,hours and minutes if it is not "" . I have the below function which works as well.
public void CronDivision(string cron)
{
string days, value;
string cronDiv = cron.split(' ');
if(cronDiv[2] != "*")
{
days = "Days"
value = cronDiv[2].split('/')[1];
}
else if(cron[1] != "*)
{
//Similar logic
}
else if(cron[0] != "*)
{
//Similar logic
}
else if(cron[3] != "*)
{
//different logic for extracting weeks
}
else if(cron[3] != "*)
{
//different logic for extracting years
}
}
How do I generalize the above function so that I dont want to use if else/switch statements with hardcoded numbers like1,2,3 and so on after the division of cron expression.
Can it be made more readable without the obvious solution of splitting the actual cron expression and extracting it. Basically I need a cleaner approach for this problem without usage of numbers like 1,2,3 etc?
c# .net asp.net asp.net-mvc
asked 3 mins ago
user1907849user1907849
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Consider I have a cron expression as "* * */2 * " I have to extract the recurrence on days ,hours and minutes if it is not "" . I have the below function which works as well.
public void CronDivision(string cron)
{
string days, value;
string cronDiv = cron.split(' ');
if(cronDiv[2] != "*")
{
days = "Days"
value = cronDiv[2].split('/')[1];
}
else if(cron[1] != "*)
{
//Similar logic
}
else if(cron[0] != "*)
{
//Similar logic
}
else if(cron[3] != "*)
{
//different logic for extracting weeks
}
else if(cron[3] != "*)
{
//different logic for extracting years
}
}
How do I generalize the above function so that I dont want to use if else/switch statements with hardcoded numbers like1,2,3 and so on after the division of cron expression.
Can it be made more readable without the obvious solution of splitting the actual cron expression and extracting it. Basically I need a cleaner approach for this problem without usage of numbers like 1,2,3 etc?
c# .net asp.net asp.net-mvc
asked 3 mins ago
user1907849user1907849
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Consider I have a cron expression as "* * */2 * " I have to extract the recurrence on days ,hours and minutes if it is not "" . I have the below function which works as well.
public void CronDivision(string cron)
{
string days, value;
string cronDiv = cron.split(' ');
if(cronDiv[2] != "*")
{
days = "Days"
value = cronDiv[2].split('/')[1];
}
else if(cron[1] != "*)
{
//Similar logic
}
else if(cron[0] != "*)
{
//Similar logic
}
else if(cron[3] != "*)
{
//different logic for extracting weeks
}
else if(cron[3] != "*)
{
//different logic for extracting years
}
}
How do I generalize the above function so that I dont want to use if else/switch statements with hardcoded numbers like1,2,3 and so on after the division of cron expression.
Can it be made more readable without the obvious solution of splitting the actual cron expression and extracting it. Basically I need a cleaner approach for this problem without usage of numbers like 1,2,3 etc?
c# .net asp.net asp.net-mvc
c# .net asp.net asp.net-mvc
asked 3 mins ago
user1907849user1907849
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
user1907849user1907849
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
user1907849user1907849
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
user1907849user1907849
101
asked 3 mins ago
user1907849user1907849
101
101
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
user1907849 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
user1907849 is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211843%2favoiding-if-else-statements-and-switch-statements%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
user1907849 is a new contributor. Be nice, and check out our Code of Conduct.
user1907849 is a new contributor. Be nice, and check out our Code of Conduct.
user1907849 is a new contributor. Be nice, and check out our Code of Conduct.
user1907849 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211843%2favoiding-if-else-statements-and-switch-statements%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
