Password Checker using Pwnedpasswords API in Rust












0












$begingroup$


Takes user password, hashes password to sha1 and does a check against the Pwnedpasswords database.



I know I need to use unwrap less and do more real checking to improve the clarity of errors. In what other places is my code lacking and what should I learn or look at to improve in the future.



The current resources I am using are the Rust by Example, the documentation for the crates I used and in general looking at rust code on GitHub.



$ cargo run --bin checker -- check
Password: *********
Password is (not) compromised


#[macro_use] extern crate clap;
extern crate crypto;
extern crate reqwest;
extern crate regex;
extern crate rpassword;

use crypto::digest::Digest;
use crypto::sha1::Sha1;
use clap::App;
use regex::Regex;

/* loads clap cli config
* if the check subcommand is used, run check
*/
fn main () {
let yaml = load_yaml!("config/clap_cli.yml");
let matches = App::from_yaml(yaml).get_matches();

if let Some(_m_check) = matches.subcommand_matches("check") {
check();
}

}

/* get password from user
* hash the password
* check against pwned database
* tell user if the password is bad
*/
fn check () {
let value = &rpassword::prompt_password_stdout("Password: ")
.unwrap();
let mut hasher = Sha1::new();

hasher.input_str(value);
let pass_hash = hasher.result_str().to_uppercase();
let pass_hash_slice = pass_hash.get(0..5).unwrap();
let pass_hash_end = pass_hash.get(5..).unwrap();


let body = reqwest::get(
&format!("https://api.pwnedpasswords.com/range/{}", pass_hash_slice)
).unwrap().text().unwrap();

let re_pass = Regex::new(&pass_hash_end).unwrap();

if re_pass.is_match(&body) {
println!("Password is compromised.");
} else {
println!("Password is not compromised.");
}
}









share|improve this question







New contributor




furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    Takes user password, hashes password to sha1 and does a check against the Pwnedpasswords database.



    I know I need to use unwrap less and do more real checking to improve the clarity of errors. In what other places is my code lacking and what should I learn or look at to improve in the future.



    The current resources I am using are the Rust by Example, the documentation for the crates I used and in general looking at rust code on GitHub.



    $ cargo run --bin checker -- check
    Password: *********
    Password is (not) compromised


    #[macro_use] extern crate clap;
    extern crate crypto;
    extern crate reqwest;
    extern crate regex;
    extern crate rpassword;

    use crypto::digest::Digest;
    use crypto::sha1::Sha1;
    use clap::App;
    use regex::Regex;

    /* loads clap cli config
    * if the check subcommand is used, run check
    */
    fn main () {
    let yaml = load_yaml!("config/clap_cli.yml");
    let matches = App::from_yaml(yaml).get_matches();

    if let Some(_m_check) = matches.subcommand_matches("check") {
    check();
    }

    }

    /* get password from user
    * hash the password
    * check against pwned database
    * tell user if the password is bad
    */
    fn check () {
    let value = &rpassword::prompt_password_stdout("Password: ")
    .unwrap();
    let mut hasher = Sha1::new();

    hasher.input_str(value);
    let pass_hash = hasher.result_str().to_uppercase();
    let pass_hash_slice = pass_hash.get(0..5).unwrap();
    let pass_hash_end = pass_hash.get(5..).unwrap();


    let body = reqwest::get(
    &format!("https://api.pwnedpasswords.com/range/{}", pass_hash_slice)
    ).unwrap().text().unwrap();

    let re_pass = Regex::new(&pass_hash_end).unwrap();

    if re_pass.is_match(&body) {
    println!("Password is compromised.");
    } else {
    println!("Password is not compromised.");
    }
    }









    share|improve this question







    New contributor




    furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      Takes user password, hashes password to sha1 and does a check against the Pwnedpasswords database.



      I know I need to use unwrap less and do more real checking to improve the clarity of errors. In what other places is my code lacking and what should I learn or look at to improve in the future.



      The current resources I am using are the Rust by Example, the documentation for the crates I used and in general looking at rust code on GitHub.



      $ cargo run --bin checker -- check
      Password: *********
      Password is (not) compromised


      #[macro_use] extern crate clap;
      extern crate crypto;
      extern crate reqwest;
      extern crate regex;
      extern crate rpassword;

      use crypto::digest::Digest;
      use crypto::sha1::Sha1;
      use clap::App;
      use regex::Regex;

      /* loads clap cli config
      * if the check subcommand is used, run check
      */
      fn main () {
      let yaml = load_yaml!("config/clap_cli.yml");
      let matches = App::from_yaml(yaml).get_matches();

      if let Some(_m_check) = matches.subcommand_matches("check") {
      check();
      }

      }

      /* get password from user
      * hash the password
      * check against pwned database
      * tell user if the password is bad
      */
      fn check () {
      let value = &rpassword::prompt_password_stdout("Password: ")
      .unwrap();
      let mut hasher = Sha1::new();

      hasher.input_str(value);
      let pass_hash = hasher.result_str().to_uppercase();
      let pass_hash_slice = pass_hash.get(0..5).unwrap();
      let pass_hash_end = pass_hash.get(5..).unwrap();


      let body = reqwest::get(
      &format!("https://api.pwnedpasswords.com/range/{}", pass_hash_slice)
      ).unwrap().text().unwrap();

      let re_pass = Regex::new(&pass_hash_end).unwrap();

      if re_pass.is_match(&body) {
      println!("Password is compromised.");
      } else {
      println!("Password is not compromised.");
      }
      }









      share|improve this question







      New contributor




      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Takes user password, hashes password to sha1 and does a check against the Pwnedpasswords database.



      I know I need to use unwrap less and do more real checking to improve the clarity of errors. In what other places is my code lacking and what should I learn or look at to improve in the future.



      The current resources I am using are the Rust by Example, the documentation for the crates I used and in general looking at rust code on GitHub.



      $ cargo run --bin checker -- check
      Password: *********
      Password is (not) compromised


      #[macro_use] extern crate clap;
      extern crate crypto;
      extern crate reqwest;
      extern crate regex;
      extern crate rpassword;

      use crypto::digest::Digest;
      use crypto::sha1::Sha1;
      use clap::App;
      use regex::Regex;

      /* loads clap cli config
      * if the check subcommand is used, run check
      */
      fn main () {
      let yaml = load_yaml!("config/clap_cli.yml");
      let matches = App::from_yaml(yaml).get_matches();

      if let Some(_m_check) = matches.subcommand_matches("check") {
      check();
      }

      }

      /* get password from user
      * hash the password
      * check against pwned database
      * tell user if the password is bad
      */
      fn check () {
      let value = &rpassword::prompt_password_stdout("Password: ")
      .unwrap();
      let mut hasher = Sha1::new();

      hasher.input_str(value);
      let pass_hash = hasher.result_str().to_uppercase();
      let pass_hash_slice = pass_hash.get(0..5).unwrap();
      let pass_hash_end = pass_hash.get(5..).unwrap();


      let body = reqwest::get(
      &format!("https://api.pwnedpasswords.com/range/{}", pass_hash_slice)
      ).unwrap().text().unwrap();

      let re_pass = Regex::new(&pass_hash_end).unwrap();

      if re_pass.is_match(&body) {
      println!("Password is compromised.");
      } else {
      println!("Password is not compromised.");
      }
      }






      api rust






      share|improve this question







      New contributor




      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 11 mins ago









      furcbfurcb

      1




      1




      New contributor




      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      furcb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          furcb is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215584%2fpassword-checker-using-pwnedpasswords-api-in-rust%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          furcb is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          furcb is a new contributor. Be nice, and check out our Code of Conduct.













          furcb is a new contributor. Be nice, and check out our Code of Conduct.












          furcb is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215584%2fpassword-checker-using-pwnedpasswords-api-in-rust%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Terni

          A new problem with tex4ht and tikz

          Sun Ra