Factory method pattern as type guard for classes with trait












0












$begingroup$


I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?



class SearchableModel extends Model
{
use Searchable;

public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
{
return $searchable;
}

}

public function someMethod(Searchable $model) {
$model = SearchableModel::from($model);
$model->search('term');
}


P.S. My motivation is using static analysis









share







New contributor




matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?



    class SearchableModel extends Model
    {
    use Searchable;

    public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
    {
    return $searchable;
    }

    }

    public function someMethod(Searchable $model) {
    $model = SearchableModel::from($model);
    $model->search('term');
    }


    P.S. My motivation is using static analysis









    share







    New contributor




    matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?



      class SearchableModel extends Model
      {
      use Searchable;

      public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
      {
      return $searchable;
      }

      }

      public function someMethod(Searchable $model) {
      $model = SearchableModel::from($model);
      $model->search('term');
      }


      P.S. My motivation is using static analysis









      share







      New contributor




      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I want to accept an eloquent model with a trait in some method. I can't type hint it, so I created guard class with factory method and using it for type checking. Is there code smell?



      class SearchableModel extends Model
      {
      use Searchable;

      public static function from(Searchable $searchable) :IlluminateDatabaseEloquentModel
      {
      return $searchable;
      }

      }

      public function someMethod(Searchable $model) {
      $model = SearchableModel::from($model);
      $model->search('term');
      }


      P.S. My motivation is using static analysis







      laravel factory-method type-safety trait





      share







      New contributor




      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 9 mins ago









      matchishmatchish

      1014




      1014




      New contributor




      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      matchish is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          matchish is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214815%2ffactory-method-pattern-as-type-guard-for-classes-with-trait%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          matchish is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          matchish is a new contributor. Be nice, and check out our Code of Conduct.













          matchish is a new contributor. Be nice, and check out our Code of Conduct.












          matchish is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214815%2ffactory-method-pattern-as-type-guard-for-classes-with-trait%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Сан-Квентин

          Алькесар

          Josef Freinademetz