C# convert Raw(8-bit or 10-bit or 12-bit or 14-bit or 16-bit) Image to bmp
0
$begingroup$
I have some Raw Images files(Raw8 or Raw10 or Raw12 or Raw14 or Raw16...). I want to convert Raw to bmp.
The code runs but I still have some issues with the results.
public void ReadImage(out byte Data, string path, uint Width, uint Height,uint BPP){
byte fileData = null;
if (!File.Exists(path))
{
throw new FileNotFoundException(path);
}
fileData = File.ReadAllBytes(path);
var bytesPerPixel = (BPP + 7) / 8;
var dataSize = Width * Height * bytesPerPixel;
Data = new byte[Width * Height * bytesPerPixel];
var sdata = new short[dataSize / 2];
if (bytesPerPixel == 1)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i], fileData[i + 1], out sdata[shortIndex], (int)BPP, false);
}
}
if (bytesPerPixel == 2)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i],fileData[i + 1], out sdata[shortIndex], (int)BPP, true);
}
}
Buffer.BlockCopy(sdata, 0, Data, 0, Data.Length);
int w = Convert.ToInt32(Width);
int h = Convert.ToInt32(Height);
unsafe
{
fixed (byte* ptr = Data)
{
using (var bmp = new Bitmap(w / 4, h / 4, w * 4, PixelFormat.Format32bppRgb, new IntPtr(ptr)))
{
Bitmap dmybp = new Bitmap(bmp, new Size(w, h));
dmybp.Save(@"RAW.bmp", System.Drawing.Imaging.ImageFormat.Bmp);
}
}
}
}
private void CopyBytesToShort(byte byte1, byte byte2, out short retShort, int bitsPerPixel, bool isPerformShift)
{
short lsb, msb;
lsb = byte1;
msb = byte2;
if (isPerformShift)
{
lsb <<= 16 - bitsPerPixel;
msb <<= (24 - bitsPerPixel);
}
else
{
msb <<= 8;
}
retShort = (short)(msb | lsb);
}
if i run with Raw8 can get correct image.
But when i run other RAW file(Raw10 or Raw12 or Raw14 or Raw16...), I got fail image.
Like this:
Please comment about about optimizing my code in C# and if there a better way to convert an image.
c# image
asked 7 mins ago
lovecindy929lovecindy929
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I have some Raw Images files(Raw8 or Raw10 or Raw12 or Raw14 or Raw16...). I want to convert Raw to bmp.
The code runs but I still have some issues with the results.
public void ReadImage(out byte Data, string path, uint Width, uint Height,uint BPP){
byte fileData = null;
if (!File.Exists(path))
{
throw new FileNotFoundException(path);
}
fileData = File.ReadAllBytes(path);
var bytesPerPixel = (BPP + 7) / 8;
var dataSize = Width * Height * bytesPerPixel;
Data = new byte[Width * Height * bytesPerPixel];
var sdata = new short[dataSize / 2];
if (bytesPerPixel == 1)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i], fileData[i + 1], out sdata[shortIndex], (int)BPP, false);
}
}
if (bytesPerPixel == 2)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i],fileData[i + 1], out sdata[shortIndex], (int)BPP, true);
}
}
Buffer.BlockCopy(sdata, 0, Data, 0, Data.Length);
int w = Convert.ToInt32(Width);
int h = Convert.ToInt32(Height);
unsafe
{
fixed (byte* ptr = Data)
{
using (var bmp = new Bitmap(w / 4, h / 4, w * 4, PixelFormat.Format32bppRgb, new IntPtr(ptr)))
{
Bitmap dmybp = new Bitmap(bmp, new Size(w, h));
dmybp.Save(@"RAW.bmp", System.Drawing.Imaging.ImageFormat.Bmp);
}
}
}
}
private void CopyBytesToShort(byte byte1, byte byte2, out short retShort, int bitsPerPixel, bool isPerformShift)
{
short lsb, msb;
lsb = byte1;
msb = byte2;
if (isPerformShift)
{
lsb <<= 16 - bitsPerPixel;
msb <<= (24 - bitsPerPixel);
}
else
{
msb <<= 8;
}
retShort = (short)(msb | lsb);
}
if i run with Raw8 can get correct image.
But when i run other RAW file(Raw10 or Raw12 or Raw14 or Raw16...), I got fail image.
Like this:
Please comment about about optimizing my code in C# and if there a better way to convert an image.
c# image
asked 7 mins ago
lovecindy929lovecindy929
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I have some Raw Images files(Raw8 or Raw10 or Raw12 or Raw14 or Raw16...). I want to convert Raw to bmp.
The code runs but I still have some issues with the results.
public void ReadImage(out byte Data, string path, uint Width, uint Height,uint BPP){
byte fileData = null;
if (!File.Exists(path))
{
throw new FileNotFoundException(path);
}
fileData = File.ReadAllBytes(path);
var bytesPerPixel = (BPP + 7) / 8;
var dataSize = Width * Height * bytesPerPixel;
Data = new byte[Width * Height * bytesPerPixel];
var sdata = new short[dataSize / 2];
if (bytesPerPixel == 1)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i], fileData[i + 1], out sdata[shortIndex], (int)BPP, false);
}
}
if (bytesPerPixel == 2)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i],fileData[i + 1], out sdata[shortIndex], (int)BPP, true);
}
}
Buffer.BlockCopy(sdata, 0, Data, 0, Data.Length);
int w = Convert.ToInt32(Width);
int h = Convert.ToInt32(Height);
unsafe
{
fixed (byte* ptr = Data)
{
using (var bmp = new Bitmap(w / 4, h / 4, w * 4, PixelFormat.Format32bppRgb, new IntPtr(ptr)))
{
Bitmap dmybp = new Bitmap(bmp, new Size(w, h));
dmybp.Save(@"RAW.bmp", System.Drawing.Imaging.ImageFormat.Bmp);
}
}
}
}
private void CopyBytesToShort(byte byte1, byte byte2, out short retShort, int bitsPerPixel, bool isPerformShift)
{
short lsb, msb;
lsb = byte1;
msb = byte2;
if (isPerformShift)
{
lsb <<= 16 - bitsPerPixel;
msb <<= (24 - bitsPerPixel);
}
else
{
msb <<= 8;
}
retShort = (short)(msb | lsb);
}
if i run with Raw8 can get correct image.
But when i run other RAW file(Raw10 or Raw12 or Raw14 or Raw16...), I got fail image.
Like this:
Please comment about about optimizing my code in C# and if there a better way to convert an image.
c# image
asked 7 mins ago
lovecindy929lovecindy929
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I have some Raw Images files(Raw8 or Raw10 or Raw12 or Raw14 or Raw16...). I want to convert Raw to bmp.
The code runs but I still have some issues with the results.
public void ReadImage(out byte Data, string path, uint Width, uint Height,uint BPP){
byte fileData = null;
if (!File.Exists(path))
{
throw new FileNotFoundException(path);
}
fileData = File.ReadAllBytes(path);
var bytesPerPixel = (BPP + 7) / 8;
var dataSize = Width * Height * bytesPerPixel;
Data = new byte[Width * Height * bytesPerPixel];
var sdata = new short[dataSize / 2];
if (bytesPerPixel == 1)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i], fileData[i + 1], out sdata[shortIndex], (int)BPP, false);
}
}
if (bytesPerPixel == 2)
{
for (int i = 0, shortIndex = 0; i < dataSize; i += 2, shortIndex++)
{
CopyBytesToShort(fileData[i],fileData[i + 1], out sdata[shortIndex], (int)BPP, true);
}
}
Buffer.BlockCopy(sdata, 0, Data, 0, Data.Length);
int w = Convert.ToInt32(Width);
int h = Convert.ToInt32(Height);
unsafe
{
fixed (byte* ptr = Data)
{
using (var bmp = new Bitmap(w / 4, h / 4, w * 4, PixelFormat.Format32bppRgb, new IntPtr(ptr)))
{
Bitmap dmybp = new Bitmap(bmp, new Size(w, h));
dmybp.Save(@"RAW.bmp", System.Drawing.Imaging.ImageFormat.Bmp);
}
}
}
}
private void CopyBytesToShort(byte byte1, byte byte2, out short retShort, int bitsPerPixel, bool isPerformShift)
{
short lsb, msb;
lsb = byte1;
msb = byte2;
if (isPerformShift)
{
lsb <<= 16 - bitsPerPixel;
msb <<= (24 - bitsPerPixel);
}
else
{
msb <<= 8;
}
retShort = (short)(msb | lsb);
}
if i run with Raw8 can get correct image.
But when i run other RAW file(Raw10 or Raw12 or Raw14 or Raw16...), I got fail image.
Like this:
Please comment about about optimizing my code in C# and if there a better way to convert an image.
c# image
c# image
asked 7 mins ago
lovecindy929lovecindy929
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
lovecindy929lovecindy929
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
lovecindy929lovecindy929
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
lovecindy929lovecindy929
1
asked 7 mins ago
lovecindy929lovecindy929
1
1
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
lovecindy929 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
lovecindy929 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212120%2fc-convert-raw8-bit-or-10-bit-or-12-bit-or-14-bit-or-16-bit-image-to-bmp%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
lovecindy929 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
lovecindy929 is a new contributor. Be nice, and check out our Code of Conduct.
lovecindy929 is a new contributor. Be nice, and check out our Code of Conduct.
lovecindy929 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212120%2fc-convert-raw8-bit-or-10-bit-or-12-bit-or-14-bit-or-16-bit-image-to-bmp%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
