I've got enums on top of enums, and then some more traits for those enums… it's getting unwieldy
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
$begingroup$
So I have an enum wrapping an enum, but I have another enum talking about what that enum is.
Which makes for a confusing English sentence, so here's an example.
I got one enum:
enum Example {
A(Something),
B{ structfield: K },
C(Gamma, Third),
D(InsertSomethingElseCrazyHereThatCantImplementANYTraitsCauseReasons),
}
Which is all fine and dandy, but I needed another way to categorize them and compare the categories without matching. I also needed to pass along Example
s without fields, and then I realized that I should probably use an enum describing my enum, so I ended up doing this:
#[derive(Eq, PartialEq, YouGetThePoint)]
enum ExampleCategory {
A, B, C, D
}
Then, cause I wanna easily go from Example
to ExampleCategory
:
impl From<Example> for ExampleCategory {
fn from(e: Example) {
match e {
Example::A(_) => ExampleCategory::A
Example::B{..} => ExampleCategory::B
Example::C(_,_,_) => ExampleCategory::C,
Example::D(_) => ExampleCategory::D
}
}
}
So now, every time I need to add an Example, I end up needing to change code in three different places, and if I want a new trait... etc. Also, if the
Somethingin
Example::A` were another kind of this enum. *shudders
I think I made my point on why this is probably a bad idea.
I'm 90% positive there's a better way to do this (that doesn't involve macros since I don't even know how I would go about doing that). How would I change this to be more DRY/better? Since the Example enum is actually a part of a larger issue.
rust enum
New contributor
$endgroup$
add a comment |
$begingroup$
So I have an enum wrapping an enum, but I have another enum talking about what that enum is.
Which makes for a confusing English sentence, so here's an example.
I got one enum:
enum Example {
A(Something),
B{ structfield: K },
C(Gamma, Third),
D(InsertSomethingElseCrazyHereThatCantImplementANYTraitsCauseReasons),
}
Which is all fine and dandy, but I needed another way to categorize them and compare the categories without matching. I also needed to pass along Example
s without fields, and then I realized that I should probably use an enum describing my enum, so I ended up doing this:
#[derive(Eq, PartialEq, YouGetThePoint)]
enum ExampleCategory {
A, B, C, D
}
Then, cause I wanna easily go from Example
to ExampleCategory
:
impl From<Example> for ExampleCategory {
fn from(e: Example) {
match e {
Example::A(_) => ExampleCategory::A
Example::B{..} => ExampleCategory::B
Example::C(_,_,_) => ExampleCategory::C,
Example::D(_) => ExampleCategory::D
}
}
}
So now, every time I need to add an Example, I end up needing to change code in three different places, and if I want a new trait... etc. Also, if the
Somethingin
Example::A` were another kind of this enum. *shudders
I think I made my point on why this is probably a bad idea.
I'm 90% positive there's a better way to do this (that doesn't involve macros since I don't even know how I would go about doing that). How would I change this to be more DRY/better? Since the Example enum is actually a part of a larger issue.
rust enum
New contributor
$endgroup$
add a comment |
$begingroup$
So I have an enum wrapping an enum, but I have another enum talking about what that enum is.
Which makes for a confusing English sentence, so here's an example.
I got one enum:
enum Example {
A(Something),
B{ structfield: K },
C(Gamma, Third),
D(InsertSomethingElseCrazyHereThatCantImplementANYTraitsCauseReasons),
}
Which is all fine and dandy, but I needed another way to categorize them and compare the categories without matching. I also needed to pass along Example
s without fields, and then I realized that I should probably use an enum describing my enum, so I ended up doing this:
#[derive(Eq, PartialEq, YouGetThePoint)]
enum ExampleCategory {
A, B, C, D
}
Then, cause I wanna easily go from Example
to ExampleCategory
:
impl From<Example> for ExampleCategory {
fn from(e: Example) {
match e {
Example::A(_) => ExampleCategory::A
Example::B{..} => ExampleCategory::B
Example::C(_,_,_) => ExampleCategory::C,
Example::D(_) => ExampleCategory::D
}
}
}
So now, every time I need to add an Example, I end up needing to change code in three different places, and if I want a new trait... etc. Also, if the
Somethingin
Example::A` were another kind of this enum. *shudders
I think I made my point on why this is probably a bad idea.
I'm 90% positive there's a better way to do this (that doesn't involve macros since I don't even know how I would go about doing that). How would I change this to be more DRY/better? Since the Example enum is actually a part of a larger issue.
rust enum
New contributor
$endgroup$
So I have an enum wrapping an enum, but I have another enum talking about what that enum is.
Which makes for a confusing English sentence, so here's an example.
I got one enum:
enum Example {
A(Something),
B{ structfield: K },
C(Gamma, Third),
D(InsertSomethingElseCrazyHereThatCantImplementANYTraitsCauseReasons),
}
Which is all fine and dandy, but I needed another way to categorize them and compare the categories without matching. I also needed to pass along Example
s without fields, and then I realized that I should probably use an enum describing my enum, so I ended up doing this:
#[derive(Eq, PartialEq, YouGetThePoint)]
enum ExampleCategory {
A, B, C, D
}
Then, cause I wanna easily go from Example
to ExampleCategory
:
impl From<Example> for ExampleCategory {
fn from(e: Example) {
match e {
Example::A(_) => ExampleCategory::A
Example::B{..} => ExampleCategory::B
Example::C(_,_,_) => ExampleCategory::C,
Example::D(_) => ExampleCategory::D
}
}
}
So now, every time I need to add an Example, I end up needing to change code in three different places, and if I want a new trait... etc. Also, if the
Somethingin
Example::A` were another kind of this enum. *shudders
I think I made my point on why this is probably a bad idea.
I'm 90% positive there's a better way to do this (that doesn't involve macros since I don't even know how I would go about doing that). How would I change this to be more DRY/better? Since the Example enum is actually a part of a larger issue.
rust enum
rust enum
New contributor
New contributor
New contributor
asked 40 mins ago
AlterionXAlterionX
1
1
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
AlterionX is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217530%2five-got-enums-on-top-of-enums-and-then-some-more-traits-for-those-enums-it%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
AlterionX is a new contributor. Be nice, and check out our Code of Conduct.
AlterionX is a new contributor. Be nice, and check out our Code of Conduct.
AlterionX is a new contributor. Be nice, and check out our Code of Conduct.
AlterionX is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217530%2five-got-enums-on-top-of-enums-and-then-some-more-traits-for-those-enums-it%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown