How to write an efficient code for the following tic-tac-toe game?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
0
$begingroup$
I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?
def restart():
num=[0 for i in range(9)]
board=[" " for i in range(9)]
a=2
start(board,a,num)
def wincheck(t):
for i in range(8):
if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
if t[win[i][0]]=="X":
print("Player 1 wins")
else:
print("Player 2 wins")
playa = input("Do you want to play again? Y/N")
if playa.lower() == "y":
restart()
else:
exit(0)
def display_board(t,a,num):
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[6],t[7],t[8]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[3],t[4],t[5]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[0],t[1],t[2]))
print( " "*3+'|'+" "*3+'|'+" "*3)
wincheck(t)
if 0 not in num:
print("Draw")
restart()
start(t,a,num)
def start(board,a,num):
if a%2==0:
p1n=int(input("Player 1, Enter a number from 1 to 9"))
if p1n not in num:
num[p1n-1]=p1n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p1n-1]="X"
a=a+1
display_board(board,a,num)
else:
p2n=int(input("Player 2, Enter a number from 1 to 9"))
if p2n not in num:
num[p2n-1]=p2n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p2n-1]="O"
a=a+1
display_board(board,a,num)
a=2
board=[" " for i in range(9)]
num=[0 for i in range(9)]
win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]
start(board,a,num)
python-3.x tic-tac-toe
asked 7 mins ago
IrfanIrfan
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?
def restart():
num=[0 for i in range(9)]
board=[" " for i in range(9)]
a=2
start(board,a,num)
def wincheck(t):
for i in range(8):
if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
if t[win[i][0]]=="X":
print("Player 1 wins")
else:
print("Player 2 wins")
playa = input("Do you want to play again? Y/N")
if playa.lower() == "y":
restart()
else:
exit(0)
def display_board(t,a,num):
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[6],t[7],t[8]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[3],t[4],t[5]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[0],t[1],t[2]))
print( " "*3+'|'+" "*3+'|'+" "*3)
wincheck(t)
if 0 not in num:
print("Draw")
restart()
start(t,a,num)
def start(board,a,num):
if a%2==0:
p1n=int(input("Player 1, Enter a number from 1 to 9"))
if p1n not in num:
num[p1n-1]=p1n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p1n-1]="X"
a=a+1
display_board(board,a,num)
else:
p2n=int(input("Player 2, Enter a number from 1 to 9"))
if p2n not in num:
num[p2n-1]=p2n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p2n-1]="O"
a=a+1
display_board(board,a,num)
a=2
board=[" " for i in range(9)]
num=[0 for i in range(9)]
win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]
start(board,a,num)
python-3.x tic-tac-toe
asked 7 mins ago
IrfanIrfan
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?
def restart():
num=[0 for i in range(9)]
board=[" " for i in range(9)]
a=2
start(board,a,num)
def wincheck(t):
for i in range(8):
if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
if t[win[i][0]]=="X":
print("Player 1 wins")
else:
print("Player 2 wins")
playa = input("Do you want to play again? Y/N")
if playa.lower() == "y":
restart()
else:
exit(0)
def display_board(t,a,num):
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[6],t[7],t[8]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[3],t[4],t[5]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[0],t[1],t[2]))
print( " "*3+'|'+" "*3+'|'+" "*3)
wincheck(t)
if 0 not in num:
print("Draw")
restart()
start(t,a,num)
def start(board,a,num):
if a%2==0:
p1n=int(input("Player 1, Enter a number from 1 to 9"))
if p1n not in num:
num[p1n-1]=p1n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p1n-1]="X"
a=a+1
display_board(board,a,num)
else:
p2n=int(input("Player 2, Enter a number from 1 to 9"))
if p2n not in num:
num[p2n-1]=p2n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p2n-1]="O"
a=a+1
display_board(board,a,num)
a=2
board=[" " for i in range(9)]
num=[0 for i in range(9)]
win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]
start(board,a,num)
python-3.x tic-tac-toe
asked 7 mins ago
IrfanIrfan
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?
def restart():
num=[0 for i in range(9)]
board=[" " for i in range(9)]
a=2
start(board,a,num)
def wincheck(t):
for i in range(8):
if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
if t[win[i][0]]=="X":
print("Player 1 wins")
else:
print("Player 2 wins")
playa = input("Do you want to play again? Y/N")
if playa.lower() == "y":
restart()
else:
exit(0)
def display_board(t,a,num):
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[6],t[7],t[8]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[3],t[4],t[5]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("{0:^3}|{1:^3}|{2:^3}".format(t[0],t[1],t[2]))
print( " "*3+'|'+" "*3+'|'+" "*3)
wincheck(t)
if 0 not in num:
print("Draw")
restart()
start(t,a,num)
def start(board,a,num):
if a%2==0:
p1n=int(input("Player 1, Enter a number from 1 to 9"))
if p1n not in num:
num[p1n-1]=p1n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p1n-1]="X"
a=a+1
display_board(board,a,num)
else:
p2n=int(input("Player 2, Enter a number from 1 to 9"))
if p2n not in num:
num[p2n-1]=p2n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p2n-1]="O"
a=a+1
display_board(board,a,num)
a=2
board=[" " for i in range(9)]
num=[0 for i in range(9)]
win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]
start(board,a,num)
python-3.x tic-tac-toe
python-3.x tic-tac-toe
asked 7 mins ago
IrfanIrfan
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
IrfanIrfan
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
IrfanIrfan
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
IrfanIrfan
1
asked 7 mins ago
IrfanIrfan
1
1
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Irfan is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216967%2fhow-to-write-an-efficient-code-for-the-following-tic-tac-toe-game%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Irfan is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Irfan is a new contributor. Be nice, and check out our Code of Conduct.
Irfan is a new contributor. Be nice, and check out our Code of Conduct.
Irfan is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216967%2fhow-to-write-an-efficient-code-for-the-following-tic-tac-toe-game%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
