An arithmetic operation app in C#
$begingroup$
One of my friends was creating and app with following requirements and having been with a slightly more coding experience, I wanted to help:
Create a calculator that does one arithmetic operation at a time and
prints the result to the screen.
- Prompt the user for a number.
- Prompt the user for an operation (+ - / *).
- Prompt the user for another number.
- Perform the operation.
- Print the result to the screen.
- Repeat until the user types in “quit” at any of the prompts.
using System;
namespace Calc
{
class Program
{
static void Main(string args)
{
// We are creating the strings and integers we need beforehand.
// These will be updated according to the user input.
string firstInput = "";
string secondInput = "";
string operand = "";
double x = 0;
double y = 0;
while (true)
{
Console.WriteLine("You can quit any time by typing "quit".");
Console.WriteLine("Please enter the first number:");
First:
firstInput = Console.ReadLine();
try
{
if (firstInput.ToLower() != "quit")
{
x = double.Parse(firstInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto First;
}
Console.WriteLine("Please enter an operand (+, -, *, /):");
Second:
operand = Console.ReadLine();
//We need to make sure user has entered a proper operator.
if (operand.ToLower() == "quit")
{
break;
}
else if (!((operand == "+") || (operand == "-") || (operand == "*") || (operand == "/")))
{
Console.WriteLine("Invalid input. Please enter one of the following: +, - , *, /.");
goto Second;
}
else
{
// No problem. Keep going.
}
Console.WriteLine("Please enter the second number:");
Third:
secondInput = Console.ReadLine();
try
{
if (secondInput.ToLower() != "quit")
{
y = double.Parse(secondInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto Third;
}
// We have all we need if program has run up until this line.
// We can now check which operand is entered to determine the result.
if (operand == "+")
{
Console.WriteLine($"{firstInput} + {secondInput} = {x + y}");
}
else if (operand == "-")
{
Console.WriteLine($"{firstInput} - {secondInput} = {x - y}");
}
else if (operand == "*")
{
Console.WriteLine($"{firstInput} * {secondInput} = {x * y}");
}
else if (operand == "/")
{
Console.WriteLine($"{firstInput} / {secondInput} = {x / y}");
}
else
{
Console.WriteLine("Error! You must have entered invalid input.");
}
Console.WriteLine("Press any key to throw me away like a Kleenex.");
Console.ReadKey();
break;
}
}
}
}
Couple things I've attempted/found out so far:
Instead of checking whether "quit" has been entered every time, I
tried to use following with no success:while (!((firstInput.ToLower() == "quit") || (secondInput.ToLower() == "quit") || (operand.ToLower() == "quit")))Apparently C# has "String Interpolation" too, like in JS (I guess with ES6) which was considered as a good practice among my colleagues if nothing else, for readability.
I know usage of "goto" is not considered well usually. Though it seemed quite practical with the labels. Priorly, I had thought it was only used in switch cases.
About exception handling, I haven't had much use before when I messed around in Java, but I suppose it's one of the most fundamental features of higher level languages to keep program more prune to run-time errors. This one particularly came to my head when I realized user could potentially enter some input that can't be parsed properly.
I don't know, there's not much to do given that problem and implementation is quite simple, but I still think it's a good opportunity to develop good practices if I were to somewhat get involved with gaming development, for example (Unity etc.).
I've been recently coding Haskell, Python, JavaScript and I have C/C++ background but this is the first time I laid my hands on an .NET/C# app.
I have tinkered with Java before, but I don't really have much experience with higher level languages. Anyways, long story short, I'd like to see what could have been done better and what are the things that are considered as good/bad practice that could be particularly viewed in this small code snippet.
P.S: I'm a bit aware that comments are a bit overly-done, but it's intentional for obvious reasons. Thanks in advance.
c# beginner .net
asked 1 hour ago
BonelliaBonellia
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
One of my friends was creating and app with following requirements and having been with a slightly more coding experience, I wanted to help:
Create a calculator that does one arithmetic operation at a time and
prints the result to the screen.
- Prompt the user for a number.
- Prompt the user for an operation (+ - / *).
- Prompt the user for another number.
- Perform the operation.
- Print the result to the screen.
- Repeat until the user types in “quit” at any of the prompts.
using System;
namespace Calc
{
class Program
{
static void Main(string args)
{
// We are creating the strings and integers we need beforehand.
// These will be updated according to the user input.
string firstInput = "";
string secondInput = "";
string operand = "";
double x = 0;
double y = 0;
while (true)
{
Console.WriteLine("You can quit any time by typing "quit".");
Console.WriteLine("Please enter the first number:");
First:
firstInput = Console.ReadLine();
try
{
if (firstInput.ToLower() != "quit")
{
x = double.Parse(firstInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto First;
}
Console.WriteLine("Please enter an operand (+, -, *, /):");
Second:
operand = Console.ReadLine();
//We need to make sure user has entered a proper operator.
if (operand.ToLower() == "quit")
{
break;
}
else if (!((operand == "+") || (operand == "-") || (operand == "*") || (operand == "/")))
{
Console.WriteLine("Invalid input. Please enter one of the following: +, - , *, /.");
goto Second;
}
else
{
// No problem. Keep going.
}
Console.WriteLine("Please enter the second number:");
Third:
secondInput = Console.ReadLine();
try
{
if (secondInput.ToLower() != "quit")
{
y = double.Parse(secondInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto Third;
}
// We have all we need if program has run up until this line.
// We can now check which operand is entered to determine the result.
if (operand == "+")
{
Console.WriteLine($"{firstInput} + {secondInput} = {x + y}");
}
else if (operand == "-")
{
Console.WriteLine($"{firstInput} - {secondInput} = {x - y}");
}
else if (operand == "*")
{
Console.WriteLine($"{firstInput} * {secondInput} = {x * y}");
}
else if (operand == "/")
{
Console.WriteLine($"{firstInput} / {secondInput} = {x / y}");
}
else
{
Console.WriteLine("Error! You must have entered invalid input.");
}
Console.WriteLine("Press any key to throw me away like a Kleenex.");
Console.ReadKey();
break;
}
}
}
}
Couple things I've attempted/found out so far:
Instead of checking whether "quit" has been entered every time, I
tried to use following with no success:while (!((firstInput.ToLower() == "quit") || (secondInput.ToLower() == "quit") || (operand.ToLower() == "quit")))Apparently C# has "String Interpolation" too, like in JS (I guess with ES6) which was considered as a good practice among my colleagues if nothing else, for readability.
I know usage of "goto" is not considered well usually. Though it seemed quite practical with the labels. Priorly, I had thought it was only used in switch cases.
About exception handling, I haven't had much use before when I messed around in Java, but I suppose it's one of the most fundamental features of higher level languages to keep program more prune to run-time errors. This one particularly came to my head when I realized user could potentially enter some input that can't be parsed properly.
I don't know, there's not much to do given that problem and implementation is quite simple, but I still think it's a good opportunity to develop good practices if I were to somewhat get involved with gaming development, for example (Unity etc.).
I've been recently coding Haskell, Python, JavaScript and I have C/C++ background but this is the first time I laid my hands on an .NET/C# app.
I have tinkered with Java before, but I don't really have much experience with higher level languages. Anyways, long story short, I'd like to see what could have been done better and what are the things that are considered as good/bad practice that could be particularly viewed in this small code snippet.
P.S: I'm a bit aware that comments are a bit overly-done, but it's intentional for obvious reasons. Thanks in advance.
c# beginner .net
asked 1 hour ago
BonelliaBonellia
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
One of my friends was creating and app with following requirements and having been with a slightly more coding experience, I wanted to help:
Create a calculator that does one arithmetic operation at a time and
prints the result to the screen.
- Prompt the user for a number.
- Prompt the user for an operation (+ - / *).
- Prompt the user for another number.
- Perform the operation.
- Print the result to the screen.
- Repeat until the user types in “quit” at any of the prompts.
using System;
namespace Calc
{
class Program
{
static void Main(string args)
{
// We are creating the strings and integers we need beforehand.
// These will be updated according to the user input.
string firstInput = "";
string secondInput = "";
string operand = "";
double x = 0;
double y = 0;
while (true)
{
Console.WriteLine("You can quit any time by typing "quit".");
Console.WriteLine("Please enter the first number:");
First:
firstInput = Console.ReadLine();
try
{
if (firstInput.ToLower() != "quit")
{
x = double.Parse(firstInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto First;
}
Console.WriteLine("Please enter an operand (+, -, *, /):");
Second:
operand = Console.ReadLine();
//We need to make sure user has entered a proper operator.
if (operand.ToLower() == "quit")
{
break;
}
else if (!((operand == "+") || (operand == "-") || (operand == "*") || (operand == "/")))
{
Console.WriteLine("Invalid input. Please enter one of the following: +, - , *, /.");
goto Second;
}
else
{
// No problem. Keep going.
}
Console.WriteLine("Please enter the second number:");
Third:
secondInput = Console.ReadLine();
try
{
if (secondInput.ToLower() != "quit")
{
y = double.Parse(secondInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto Third;
}
// We have all we need if program has run up until this line.
// We can now check which operand is entered to determine the result.
if (operand == "+")
{
Console.WriteLine($"{firstInput} + {secondInput} = {x + y}");
}
else if (operand == "-")
{
Console.WriteLine($"{firstInput} - {secondInput} = {x - y}");
}
else if (operand == "*")
{
Console.WriteLine($"{firstInput} * {secondInput} = {x * y}");
}
else if (operand == "/")
{
Console.WriteLine($"{firstInput} / {secondInput} = {x / y}");
}
else
{
Console.WriteLine("Error! You must have entered invalid input.");
}
Console.WriteLine("Press any key to throw me away like a Kleenex.");
Console.ReadKey();
break;
}
}
}
}
Couple things I've attempted/found out so far:
Instead of checking whether "quit" has been entered every time, I
tried to use following with no success:while (!((firstInput.ToLower() == "quit") || (secondInput.ToLower() == "quit") || (operand.ToLower() == "quit")))Apparently C# has "String Interpolation" too, like in JS (I guess with ES6) which was considered as a good practice among my colleagues if nothing else, for readability.
I know usage of "goto" is not considered well usually. Though it seemed quite practical with the labels. Priorly, I had thought it was only used in switch cases.
About exception handling, I haven't had much use before when I messed around in Java, but I suppose it's one of the most fundamental features of higher level languages to keep program more prune to run-time errors. This one particularly came to my head when I realized user could potentially enter some input that can't be parsed properly.
I don't know, there's not much to do given that problem and implementation is quite simple, but I still think it's a good opportunity to develop good practices if I were to somewhat get involved with gaming development, for example (Unity etc.).
I've been recently coding Haskell, Python, JavaScript and I have C/C++ background but this is the first time I laid my hands on an .NET/C# app.
I have tinkered with Java before, but I don't really have much experience with higher level languages. Anyways, long story short, I'd like to see what could have been done better and what are the things that are considered as good/bad practice that could be particularly viewed in this small code snippet.
P.S: I'm a bit aware that comments are a bit overly-done, but it's intentional for obvious reasons. Thanks in advance.
c# beginner .net
asked 1 hour ago
BonelliaBonellia
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
One of my friends was creating and app with following requirements and having been with a slightly more coding experience, I wanted to help:
Create a calculator that does one arithmetic operation at a time and
prints the result to the screen.
- Prompt the user for a number.
- Prompt the user for an operation (+ - / *).
- Prompt the user for another number.
- Perform the operation.
- Print the result to the screen.
- Repeat until the user types in “quit” at any of the prompts.
using System;
namespace Calc
{
class Program
{
static void Main(string args)
{
// We are creating the strings and integers we need beforehand.
// These will be updated according to the user input.
string firstInput = "";
string secondInput = "";
string operand = "";
double x = 0;
double y = 0;
while (true)
{
Console.WriteLine("You can quit any time by typing "quit".");
Console.WriteLine("Please enter the first number:");
First:
firstInput = Console.ReadLine();
try
{
if (firstInput.ToLower() != "quit")
{
x = double.Parse(firstInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto First;
}
Console.WriteLine("Please enter an operand (+, -, *, /):");
Second:
operand = Console.ReadLine();
//We need to make sure user has entered a proper operator.
if (operand.ToLower() == "quit")
{
break;
}
else if (!((operand == "+") || (operand == "-") || (operand == "*") || (operand == "/")))
{
Console.WriteLine("Invalid input. Please enter one of the following: +, - , *, /.");
goto Second;
}
else
{
// No problem. Keep going.
}
Console.WriteLine("Please enter the second number:");
Third:
secondInput = Console.ReadLine();
try
{
if (secondInput.ToLower() != "quit")
{
y = double.Parse(secondInput);
}
else
{
break;
}
}
catch
{
// If we are here, that means erroneous input was given.
Console.WriteLine("Invalid input. Please enter an integer.");
goto Third;
}
// We have all we need if program has run up until this line.
// We can now check which operand is entered to determine the result.
if (operand == "+")
{
Console.WriteLine($"{firstInput} + {secondInput} = {x + y}");
}
else if (operand == "-")
{
Console.WriteLine($"{firstInput} - {secondInput} = {x - y}");
}
else if (operand == "*")
{
Console.WriteLine($"{firstInput} * {secondInput} = {x * y}");
}
else if (operand == "/")
{
Console.WriteLine($"{firstInput} / {secondInput} = {x / y}");
}
else
{
Console.WriteLine("Error! You must have entered invalid input.");
}
Console.WriteLine("Press any key to throw me away like a Kleenex.");
Console.ReadKey();
break;
}
}
}
}
Couple things I've attempted/found out so far:
Instead of checking whether "quit" has been entered every time, I
tried to use following with no success:while (!((firstInput.ToLower() == "quit") || (secondInput.ToLower() == "quit") || (operand.ToLower() == "quit")))Apparently C# has "String Interpolation" too, like in JS (I guess with ES6) which was considered as a good practice among my colleagues if nothing else, for readability.
I know usage of "goto" is not considered well usually. Though it seemed quite practical with the labels. Priorly, I had thought it was only used in switch cases.
About exception handling, I haven't had much use before when I messed around in Java, but I suppose it's one of the most fundamental features of higher level languages to keep program more prune to run-time errors. This one particularly came to my head when I realized user could potentially enter some input that can't be parsed properly.
I don't know, there's not much to do given that problem and implementation is quite simple, but I still think it's a good opportunity to develop good practices if I were to somewhat get involved with gaming development, for example (Unity etc.).
I've been recently coding Haskell, Python, JavaScript and I have C/C++ background but this is the first time I laid my hands on an .NET/C# app.
I have tinkered with Java before, but I don't really have much experience with higher level languages. Anyways, long story short, I'd like to see what could have been done better and what are the things that are considered as good/bad practice that could be particularly viewed in this small code snippet.
P.S: I'm a bit aware that comments are a bit overly-done, but it's intentional for obvious reasons. Thanks in advance.
c# beginner .net
c# beginner .net
asked 1 hour ago
BonelliaBonellia
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
BonelliaBonellia
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
BonelliaBonellia
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
BonelliaBonellia
62
asked 1 hour ago
BonelliaBonellia
62
62
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Bonellia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Bonellia is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216691%2fan-arithmetic-operation-app-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Bonellia is a new contributor. Be nice, and check out our Code of Conduct.
Bonellia is a new contributor. Be nice, and check out our Code of Conduct.
Bonellia is a new contributor. Be nice, and check out our Code of Conduct.
Bonellia is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216691%2fan-arithmetic-operation-app-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
