Usage of R-value reference
$begingroup$
I had submitted below code for review.
//centerX, centerY, xradius, yradius is some float value
for (int i = 0; i < num_segment; i++)
{
float theta = i * M_PI / 90; ====> got an code review here
x = centerX + (xradius * cos(theta));
y = centerY + (yradius * sin(theta));
....
}
Code review comment :
Did you consider an rvalue reference here like "const float theta&& =
..."
I said cos and sin from math.h is not taking rValue reference, so I don't see any need for using rvalue reference here.
Is my response correct? or do we need to use rValue reference here?
c++ c++11
asked 9 mins ago
samnactionsamnaction
1585
$endgroup$
add a comment |
$begingroup$
I had submitted below code for review.
//centerX, centerY, xradius, yradius is some float value
for (int i = 0; i < num_segment; i++)
{
float theta = i * M_PI / 90; ====> got an code review here
x = centerX + (xradius * cos(theta));
y = centerY + (yradius * sin(theta));
....
}
Code review comment :
Did you consider an rvalue reference here like "const float theta&& =
..."
I said cos and sin from math.h is not taking rValue reference, so I don't see any need for using rvalue reference here.
Is my response correct? or do we need to use rValue reference here?
c++ c++11
asked 9 mins ago
samnactionsamnaction
1585
$endgroup$
add a comment |
$begingroup$
I had submitted below code for review.
//centerX, centerY, xradius, yradius is some float value
for (int i = 0; i < num_segment; i++)
{
float theta = i * M_PI / 90; ====> got an code review here
x = centerX + (xradius * cos(theta));
y = centerY + (yradius * sin(theta));
....
}
Code review comment :
Did you consider an rvalue reference here like "const float theta&& =
..."
I said cos and sin from math.h is not taking rValue reference, so I don't see any need for using rvalue reference here.
Is my response correct? or do we need to use rValue reference here?
c++ c++11
asked 9 mins ago
samnactionsamnaction
1585
$endgroup$
I had submitted below code for review.
//centerX, centerY, xradius, yradius is some float value
for (int i = 0; i < num_segment; i++)
{
float theta = i * M_PI / 90; ====> got an code review here
x = centerX + (xradius * cos(theta));
y = centerY + (yradius * sin(theta));
....
}
Code review comment :
Did you consider an rvalue reference here like "const float theta&& =
..."
I said cos and sin from math.h is not taking rValue reference, so I don't see any need for using rvalue reference here.
Is my response correct? or do we need to use rValue reference here?
c++ c++11
c++ c++11
asked 9 mins ago
samnactionsamnaction
1585
asked 9 mins ago
samnactionsamnaction
1585
asked 9 mins ago
samnactionsamnaction
1585
asked 9 mins ago
samnactionsamnaction
1585
asked 9 mins ago
samnactionsamnaction
1585
1585
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215398%2fusage-of-r-value-reference%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215398%2fusage-of-r-value-reference%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
