Gfrktyl

My Project is structured as follows
All in blue circles are class library

Project Domain
Project domain contains POCO class as well as their relationship .in our case we have Product and ProductCategory

using System;

using System.Collections.Generic;

using System.Text;



namespace DOMAIN

{

    public class Product

    {

        public int ProductID { get; set; }

        public int ProductCategoryID { get; set; }

        public string ProductName { get; set; }



        public ProductCategory ProductCategory { get; set; }

    }

}

And Product Category

using System;

using System.Collections.Generic;

using System.Text;



namespace DOMAIN

{

    public class ProductCategory

    {

        public int ProductCategoryID { get; set; }

        public string Name { get; set; }



        List<Product> Products { get; set; }

    }

}

2 : Repository Has Repository for each Table in our case Product will have ProductRepository and ProductCategory will have ProductCategoryRepository

BaseRepository will contain wrapper methods for db access in our case l am using Dapper

Product Repository example :

using System;

using System.Collections.Generic;

using System.Linq;

using System.Text;

using Dapper;

using DOMAIN;



namespace REPOSITORY

{

    public class ProductRepository : BaseRepository

    {

        public List<Product> GetListProduct()

        {

            using (var db = CreateConnection())

            {

                return db.Query<Product, ProductCategory, Product>(@"SELECT TOP (1000) pro.* , proCat.*

                                                    FROM[DbDapper].[dbo].[Product] As pro

                                                     inner join ProductCategory As proCat on pro.ProductCategoryID = proCat.ProductCategoryID" ,

                                                     (p, c) => { p.ProductCategory = c; return p; } 

                                            ,  splitOn: "ProductCategoryID")   

                                            .AsList(); 

            }

        }

        public Product GetProduct(int productID)

        {

            using (var db = CreateConnection())

            {

                var sql = @"SELECT TOP 1 pro.* , proCat.*

                                                    FROM[DbDapper].[dbo].[Product] As pro

                                                     inner join ProductCategory As proCat on pro.ProductCategoryID = proCat.ProductCategoryID

                                                        where pro.ProductID = @productID ";

               return  db.Query<Product , ProductCategory , Product>(sql  ,

                                            (p, c) => { p.ProductCategory = c; return p; },

                                            new { productID = productID }

                                            ,  splitOn: "ProductCategoryID")   

                                            .FirstOrDefault();



            }

        }

    }

}

the Unit of Work Repository UnitofWorkRepository.cs will have all the repository its sort of a manager for all the repository as shown below

using System;

using System.Collections.Generic;

using System.Text;



namespace REPOSITORY

{

    public class UnitOfWorkRepository

    {

        private ProductRepository _productRepository { get; set; }

        private ProductCategoryRepository _productCategoryRepository { get; set; }



        public UnitOfWorkRepository()

        {

            Initialize();

        }



        private void Initialize()

        {

            _productCategoryRepository = _productCategoryRepository ?? new ProductCategoryRepository();

            _productRepository = _productRepository ?? new ProductRepository();

        } 



        public ProductCategoryRepository ProductCategoryRepository { get { return this._productCategoryRepository; } }

        public ProductRepository ProductRepository { get { return this._productRepository; } }

    }

}

The Service layer will have its service but however it will have 2 constructor properties which are the object of the current user logged in the system and an instance of the Repository. the user object will be passed like if it is asp mvc l will pass the object of the Logged to the service layer as well as if am on an api will have a session of the logged user as an object in our case UserSession under project > Domain > Session .

l also do my validation in the service layer

sample of product service layer

    using DOMAIN;

using DOMAIN.Session;

using REPOSITORY;

using System;

using System.Collections.Generic;

using System.Text;



namespace SERVICE

{

    public class ProductService

    {

        private UserSession _userSession;

        private UnitOfWorkRepository _dbRepository;



        public ProductService(UserSession userSession , UnitOfWorkRepository dbRepository)

        {

            _userSession = userSession;

            _dbRepository = dbRepository;

        }



        public List<Product> GetListProducts()

        {

            return _dbRepository.ProductRepository.GetListProduct();

        }



        public Product GetProduct(int productID)

        {

            return _dbRepository.ProductRepository.GetProduct(productID);

        }





        public void SaveProduct(Product product)

        { 



            if( _userSession.roleID != 1)

            {

                // user is not priviledged to add

                return ;

            }

            //  continue saving

            //

        }

    }

}

like when saving method l have to check user priviledges etc.

l need review on the Following :

DOMAIN
1: Is it right to have the sessions domain there or am total wrong something else must be done .

REPOSITORY
2: Having all the class repository in one class UnitOfWork saves me time when l what to check something form another repository in a service layer rather than passing many constructors in a repository for example l simple do

_dbRepository.<RepositoryName>.<MethodName>.<Parameter>



            //for example 

            _dbRepository.ProductRepository.GetListProduct();

rather than doing something like

  ProductService (UserSession userSession , ProductRepository productRepository , ProductCategoryRepository , N++ Repository)

Service
3: On the Serivces
is it right to pass the logged user object

4: is it also ok to have all the service in one class like l did for repository is there an perfomance issues , something like

_allService.<serviceNme>.<serviceMethod><paramter>

Edit 2:
My asp mvc project will look like below :

using REPOSITORY;

using System;

using System.Collections.Generic;

using System.Linq;

using System.Web;

using System.Web.Mvc;

using DOMAIN.Session;

using SERVICE;





namespace WEB.Controllers

{

    public class ProductController : Controller

    {

        UserSession _user ;



        // this is out db repositories

        UnitOfWorkRepository _unitOfWork;



        // this is out service

        ProductService _productService;





        public ProductController()

        {

            _user = (UserSession)System.Web.HttpContext.Current.Session["loggedUser"];

            _unitOfWork = new UnitOfWorkRepository();

            _productService = new ProductService(_user, _unitOfWork);

        }

        // GET: Product

        public ActionResult Index()

        {

            var productList = _productService.GetListProducts();



            return View(productList);

        }

    }

}

Edit 3 : i have updated image including the web of how l reference the service layer .