LinkedHashSet Implementation
up vote
0
down vote
favorite
There's an implementation of LinkedHashSet in Java. Although this is limited with its functionality, it will do the basic job.
I used interfaces so then I can use that interface for BST.
Set interface :
package interfaces.set;
public interface Set<E> extends Iterable<E>
{
int size();
boolean isEmpty();
boolean add(E e);
boolean remove(E e);
boolean contains(E e);
E get(E e);
}
LinkedHashSet class :
package set;
import interfaces.set.Set;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
public class LinkedHashSet<E> implements Set<E>
{
private int size;
private int capacity;
private List<E> buckets;
public LinkedHashSet()
{
this(500);
}
public LinkedHashSet(int capacity)
{
size = 0;
this.capacity = capacity;
buckets = (LinkedList<E>) new LinkedList[this.capacity];
}
@Override
public int size()
{
return size;
}
@Override
public boolean isEmpty()
{
return size() == 0;
}
@Override
public boolean add(E e)
{
int i = e.hashCode() % capacity;
if (buckets[i] == null) buckets[i] = new LinkedList <>();
for (int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return false;
buckets[i].add(e);
size++;
return true;
}
@Override
public boolean remove(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++)
{
if(e.equals(buckets[i].get(j)))
{
buckets[i].remove(e);
return true;
}
}
}
return false;
}
@Override
public boolean contains(E e)
{
return get(e) != null;
}
@Override
public E get(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return buckets[i].get(j);
}
return null;
}
@Override
public Iterator<E> iterator()
{
List<E> content = new LinkedList <>();
for (int i = 0; i < capacity; i++) if (buckets[i] != null) content.addAll(buckets[i]);
return content.iterator();
}
}
java object-oriented generics interface set
edited Dec 12 at 15:45
IEatBagels
8,85323178
asked Dec 9 at 16:04
Hamidur Rahman
486
add a comment |
up vote
0
down vote
favorite
There's an implementation of LinkedHashSet in Java. Although this is limited with its functionality, it will do the basic job.
I used interfaces so then I can use that interface for BST.
Set interface :
package interfaces.set;
public interface Set<E> extends Iterable<E>
{
int size();
boolean isEmpty();
boolean add(E e);
boolean remove(E e);
boolean contains(E e);
E get(E e);
}
LinkedHashSet class :
package set;
import interfaces.set.Set;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
public class LinkedHashSet<E> implements Set<E>
{
private int size;
private int capacity;
private List<E> buckets;
public LinkedHashSet()
{
this(500);
}
public LinkedHashSet(int capacity)
{
size = 0;
this.capacity = capacity;
buckets = (LinkedList<E>) new LinkedList[this.capacity];
}
@Override
public int size()
{
return size;
}
@Override
public boolean isEmpty()
{
return size() == 0;
}
@Override
public boolean add(E e)
{
int i = e.hashCode() % capacity;
if (buckets[i] == null) buckets[i] = new LinkedList <>();
for (int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return false;
buckets[i].add(e);
size++;
return true;
}
@Override
public boolean remove(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++)
{
if(e.equals(buckets[i].get(j)))
{
buckets[i].remove(e);
return true;
}
}
}
return false;
}
@Override
public boolean contains(E e)
{
return get(e) != null;
}
@Override
public E get(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return buckets[i].get(j);
}
return null;
}
@Override
public Iterator<E> iterator()
{
List<E> content = new LinkedList <>();
for (int i = 0; i < capacity; i++) if (buckets[i] != null) content.addAll(buckets[i]);
return content.iterator();
}
}
java object-oriented generics interface set
edited Dec 12 at 15:45
IEatBagels
8,85323178
asked Dec 9 at 16:04
Hamidur Rahman
486
There's a floating return null in your code.
– Pimgd
Dec 12 at 14:42
1
I would introduceprivate E Get(E e, int index)orprivate boolean Get(E e, int index)which searches given element in a particular bucket. After that you may remove theforloops inremove(E e)andadd(E e).
– sardok
Dec 12 at 15:42
1
I do not know if this is the pasting to SO but there is some issue with your code style. I suggest you having a look at google.github.io/styleguide/javaguide.html Please bear in mind that this is just about convention and not the proposed implementation.
– MadJlzz
Dec 12 at 15:53
@Pimgd mind sharing where exactly null gets returned
– Hamidur Rahman
Dec 13 at 15:26
IEatBagels fixed your code
– Pimgd
2 days ago
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
There's an implementation of LinkedHashSet in Java. Although this is limited with its functionality, it will do the basic job.
I used interfaces so then I can use that interface for BST.
Set interface :
package interfaces.set;
public interface Set<E> extends Iterable<E>
{
int size();
boolean isEmpty();
boolean add(E e);
boolean remove(E e);
boolean contains(E e);
E get(E e);
}
LinkedHashSet class :
package set;
import interfaces.set.Set;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
public class LinkedHashSet<E> implements Set<E>
{
private int size;
private int capacity;
private List<E> buckets;
public LinkedHashSet()
{
this(500);
}
public LinkedHashSet(int capacity)
{
size = 0;
this.capacity = capacity;
buckets = (LinkedList<E>) new LinkedList[this.capacity];
}
@Override
public int size()
{
return size;
}
@Override
public boolean isEmpty()
{
return size() == 0;
}
@Override
public boolean add(E e)
{
int i = e.hashCode() % capacity;
if (buckets[i] == null) buckets[i] = new LinkedList <>();
for (int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return false;
buckets[i].add(e);
size++;
return true;
}
@Override
public boolean remove(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++)
{
if(e.equals(buckets[i].get(j)))
{
buckets[i].remove(e);
return true;
}
}
}
return false;
}
@Override
public boolean contains(E e)
{
return get(e) != null;
}
@Override
public E get(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return buckets[i].get(j);
}
return null;
}
@Override
public Iterator<E> iterator()
{
List<E> content = new LinkedList <>();
for (int i = 0; i < capacity; i++) if (buckets[i] != null) content.addAll(buckets[i]);
return content.iterator();
}
}
java object-oriented generics interface set
edited Dec 12 at 15:45
IEatBagels
8,85323178
asked Dec 9 at 16:04
Hamidur Rahman
486
There's an implementation of LinkedHashSet in Java. Although this is limited with its functionality, it will do the basic job.
I used interfaces so then I can use that interface for BST.
Set interface :
package interfaces.set;
public interface Set<E> extends Iterable<E>
{
int size();
boolean isEmpty();
boolean add(E e);
boolean remove(E e);
boolean contains(E e);
E get(E e);
}
LinkedHashSet class :
package set;
import interfaces.set.Set;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
public class LinkedHashSet<E> implements Set<E>
{
private int size;
private int capacity;
private List<E> buckets;
public LinkedHashSet()
{
this(500);
}
public LinkedHashSet(int capacity)
{
size = 0;
this.capacity = capacity;
buckets = (LinkedList<E>) new LinkedList[this.capacity];
}
@Override
public int size()
{
return size;
}
@Override
public boolean isEmpty()
{
return size() == 0;
}
@Override
public boolean add(E e)
{
int i = e.hashCode() % capacity;
if (buckets[i] == null) buckets[i] = new LinkedList <>();
for (int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return false;
buckets[i].add(e);
size++;
return true;
}
@Override
public boolean remove(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++)
{
if(e.equals(buckets[i].get(j)))
{
buckets[i].remove(e);
return true;
}
}
}
return false;
}
@Override
public boolean contains(E e)
{
return get(e) != null;
}
@Override
public E get(E e)
{
int i = e.hashCode() % capacity;
if(buckets[i] != null)
{
for(int j = 0; j < buckets[i].size(); j++) if(e.equals(buckets[i].get(j))) return buckets[i].get(j);
}
return null;
}
@Override
public Iterator<E> iterator()
{
List<E> content = new LinkedList <>();
for (int i = 0; i < capacity; i++) if (buckets[i] != null) content.addAll(buckets[i]);
return content.iterator();
}
}
java object-oriented generics interface set
java object-oriented generics interface set
edited Dec 12 at 15:45
IEatBagels
8,85323178
asked Dec 9 at 16:04
Hamidur Rahman
486
edited Dec 12 at 15:45
IEatBagels
8,85323178
asked Dec 9 at 16:04
Hamidur Rahman
486
edited Dec 12 at 15:45
IEatBagels
8,85323178
edited Dec 12 at 15:45
IEatBagels
8,85323178
edited Dec 12 at 15:45
IEatBagels
8,85323178
8,85323178
asked Dec 9 at 16:04
Hamidur Rahman
486
asked Dec 9 at 16:04
Hamidur Rahman
486
asked Dec 9 at 16:04
Hamidur Rahman
486
486
There's a floating return null in your code.
– Pimgd
Dec 12 at 14:42
1
I would introduceprivate E Get(E e, int index)orprivate boolean Get(E e, int index)which searches given element in a particular bucket. After that you may remove theforloops inremove(E e)andadd(E e).
– sardok
Dec 12 at 15:42
1
I do not know if this is the pasting to SO but there is some issue with your code style. I suggest you having a look at google.github.io/styleguide/javaguide.html Please bear in mind that this is just about convention and not the proposed implementation.
– MadJlzz
Dec 12 at 15:53
@Pimgd mind sharing where exactly null gets returned
– Hamidur Rahman
Dec 13 at 15:26
IEatBagels fixed your code
– Pimgd
2 days ago
add a comment |
There's a floating return null in your code.
– Pimgd
Dec 12 at 14:42
1
I would introduceprivate E Get(E e, int index)orprivate boolean Get(E e, int index)which searches given element in a particular bucket. After that you may remove theforloops inremove(E e)andadd(E e).
– sardok
Dec 12 at 15:42
1
I do not know if this is the pasting to SO but there is some issue with your code style. I suggest you having a look at google.github.io/styleguide/javaguide.html Please bear in mind that this is just about convention and not the proposed implementation.
– MadJlzz
Dec 12 at 15:53
@Pimgd mind sharing where exactly null gets returned
– Hamidur Rahman
Dec 13 at 15:26
IEatBagels fixed your code
– Pimgd
2 days ago
There's a floating return null in your code.
– Pimgd
Dec 12 at 14:42
There's a floating return null in your code.
– Pimgd
Dec 12 at 14:42
1
1
I would introduce
private E Get(E e, int index) or private boolean Get(E e, int index) which searches given element in a particular bucket. After that you may remove the for loops in remove(E e) and add(E e).– sardok
Dec 12 at 15:42
I would introduce
private E Get(E e, int index) or private boolean Get(E e, int index) which searches given element in a particular bucket. After that you may remove the for loops in remove(E e) and add(E e).– sardok
Dec 12 at 15:42
1
1
I do not know if this is the pasting to SO but there is some issue with your code style. I suggest you having a look at google.github.io/styleguide/javaguide.html Please bear in mind that this is just about convention and not the proposed implementation.
– MadJlzz
Dec 12 at 15:53
I do not know if this is the pasting to SO but there is some issue with your code style. I suggest you having a look at google.github.io/styleguide/javaguide.html Please bear in mind that this is just about convention and not the proposed implementation.
– MadJlzz
Dec 12 at 15:53
@Pimgd mind sharing where exactly null gets returned
– Hamidur Rahman
Dec 13 at 15:26
@Pimgd mind sharing where exactly null gets returned
– Hamidur Rahman
Dec 13 at 15:26
IEatBagels fixed your code
– Pimgd
2 days ago
IEatBagels fixed your code
– Pimgd
2 days ago
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209319%2flinkedhashset-implementation%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209319%2flinkedhashset-implementation%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
There's a floating return null in your code.
– Pimgd
Dec 12 at 14:42
1
I would introduce
private E Get(E e, int index)orprivate boolean Get(E e, int index)which searches given element in a particular bucket. After that you may remove theforloops inremove(E e)andadd(E e).– sardok
Dec 12 at 15:42
1
I do not know if this is the pasting to SO but there is some issue with your code style. I suggest you having a look at google.github.io/styleguide/javaguide.html Please bear in mind that this is just about convention and not the proposed implementation.
– MadJlzz
Dec 12 at 15:53
@Pimgd mind sharing where exactly null gets returned
– Hamidur Rahman
Dec 13 at 15:26
IEatBagels fixed your code
– Pimgd
2 days ago