Optimize Groovy Script to get average price per group from different data arrays
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
1
$begingroup$
I've been trying to learn Groovy lately and I tried to solve a problem which involves designing a routine that will calculate the average Product price per Group.
I have the following data:
// contains information about [Product, Group, Cost]
products = [
["A", "G1", 20.1],
["B", "G2", 98.4],
["C", "G1", 49.7],
["D", "G3", 35.8],
["E", "G3", 105.5],
["F", "G1", 55.2],
["G", "G1", 12.7],
["H", "G3", 88.6],
["I", "G1", 5.2],
["J", "G2", 72.4]
]
// contains information about Category classification based on product Cost
// [Category, Cost range from (inclusive), Cost range to (exclusive)]
// i.e. if a Product has Cost between 0 and 25, it belongs to category C1
category = [
["C3", 50, 75],
["C4", 75, 100],
["C2", 25, 50],
["C5", 100, null],
["C1", 0, 25]
]
// contains information about margins for each product Category
// [Category, Margin (either percentage or absolute value)]
margins = [
"C1" : "20%",
"C2" : "30%",
"C3" : "0.4",
"C4" : "50%",
"C5" : "0.6"]
What I tried so far is the following (I mixed some Java here):
def calculateResult() {
def group1 =
def group2 =
def group3 =
def pricePerGroupMap = [:]
category.each { cat ->
String catDesc = cat[0]
BigDecimal min = cat[1]
BigDecimal max = cat[2]
if (max == null) {
max = 9999.9;
}
products.each { product ->
BigDecimal currProductPrice = BigDecimal.valueOf(product[2])
if (currProductPrice.compareTo(min) >= 0 && currProductPrice.compareTo(max) <= 0) {
String selectedMarginAsString = margins.getAt(catDesc);
BigDecimal selMargin = 0.0;
if (selectedMarginAsString.endsWith("%")) {
selMargin = new BigDecimal(selectedMarginAsString.trim().replace("%", "")).divide(BigDecimal.valueOf(100));
} else {
selMargin = new BigDecimal(selectedMarginAsString);
}
if (product[1].equals("G1")) {
group1.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G2")) {
group2.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G3")) {
group3.add(product[2] * (1 + selMargin))
}
}
}
}
pricePerGroupMap["G1"] = group1.sum() / group1.size()
pricePerGroupMap["G2"] = group2.sum()/ group2.size()
pricePerGroupMap["G3"] = group3.sum()/ group3.size()
print pricePerGroupMap
}
I am sure there are better ways to optimize this algorithm taking advantage of closures.
I appreciate any feedback that you can provide. Thanks in advance.
java array groovy closure
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
$endgroup$
add a comment |
1
$begingroup$
I've been trying to learn Groovy lately and I tried to solve a problem which involves designing a routine that will calculate the average Product price per Group.
I have the following data:
// contains information about [Product, Group, Cost]
products = [
["A", "G1", 20.1],
["B", "G2", 98.4],
["C", "G1", 49.7],
["D", "G3", 35.8],
["E", "G3", 105.5],
["F", "G1", 55.2],
["G", "G1", 12.7],
["H", "G3", 88.6],
["I", "G1", 5.2],
["J", "G2", 72.4]
]
// contains information about Category classification based on product Cost
// [Category, Cost range from (inclusive), Cost range to (exclusive)]
// i.e. if a Product has Cost between 0 and 25, it belongs to category C1
category = [
["C3", 50, 75],
["C4", 75, 100],
["C2", 25, 50],
["C5", 100, null],
["C1", 0, 25]
]
// contains information about margins for each product Category
// [Category, Margin (either percentage or absolute value)]
margins = [
"C1" : "20%",
"C2" : "30%",
"C3" : "0.4",
"C4" : "50%",
"C5" : "0.6"]
What I tried so far is the following (I mixed some Java here):
def calculateResult() {
def group1 =
def group2 =
def group3 =
def pricePerGroupMap = [:]
category.each { cat ->
String catDesc = cat[0]
BigDecimal min = cat[1]
BigDecimal max = cat[2]
if (max == null) {
max = 9999.9;
}
products.each { product ->
BigDecimal currProductPrice = BigDecimal.valueOf(product[2])
if (currProductPrice.compareTo(min) >= 0 && currProductPrice.compareTo(max) <= 0) {
String selectedMarginAsString = margins.getAt(catDesc);
BigDecimal selMargin = 0.0;
if (selectedMarginAsString.endsWith("%")) {
selMargin = new BigDecimal(selectedMarginAsString.trim().replace("%", "")).divide(BigDecimal.valueOf(100));
} else {
selMargin = new BigDecimal(selectedMarginAsString);
}
if (product[1].equals("G1")) {
group1.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G2")) {
group2.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G3")) {
group3.add(product[2] * (1 + selMargin))
}
}
}
}
pricePerGroupMap["G1"] = group1.sum() / group1.size()
pricePerGroupMap["G2"] = group2.sum()/ group2.size()
pricePerGroupMap["G3"] = group3.sum()/ group3.size()
print pricePerGroupMap
}
I am sure there are better ways to optimize this algorithm taking advantage of closures.
I appreciate any feedback that you can provide. Thanks in advance.
java array groovy closure
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
$endgroup$
add a comment |
1
1
1
$begingroup$
I've been trying to learn Groovy lately and I tried to solve a problem which involves designing a routine that will calculate the average Product price per Group.
I have the following data:
// contains information about [Product, Group, Cost]
products = [
["A", "G1", 20.1],
["B", "G2", 98.4],
["C", "G1", 49.7],
["D", "G3", 35.8],
["E", "G3", 105.5],
["F", "G1", 55.2],
["G", "G1", 12.7],
["H", "G3", 88.6],
["I", "G1", 5.2],
["J", "G2", 72.4]
]
// contains information about Category classification based on product Cost
// [Category, Cost range from (inclusive), Cost range to (exclusive)]
// i.e. if a Product has Cost between 0 and 25, it belongs to category C1
category = [
["C3", 50, 75],
["C4", 75, 100],
["C2", 25, 50],
["C5", 100, null],
["C1", 0, 25]
]
// contains information about margins for each product Category
// [Category, Margin (either percentage or absolute value)]
margins = [
"C1" : "20%",
"C2" : "30%",
"C3" : "0.4",
"C4" : "50%",
"C5" : "0.6"]
What I tried so far is the following (I mixed some Java here):
def calculateResult() {
def group1 =
def group2 =
def group3 =
def pricePerGroupMap = [:]
category.each { cat ->
String catDesc = cat[0]
BigDecimal min = cat[1]
BigDecimal max = cat[2]
if (max == null) {
max = 9999.9;
}
products.each { product ->
BigDecimal currProductPrice = BigDecimal.valueOf(product[2])
if (currProductPrice.compareTo(min) >= 0 && currProductPrice.compareTo(max) <= 0) {
String selectedMarginAsString = margins.getAt(catDesc);
BigDecimal selMargin = 0.0;
if (selectedMarginAsString.endsWith("%")) {
selMargin = new BigDecimal(selectedMarginAsString.trim().replace("%", "")).divide(BigDecimal.valueOf(100));
} else {
selMargin = new BigDecimal(selectedMarginAsString);
}
if (product[1].equals("G1")) {
group1.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G2")) {
group2.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G3")) {
group3.add(product[2] * (1 + selMargin))
}
}
}
}
pricePerGroupMap["G1"] = group1.sum() / group1.size()
pricePerGroupMap["G2"] = group2.sum()/ group2.size()
pricePerGroupMap["G3"] = group3.sum()/ group3.size()
print pricePerGroupMap
}
I am sure there are better ways to optimize this algorithm taking advantage of closures.
I appreciate any feedback that you can provide. Thanks in advance.
java array groovy closure
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
$endgroup$
I've been trying to learn Groovy lately and I tried to solve a problem which involves designing a routine that will calculate the average Product price per Group.
I have the following data:
// contains information about [Product, Group, Cost]
products = [
["A", "G1", 20.1],
["B", "G2", 98.4],
["C", "G1", 49.7],
["D", "G3", 35.8],
["E", "G3", 105.5],
["F", "G1", 55.2],
["G", "G1", 12.7],
["H", "G3", 88.6],
["I", "G1", 5.2],
["J", "G2", 72.4]
]
// contains information about Category classification based on product Cost
// [Category, Cost range from (inclusive), Cost range to (exclusive)]
// i.e. if a Product has Cost between 0 and 25, it belongs to category C1
category = [
["C3", 50, 75],
["C4", 75, 100],
["C2", 25, 50],
["C5", 100, null],
["C1", 0, 25]
]
// contains information about margins for each product Category
// [Category, Margin (either percentage or absolute value)]
margins = [
"C1" : "20%",
"C2" : "30%",
"C3" : "0.4",
"C4" : "50%",
"C5" : "0.6"]
What I tried so far is the following (I mixed some Java here):
def calculateResult() {
def group1 =
def group2 =
def group3 =
def pricePerGroupMap = [:]
category.each { cat ->
String catDesc = cat[0]
BigDecimal min = cat[1]
BigDecimal max = cat[2]
if (max == null) {
max = 9999.9;
}
products.each { product ->
BigDecimal currProductPrice = BigDecimal.valueOf(product[2])
if (currProductPrice.compareTo(min) >= 0 && currProductPrice.compareTo(max) <= 0) {
String selectedMarginAsString = margins.getAt(catDesc);
BigDecimal selMargin = 0.0;
if (selectedMarginAsString.endsWith("%")) {
selMargin = new BigDecimal(selectedMarginAsString.trim().replace("%", "")).divide(BigDecimal.valueOf(100));
} else {
selMargin = new BigDecimal(selectedMarginAsString);
}
if (product[1].equals("G1")) {
group1.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G2")) {
group2.add(product[2] * (1 + selMargin))
} else if (product[1].equals("G3")) {
group3.add(product[2] * (1 + selMargin))
}
}
}
}
pricePerGroupMap["G1"] = group1.sum() / group1.size()
pricePerGroupMap["G2"] = group2.sum()/ group2.size()
pricePerGroupMap["G3"] = group3.sum()/ group3.size()
print pricePerGroupMap
}
I am sure there are better ways to optimize this algorithm taking advantage of closures.
I appreciate any feedback that you can provide. Thanks in advance.
java array groovy closure
java array groovy closure
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
asked 3 hours ago
Marcelo TatajeMarcelo Tataje
1184
1184
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217108%2foptimize-groovy-script-to-get-average-price-per-group-from-different-data-arrays%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217108%2foptimize-groovy-script-to-get-average-price-per-group-from-different-data-arrays%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
