Convert human readable string to TimeSpan
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
2
$begingroup$
I want to pass time interval as a string (to program args) and then I want to parse it to TimeSpan. I created simple class:
public static class TimeSpanConverter
{
public static TimeSpan Convert(string input)
{
var units = new Dictionary<string, int>()
{
{@"(d+)(ms|mili[|s]|milisecon[|s])", 1 },
{@"(d+)(s|sec|second[|s])", 1000 },
{@"(d+)(m|min[|s])", 60000 },
{@"(d+)(h|hour[|s])", 3600000 },
{@"(d+)(d|day[|s])", 86400000 },
{@"(d+)(w|week[|s])", 604800000 },
};
var timespan = new TimeSpan();
foreach(var x in units)
{
var matches = Regex.Matches(input, x.Key);
foreach(Match match in matches)
{
var amount = System.Convert.ToInt32(match.Groups[1].Value);
timespan = timespan.Add(TimeSpan.FromMilliseconds(x.Value * amount));
}
}
return timespan;
}
}
Which is working, and I can easly parse like this:
var interval = TimeSpanConverter.Convert("1day13hour2min12s52ms");
What do you think about that? How can I improve that? I have a feeling, that it is not well coded.
c# regex
asked 6 hours ago
dafiedafie
313
$endgroup$
add a comment |
2
$begingroup$
I want to pass time interval as a string (to program args) and then I want to parse it to TimeSpan. I created simple class:
public static class TimeSpanConverter
{
public static TimeSpan Convert(string input)
{
var units = new Dictionary<string, int>()
{
{@"(d+)(ms|mili[|s]|milisecon[|s])", 1 },
{@"(d+)(s|sec|second[|s])", 1000 },
{@"(d+)(m|min[|s])", 60000 },
{@"(d+)(h|hour[|s])", 3600000 },
{@"(d+)(d|day[|s])", 86400000 },
{@"(d+)(w|week[|s])", 604800000 },
};
var timespan = new TimeSpan();
foreach(var x in units)
{
var matches = Regex.Matches(input, x.Key);
foreach(Match match in matches)
{
var amount = System.Convert.ToInt32(match.Groups[1].Value);
timespan = timespan.Add(TimeSpan.FromMilliseconds(x.Value * amount));
}
}
return timespan;
}
}
Which is working, and I can easly parse like this:
var interval = TimeSpanConverter.Convert("1day13hour2min12s52ms");
What do you think about that? How can I improve that? I have a feeling, that it is not well coded.
c# regex
asked 6 hours ago
dafiedafie
313
$endgroup$
add a comment |
2
2
2
$begingroup$
I want to pass time interval as a string (to program args) and then I want to parse it to TimeSpan. I created simple class:
public static class TimeSpanConverter
{
public static TimeSpan Convert(string input)
{
var units = new Dictionary<string, int>()
{
{@"(d+)(ms|mili[|s]|milisecon[|s])", 1 },
{@"(d+)(s|sec|second[|s])", 1000 },
{@"(d+)(m|min[|s])", 60000 },
{@"(d+)(h|hour[|s])", 3600000 },
{@"(d+)(d|day[|s])", 86400000 },
{@"(d+)(w|week[|s])", 604800000 },
};
var timespan = new TimeSpan();
foreach(var x in units)
{
var matches = Regex.Matches(input, x.Key);
foreach(Match match in matches)
{
var amount = System.Convert.ToInt32(match.Groups[1].Value);
timespan = timespan.Add(TimeSpan.FromMilliseconds(x.Value * amount));
}
}
return timespan;
}
}
Which is working, and I can easly parse like this:
var interval = TimeSpanConverter.Convert("1day13hour2min12s52ms");
What do you think about that? How can I improve that? I have a feeling, that it is not well coded.
c# regex
asked 6 hours ago
dafiedafie
313
$endgroup$
I want to pass time interval as a string (to program args) and then I want to parse it to TimeSpan. I created simple class:
public static class TimeSpanConverter
{
public static TimeSpan Convert(string input)
{
var units = new Dictionary<string, int>()
{
{@"(d+)(ms|mili[|s]|milisecon[|s])", 1 },
{@"(d+)(s|sec|second[|s])", 1000 },
{@"(d+)(m|min[|s])", 60000 },
{@"(d+)(h|hour[|s])", 3600000 },
{@"(d+)(d|day[|s])", 86400000 },
{@"(d+)(w|week[|s])", 604800000 },
};
var timespan = new TimeSpan();
foreach(var x in units)
{
var matches = Regex.Matches(input, x.Key);
foreach(Match match in matches)
{
var amount = System.Convert.ToInt32(match.Groups[1].Value);
timespan = timespan.Add(TimeSpan.FromMilliseconds(x.Value * amount));
}
}
return timespan;
}
}
Which is working, and I can easly parse like this:
var interval = TimeSpanConverter.Convert("1day13hour2min12s52ms");
What do you think about that? How can I improve that? I have a feeling, that it is not well coded.
c# regex
c# regex
asked 6 hours ago
dafiedafie
313
asked 6 hours ago
dafiedafie
313
asked 6 hours ago
dafiedafie
313
asked 6 hours ago
dafiedafie
313
asked 6 hours ago
dafiedafie
313
313
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217101%2fconvert-human-readable-string-to-timespan%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217101%2fconvert-human-readable-string-to-timespan%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
