Mutable Linked List in Scala












0












$begingroup$


Scala newbie here. I'm trying to implement a mutable linked list in Scala. So far, I am only supporting the add() operation. Here's my stab at it:



class MutableList[T] {

class Node[T](val value: T) {
var next: Node[T] = null
def hasNext = (next != null)
}

var first, last: Node[T] = null
var size = 0

def add(value: T) = {
val newNode = new Node[T](value)
if (first == null) {
assert(size == 0)
first = newNode
last = newNode
} else {
last.next = newNode
}
size += 1
}

override def toString = {
def getValues() = {
var current = first
for (i <- 1 to size) yield {
val valStr = current.value.toString
current = current.next
valStr
}
}
getValues().mkString(",")
}
}


I know that a mutable data structure is not the best thing to use/implement in Scala. But I'm just experimenting and was wondering if there is a more functional Scala way of writing this?










share|improve this question







New contributor




Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    Scala newbie here. I'm trying to implement a mutable linked list in Scala. So far, I am only supporting the add() operation. Here's my stab at it:



    class MutableList[T] {

    class Node[T](val value: T) {
    var next: Node[T] = null
    def hasNext = (next != null)
    }

    var first, last: Node[T] = null
    var size = 0

    def add(value: T) = {
    val newNode = new Node[T](value)
    if (first == null) {
    assert(size == 0)
    first = newNode
    last = newNode
    } else {
    last.next = newNode
    }
    size += 1
    }

    override def toString = {
    def getValues() = {
    var current = first
    for (i <- 1 to size) yield {
    val valStr = current.value.toString
    current = current.next
    valStr
    }
    }
    getValues().mkString(",")
    }
    }


    I know that a mutable data structure is not the best thing to use/implement in Scala. But I'm just experimenting and was wondering if there is a more functional Scala way of writing this?










    share|improve this question







    New contributor




    Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      Scala newbie here. I'm trying to implement a mutable linked list in Scala. So far, I am only supporting the add() operation. Here's my stab at it:



      class MutableList[T] {

      class Node[T](val value: T) {
      var next: Node[T] = null
      def hasNext = (next != null)
      }

      var first, last: Node[T] = null
      var size = 0

      def add(value: T) = {
      val newNode = new Node[T](value)
      if (first == null) {
      assert(size == 0)
      first = newNode
      last = newNode
      } else {
      last.next = newNode
      }
      size += 1
      }

      override def toString = {
      def getValues() = {
      var current = first
      for (i <- 1 to size) yield {
      val valStr = current.value.toString
      current = current.next
      valStr
      }
      }
      getValues().mkString(",")
      }
      }


      I know that a mutable data structure is not the best thing to use/implement in Scala. But I'm just experimenting and was wondering if there is a more functional Scala way of writing this?










      share|improve this question







      New contributor




      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Scala newbie here. I'm trying to implement a mutable linked list in Scala. So far, I am only supporting the add() operation. Here's my stab at it:



      class MutableList[T] {

      class Node[T](val value: T) {
      var next: Node[T] = null
      def hasNext = (next != null)
      }

      var first, last: Node[T] = null
      var size = 0

      def add(value: T) = {
      val newNode = new Node[T](value)
      if (first == null) {
      assert(size == 0)
      first = newNode
      last = newNode
      } else {
      last.next = newNode
      }
      size += 1
      }

      override def toString = {
      def getValues() = {
      var current = first
      for (i <- 1 to size) yield {
      val valStr = current.value.toString
      current = current.next
      valStr
      }
      }
      getValues().mkString(",")
      }
      }


      I know that a mutable data structure is not the best thing to use/implement in Scala. But I'm just experimenting and was wondering if there is a more functional Scala way of writing this?







      scala






      share|improve this question







      New contributor




      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 12 mins ago









      Aashish DattaniAashish Dattani

      1




      1




      New contributor




      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Aashish Dattani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Aashish Dattani is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215547%2fmutable-linked-list-in-scala%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Aashish Dattani is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Aashish Dattani is a new contributor. Be nice, and check out our Code of Conduct.













          Aashish Dattani is a new contributor. Be nice, and check out our Code of Conduct.












          Aashish Dattani is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215547%2fmutable-linked-list-in-scala%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Сан-Квентин

          8-я гвардейская общевойсковая армия

          Алькесар