Am I looking at tightly coupled code here, entity framework 6?
$begingroup$
Honestly, I have been really trying to read up and learn the best techniques for uncoupling different portions of my applications.
I have such a long way to go in regards to this and entity framework 6. I was hoping to post this small sample and get some feedback as far as tightly coupling was concerned.
Preface: this application is something I am doing as a personal practice project that relates to theme parks and rides.
So, basically we first have one of the objects that represents something I would take out of the database. This class is as follows:
public class Parks
{
public int Id { get; }
public string ParkValue{ get; set; }
public string ParkName { get; set; }
}
Simple class, with 3 properties. Now here is the data access that builds this based on an Id which comes from a different portion of the application.
public class ParkDataRetriever
{
public Parks GetSelectedPark(Parks Park, int Id)
{
using (var Db = new MyContext())
{
List<ParkList> ListOfParks = Db.ParkLists.Where(x => x.ParkId == Id).ToList();
foreach (var Parks in ListOfParks)
{
Parks.ParkId = Park.Id;
Parks.ParkName = Park.ParkName;
Parks.DomValue = Park.DomValue;
}
return Park;
}
}
}
Please look past the fact that the loop is somewhat pointless as we only return one ride, since it is not possible for this identity field to be duplicated. So that can be ignored right now.
So then in the application, we now have a type of class Parks that we can now use in the application. So I have two questions, is this an example of decoupled code from the data access perspective? So basically any of the data access I do, looks a lot like that GetSelectedXxxxx, not always filtering with Id, but similar anyway. Now granted, I'll never change the data storage of this small project, the project will never need to scale, and it will never need to be over engineered for what it is. The point is more educational. So I would want to treat this project as if it was large, enterprise scale, for the sake of the study.
Thanks guys!
c# entity-framework
asked 40 mins ago
CMRCMR
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Honestly, I have been really trying to read up and learn the best techniques for uncoupling different portions of my applications.
I have such a long way to go in regards to this and entity framework 6. I was hoping to post this small sample and get some feedback as far as tightly coupling was concerned.
Preface: this application is something I am doing as a personal practice project that relates to theme parks and rides.
So, basically we first have one of the objects that represents something I would take out of the database. This class is as follows:
public class Parks
{
public int Id { get; }
public string ParkValue{ get; set; }
public string ParkName { get; set; }
}
Simple class, with 3 properties. Now here is the data access that builds this based on an Id which comes from a different portion of the application.
public class ParkDataRetriever
{
public Parks GetSelectedPark(Parks Park, int Id)
{
using (var Db = new MyContext())
{
List<ParkList> ListOfParks = Db.ParkLists.Where(x => x.ParkId == Id).ToList();
foreach (var Parks in ListOfParks)
{
Parks.ParkId = Park.Id;
Parks.ParkName = Park.ParkName;
Parks.DomValue = Park.DomValue;
}
return Park;
}
}
}
Please look past the fact that the loop is somewhat pointless as we only return one ride, since it is not possible for this identity field to be duplicated. So that can be ignored right now.
So then in the application, we now have a type of class Parks that we can now use in the application. So I have two questions, is this an example of decoupled code from the data access perspective? So basically any of the data access I do, looks a lot like that GetSelectedXxxxx, not always filtering with Id, but similar anyway. Now granted, I'll never change the data storage of this small project, the project will never need to scale, and it will never need to be over engineered for what it is. The point is more educational. So I would want to treat this project as if it was large, enterprise scale, for the sake of the study.
Thanks guys!
c# entity-framework
asked 40 mins ago
CMRCMR
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Honestly, I have been really trying to read up and learn the best techniques for uncoupling different portions of my applications.
I have such a long way to go in regards to this and entity framework 6. I was hoping to post this small sample and get some feedback as far as tightly coupling was concerned.
Preface: this application is something I am doing as a personal practice project that relates to theme parks and rides.
So, basically we first have one of the objects that represents something I would take out of the database. This class is as follows:
public class Parks
{
public int Id { get; }
public string ParkValue{ get; set; }
public string ParkName { get; set; }
}
Simple class, with 3 properties. Now here is the data access that builds this based on an Id which comes from a different portion of the application.
public class ParkDataRetriever
{
public Parks GetSelectedPark(Parks Park, int Id)
{
using (var Db = new MyContext())
{
List<ParkList> ListOfParks = Db.ParkLists.Where(x => x.ParkId == Id).ToList();
foreach (var Parks in ListOfParks)
{
Parks.ParkId = Park.Id;
Parks.ParkName = Park.ParkName;
Parks.DomValue = Park.DomValue;
}
return Park;
}
}
}
Please look past the fact that the loop is somewhat pointless as we only return one ride, since it is not possible for this identity field to be duplicated. So that can be ignored right now.
So then in the application, we now have a type of class Parks that we can now use in the application. So I have two questions, is this an example of decoupled code from the data access perspective? So basically any of the data access I do, looks a lot like that GetSelectedXxxxx, not always filtering with Id, but similar anyway. Now granted, I'll never change the data storage of this small project, the project will never need to scale, and it will never need to be over engineered for what it is. The point is more educational. So I would want to treat this project as if it was large, enterprise scale, for the sake of the study.
Thanks guys!
c# entity-framework
asked 40 mins ago
CMRCMR
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Honestly, I have been really trying to read up and learn the best techniques for uncoupling different portions of my applications.
I have such a long way to go in regards to this and entity framework 6. I was hoping to post this small sample and get some feedback as far as tightly coupling was concerned.
Preface: this application is something I am doing as a personal practice project that relates to theme parks and rides.
So, basically we first have one of the objects that represents something I would take out of the database. This class is as follows:
public class Parks
{
public int Id { get; }
public string ParkValue{ get; set; }
public string ParkName { get; set; }
}
Simple class, with 3 properties. Now here is the data access that builds this based on an Id which comes from a different portion of the application.
public class ParkDataRetriever
{
public Parks GetSelectedPark(Parks Park, int Id)
{
using (var Db = new MyContext())
{
List<ParkList> ListOfParks = Db.ParkLists.Where(x => x.ParkId == Id).ToList();
foreach (var Parks in ListOfParks)
{
Parks.ParkId = Park.Id;
Parks.ParkName = Park.ParkName;
Parks.DomValue = Park.DomValue;
}
return Park;
}
}
}
Please look past the fact that the loop is somewhat pointless as we only return one ride, since it is not possible for this identity field to be duplicated. So that can be ignored right now.
So then in the application, we now have a type of class Parks that we can now use in the application. So I have two questions, is this an example of decoupled code from the data access perspective? So basically any of the data access I do, looks a lot like that GetSelectedXxxxx, not always filtering with Id, but similar anyway. Now granted, I'll never change the data storage of this small project, the project will never need to scale, and it will never need to be over engineered for what it is. The point is more educational. So I would want to treat this project as if it was large, enterprise scale, for the sake of the study.
Thanks guys!
c# entity-framework
c# entity-framework
asked 40 mins ago
CMRCMR
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 40 mins ago
CMRCMR
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 40 mins ago
CMRCMR
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 40 mins ago
CMRCMR
61
asked 40 mins ago
CMRCMR
61
61
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
CMR is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
CMR is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215540%2fam-i-looking-at-tightly-coupled-code-here-entity-framework-6%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
CMR is a new contributor. Be nice, and check out our Code of Conduct.
CMR is a new contributor. Be nice, and check out our Code of Conduct.
CMR is a new contributor. Be nice, and check out our Code of Conduct.
CMR is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215540%2fam-i-looking-at-tightly-coupled-code-here-entity-framework-6%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
