Semaphore implementation exception












0












$begingroup$



I am not sure why below code is throwing exception. If I implement the
same code with synchronized at method level then there is no
exception, and it works fine. I think using object lock should also
not have any issue.enter code here




 package practice;

public class CustomSemaphore {

int count;
int capacity;
Object lock = new Object();

public CustomSemaphore(int capacity) {
this.count = capacity;
}

public void acquire() throws InterruptedException {
synchronized (lock) {
while (count > capacity) {
wait();
}
count++;
System.out.println(Thread.currentThread().getName() + " got lock and working now");
}

}

public void release() {
synchronized (lock) {
count--;
notify();
System.out.println("releasing resource now");
}

}

public static void main(String args) throws InterruptedException {
final CustomSemaphore sem = new CustomSemaphore(1);
Runnable acquireTask = new Runnable() {

@Override
public void run() {
while (true) {
try {
sem.acquire();
System.out.println(" acquired lock" + Thread.currentThread().getName());
} catch (InterruptedException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
}

}
};
Thread acqThread = new Thread(acquireTask, "acquire");

Runnable releaseTask = new Runnable() {

@Override
public void run() {
while (true) {
sem.release();
}
}
};
Thread releaseThread = new Thread(releaseTask, "release");
acqThread.start();
releaseThread.start();
acqThread.join();
releaseThread.join();
}

}

}









share|improve this question









$endgroup$

















    0












    $begingroup$



    I am not sure why below code is throwing exception. If I implement the
    same code with synchronized at method level then there is no
    exception, and it works fine. I think using object lock should also
    not have any issue.enter code here




     package practice;

    public class CustomSemaphore {

    int count;
    int capacity;
    Object lock = new Object();

    public CustomSemaphore(int capacity) {
    this.count = capacity;
    }

    public void acquire() throws InterruptedException {
    synchronized (lock) {
    while (count > capacity) {
    wait();
    }
    count++;
    System.out.println(Thread.currentThread().getName() + " got lock and working now");
    }

    }

    public void release() {
    synchronized (lock) {
    count--;
    notify();
    System.out.println("releasing resource now");
    }

    }

    public static void main(String args) throws InterruptedException {
    final CustomSemaphore sem = new CustomSemaphore(1);
    Runnable acquireTask = new Runnable() {

    @Override
    public void run() {
    while (true) {
    try {
    sem.acquire();
    System.out.println(" acquired lock" + Thread.currentThread().getName());
    } catch (InterruptedException e) {
    // TODO Auto-generated catch block
    e.printStackTrace();
    }
    }

    }
    };
    Thread acqThread = new Thread(acquireTask, "acquire");

    Runnable releaseTask = new Runnable() {

    @Override
    public void run() {
    while (true) {
    sem.release();
    }
    }
    };
    Thread releaseThread = new Thread(releaseTask, "release");
    acqThread.start();
    releaseThread.start();
    acqThread.join();
    releaseThread.join();
    }

    }

    }









    share|improve this question









    $endgroup$















      0












      0








      0





      $begingroup$



      I am not sure why below code is throwing exception. If I implement the
      same code with synchronized at method level then there is no
      exception, and it works fine. I think using object lock should also
      not have any issue.enter code here




       package practice;

      public class CustomSemaphore {

      int count;
      int capacity;
      Object lock = new Object();

      public CustomSemaphore(int capacity) {
      this.count = capacity;
      }

      public void acquire() throws InterruptedException {
      synchronized (lock) {
      while (count > capacity) {
      wait();
      }
      count++;
      System.out.println(Thread.currentThread().getName() + " got lock and working now");
      }

      }

      public void release() {
      synchronized (lock) {
      count--;
      notify();
      System.out.println("releasing resource now");
      }

      }

      public static void main(String args) throws InterruptedException {
      final CustomSemaphore sem = new CustomSemaphore(1);
      Runnable acquireTask = new Runnable() {

      @Override
      public void run() {
      while (true) {
      try {
      sem.acquire();
      System.out.println(" acquired lock" + Thread.currentThread().getName());
      } catch (InterruptedException e) {
      // TODO Auto-generated catch block
      e.printStackTrace();
      }
      }

      }
      };
      Thread acqThread = new Thread(acquireTask, "acquire");

      Runnable releaseTask = new Runnable() {

      @Override
      public void run() {
      while (true) {
      sem.release();
      }
      }
      };
      Thread releaseThread = new Thread(releaseTask, "release");
      acqThread.start();
      releaseThread.start();
      acqThread.join();
      releaseThread.join();
      }

      }

      }









      share|improve this question









      $endgroup$





      I am not sure why below code is throwing exception. If I implement the
      same code with synchronized at method level then there is no
      exception, and it works fine. I think using object lock should also
      not have any issue.enter code here




       package practice;

      public class CustomSemaphore {

      int count;
      int capacity;
      Object lock = new Object();

      public CustomSemaphore(int capacity) {
      this.count = capacity;
      }

      public void acquire() throws InterruptedException {
      synchronized (lock) {
      while (count > capacity) {
      wait();
      }
      count++;
      System.out.println(Thread.currentThread().getName() + " got lock and working now");
      }

      }

      public void release() {
      synchronized (lock) {
      count--;
      notify();
      System.out.println("releasing resource now");
      }

      }

      public static void main(String args) throws InterruptedException {
      final CustomSemaphore sem = new CustomSemaphore(1);
      Runnable acquireTask = new Runnable() {

      @Override
      public void run() {
      while (true) {
      try {
      sem.acquire();
      System.out.println(" acquired lock" + Thread.currentThread().getName());
      } catch (InterruptedException e) {
      // TODO Auto-generated catch block
      e.printStackTrace();
      }
      }

      }
      };
      Thread acqThread = new Thread(acquireTask, "acquire");

      Runnable releaseTask = new Runnable() {

      @Override
      public void run() {
      while (true) {
      sem.release();
      }
      }
      };
      Thread releaseThread = new Thread(releaseTask, "release");
      acqThread.start();
      releaseThread.start();
      acqThread.join();
      releaseThread.join();
      }

      }

      }






      java multithreading concurrency






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 24 mins ago









      AKSAKS

      1161




      1161






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216095%2fsemaphore-implementation-exception%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216095%2fsemaphore-implementation-exception%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Сан-Квентин

          Алькесар

          Josef Freinademetz