Refactor if statements that check for different conditions
0
$begingroup$
Preface: I've perused the other related questions before creating this one but I believe that those solutions weren't applicable to my situation. I'll concede that its possible that I may not have understood a possible solution (if any).
I'm working on refactoring an old poker game that I created, which is a .NET Framework console application, and I came across this method.
/// <summary>
/// Evaluates the value of the player hand and computer hand.
/// </summary>
/// <param name="pComputerHand">The computer's current hand.</param>
/// <param name="pPlayerHand">The player's current hand.</param>
/// <returns>Returns true if the player won and false if the player lost. This value is stored in the the bool won variable.</returns>
private static bool CompareHands(SuperCard pComputerHand, SuperCard pPlayerHand)
{
// Stores the value of the player and computer hands.
int playerHandValue = 0;
int computerHandValue = 0;
// Evaluates the value of computer hand
foreach(SuperCard card in pComputerHand)
{
computerHandValue += (int)card.CardRank;
}
// Evaluates the value of player hand
foreach(SuperCard card in pPlayerHand)
{
playerHandValue += (int)card.CardRank;
}
// If there is a royal flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.RoyalFlush(pPlayerHand) & PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a royal flush!");
return false;
}
// If there is a royal flush in the player's hand, the player won.
if (PokerHands.RoyalFlush(pPlayerHand))
{
Console.WriteLine("nYou have a royal flush!");
return true;
}
// If there is a royal flush in the computer's hand, the player lost.
if (PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a royal flush!");
return false;
}
#region Straight Flush
// If there is a straight flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.StraightFlush(pPlayerHand) & PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a straight flush!");
return false;
}
// If there is a straight flush in the player's hand, the player won.
if (PokerHands.StraightFlush(pPlayerHand))
{
Console.WriteLine("nYou have a straight flush!");
return true;
}
// If there is a straight flush in the computer's hand, the player lost.
if (PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a straight flush!");
return false;
}
#endregion
#region Four Of A Kind
// If there is a four of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.FourOfAKind(pPlayerHand) & PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a four of a kind!");
return false;
}
// If there is a four of a kind in the player's hand, the player won.
if (PokerHands.FourOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a four of a kind!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has four of a kind!");
return false;
}
#endregion
#region Full House
// If there is a full house in the computer's hand and the player's hand, the player lost.
if (PokerHands.FullHouse(pPlayerHand) & PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nBoth players have a full house!");
return false;
}
// If there is a full house in the player's hand, the player won.
if (PokerHands.FullHouse(pPlayerHand))
{
Console.WriteLine("nYou have a full house!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nThe computer has a full house!");
return false;
}
#endregion
#region Flush
// If there is a flush in the player hand and the computer hand, the player lost.
if (PokerHands.Flush(pPlayerHand) && PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nBoth players have a flush!");
return false;
}
// If there is a flush in the player hand, the player won.
if (PokerHands.Flush(pPlayerHand))
{
Console.WriteLine("nYou have a flush!");
return true;
}
// If there is a flush in the computer hand, the player lost.
if (PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nThe computer has a flush!");
return false;
}
#endregion
#region Straight
// If there is a straight in the computer's hand and the player's hand, the player lost.
if (PokerHands.Straight(pPlayerHand) & PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nBoth players have a straight!");
return false;
}
// If there is a straight in the player's hand, the player won.
if (PokerHands.Straight(pPlayerHand))
{
Console.WriteLine("nYou have a straight!");
return true;
}
// If there is a straight in the computer's hand, the player lost.
if (PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nThe computer has a straight!");
return false;
}
#endregion
#region Three Of A Kind
// If there is a three of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.ThreeOfAKind(pPlayerHand) & PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a three of a kind!");
return false;
}
// If there is a three of a kind in the player's hand, the player won.
if (PokerHands.ThreeOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a three of a kind!");
return true;
}
// If there is a three of a kind in the computer's hand, the player lost.
if (PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has a three of a kind!");
return false;
}
#endregion
#region Two Pair
// If there is a two pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.TwoPair(pPlayerHand) & PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nBoth players have a two pair!");
return false;
}
// If there is a two pair in the player's hand, the player won.
if (PokerHands.TwoPair(pPlayerHand))
{
Console.WriteLine("nYou have a two pair!");
return true;
}
// If there is a two pair in the computer's hand, the player lost.
if (PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nThe computer has a two pair!");
return false;
}
#endregion
#region One Pair
// If there is a one pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.OnePair(pPlayerHand) & PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nBoth players have a one pair!");
return false;
}
// If there is a one pair in the player's hand, the player won.
if (PokerHands.OnePair(pPlayerHand))
{
Console.WriteLine("nYou have a one pair!");
return true;
}
// If there is a one pair in the computer's hand, the player lost.
if (PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nThe computer has a one pair!");
return false;
}
#endregion
// If the player's hand value is greater than the computer's hand value, the player won.
if (playerHandValue > computerHandValue)
{
return true;
}
// If the player's hand value is less than or equal to the computer's hand value, the player lost.
if (playerHandValue <= computerHandValue)
{
return false;
}
// Satisfies all code paths must return a value error.
else
{
return false;
}
} // end of CompareHands()
This is what the class diagram for the project looks like:
This is what the console output looks like:
My question is whether its possible to extract a method (or several) out of these if statements, and provided that it is possible, how would I go about doing so? I also appreciate any other advice that you can offer like the regions being bad, for example.
c# .net
asked 19 mins ago
Asel SAsel S
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
Preface: I've perused the other related questions before creating this one but I believe that those solutions weren't applicable to my situation. I'll concede that its possible that I may not have understood a possible solution (if any).
I'm working on refactoring an old poker game that I created, which is a .NET Framework console application, and I came across this method.
/// <summary>
/// Evaluates the value of the player hand and computer hand.
/// </summary>
/// <param name="pComputerHand">The computer's current hand.</param>
/// <param name="pPlayerHand">The player's current hand.</param>
/// <returns>Returns true if the player won and false if the player lost. This value is stored in the the bool won variable.</returns>
private static bool CompareHands(SuperCard pComputerHand, SuperCard pPlayerHand)
{
// Stores the value of the player and computer hands.
int playerHandValue = 0;
int computerHandValue = 0;
// Evaluates the value of computer hand
foreach(SuperCard card in pComputerHand)
{
computerHandValue += (int)card.CardRank;
}
// Evaluates the value of player hand
foreach(SuperCard card in pPlayerHand)
{
playerHandValue += (int)card.CardRank;
}
// If there is a royal flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.RoyalFlush(pPlayerHand) & PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a royal flush!");
return false;
}
// If there is a royal flush in the player's hand, the player won.
if (PokerHands.RoyalFlush(pPlayerHand))
{
Console.WriteLine("nYou have a royal flush!");
return true;
}
// If there is a royal flush in the computer's hand, the player lost.
if (PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a royal flush!");
return false;
}
#region Straight Flush
// If there is a straight flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.StraightFlush(pPlayerHand) & PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a straight flush!");
return false;
}
// If there is a straight flush in the player's hand, the player won.
if (PokerHands.StraightFlush(pPlayerHand))
{
Console.WriteLine("nYou have a straight flush!");
return true;
}
// If there is a straight flush in the computer's hand, the player lost.
if (PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a straight flush!");
return false;
}
#endregion
#region Four Of A Kind
// If there is a four of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.FourOfAKind(pPlayerHand) & PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a four of a kind!");
return false;
}
// If there is a four of a kind in the player's hand, the player won.
if (PokerHands.FourOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a four of a kind!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has four of a kind!");
return false;
}
#endregion
#region Full House
// If there is a full house in the computer's hand and the player's hand, the player lost.
if (PokerHands.FullHouse(pPlayerHand) & PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nBoth players have a full house!");
return false;
}
// If there is a full house in the player's hand, the player won.
if (PokerHands.FullHouse(pPlayerHand))
{
Console.WriteLine("nYou have a full house!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nThe computer has a full house!");
return false;
}
#endregion
#region Flush
// If there is a flush in the player hand and the computer hand, the player lost.
if (PokerHands.Flush(pPlayerHand) && PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nBoth players have a flush!");
return false;
}
// If there is a flush in the player hand, the player won.
if (PokerHands.Flush(pPlayerHand))
{
Console.WriteLine("nYou have a flush!");
return true;
}
// If there is a flush in the computer hand, the player lost.
if (PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nThe computer has a flush!");
return false;
}
#endregion
#region Straight
// If there is a straight in the computer's hand and the player's hand, the player lost.
if (PokerHands.Straight(pPlayerHand) & PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nBoth players have a straight!");
return false;
}
// If there is a straight in the player's hand, the player won.
if (PokerHands.Straight(pPlayerHand))
{
Console.WriteLine("nYou have a straight!");
return true;
}
// If there is a straight in the computer's hand, the player lost.
if (PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nThe computer has a straight!");
return false;
}
#endregion
#region Three Of A Kind
// If there is a three of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.ThreeOfAKind(pPlayerHand) & PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a three of a kind!");
return false;
}
// If there is a three of a kind in the player's hand, the player won.
if (PokerHands.ThreeOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a three of a kind!");
return true;
}
// If there is a three of a kind in the computer's hand, the player lost.
if (PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has a three of a kind!");
return false;
}
#endregion
#region Two Pair
// If there is a two pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.TwoPair(pPlayerHand) & PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nBoth players have a two pair!");
return false;
}
// If there is a two pair in the player's hand, the player won.
if (PokerHands.TwoPair(pPlayerHand))
{
Console.WriteLine("nYou have a two pair!");
return true;
}
// If there is a two pair in the computer's hand, the player lost.
if (PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nThe computer has a two pair!");
return false;
}
#endregion
#region One Pair
// If there is a one pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.OnePair(pPlayerHand) & PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nBoth players have a one pair!");
return false;
}
// If there is a one pair in the player's hand, the player won.
if (PokerHands.OnePair(pPlayerHand))
{
Console.WriteLine("nYou have a one pair!");
return true;
}
// If there is a one pair in the computer's hand, the player lost.
if (PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nThe computer has a one pair!");
return false;
}
#endregion
// If the player's hand value is greater than the computer's hand value, the player won.
if (playerHandValue > computerHandValue)
{
return true;
}
// If the player's hand value is less than or equal to the computer's hand value, the player lost.
if (playerHandValue <= computerHandValue)
{
return false;
}
// Satisfies all code paths must return a value error.
else
{
return false;
}
} // end of CompareHands()
This is what the class diagram for the project looks like:
This is what the console output looks like:
My question is whether its possible to extract a method (or several) out of these if statements, and provided that it is possible, how would I go about doing so? I also appreciate any other advice that you can offer like the regions being bad, for example.
c# .net
asked 19 mins ago
Asel SAsel S
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
Preface: I've perused the other related questions before creating this one but I believe that those solutions weren't applicable to my situation. I'll concede that its possible that I may not have understood a possible solution (if any).
I'm working on refactoring an old poker game that I created, which is a .NET Framework console application, and I came across this method.
/// <summary>
/// Evaluates the value of the player hand and computer hand.
/// </summary>
/// <param name="pComputerHand">The computer's current hand.</param>
/// <param name="pPlayerHand">The player's current hand.</param>
/// <returns>Returns true if the player won and false if the player lost. This value is stored in the the bool won variable.</returns>
private static bool CompareHands(SuperCard pComputerHand, SuperCard pPlayerHand)
{
// Stores the value of the player and computer hands.
int playerHandValue = 0;
int computerHandValue = 0;
// Evaluates the value of computer hand
foreach(SuperCard card in pComputerHand)
{
computerHandValue += (int)card.CardRank;
}
// Evaluates the value of player hand
foreach(SuperCard card in pPlayerHand)
{
playerHandValue += (int)card.CardRank;
}
// If there is a royal flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.RoyalFlush(pPlayerHand) & PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a royal flush!");
return false;
}
// If there is a royal flush in the player's hand, the player won.
if (PokerHands.RoyalFlush(pPlayerHand))
{
Console.WriteLine("nYou have a royal flush!");
return true;
}
// If there is a royal flush in the computer's hand, the player lost.
if (PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a royal flush!");
return false;
}
#region Straight Flush
// If there is a straight flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.StraightFlush(pPlayerHand) & PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a straight flush!");
return false;
}
// If there is a straight flush in the player's hand, the player won.
if (PokerHands.StraightFlush(pPlayerHand))
{
Console.WriteLine("nYou have a straight flush!");
return true;
}
// If there is a straight flush in the computer's hand, the player lost.
if (PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a straight flush!");
return false;
}
#endregion
#region Four Of A Kind
// If there is a four of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.FourOfAKind(pPlayerHand) & PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a four of a kind!");
return false;
}
// If there is a four of a kind in the player's hand, the player won.
if (PokerHands.FourOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a four of a kind!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has four of a kind!");
return false;
}
#endregion
#region Full House
// If there is a full house in the computer's hand and the player's hand, the player lost.
if (PokerHands.FullHouse(pPlayerHand) & PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nBoth players have a full house!");
return false;
}
// If there is a full house in the player's hand, the player won.
if (PokerHands.FullHouse(pPlayerHand))
{
Console.WriteLine("nYou have a full house!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nThe computer has a full house!");
return false;
}
#endregion
#region Flush
// If there is a flush in the player hand and the computer hand, the player lost.
if (PokerHands.Flush(pPlayerHand) && PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nBoth players have a flush!");
return false;
}
// If there is a flush in the player hand, the player won.
if (PokerHands.Flush(pPlayerHand))
{
Console.WriteLine("nYou have a flush!");
return true;
}
// If there is a flush in the computer hand, the player lost.
if (PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nThe computer has a flush!");
return false;
}
#endregion
#region Straight
// If there is a straight in the computer's hand and the player's hand, the player lost.
if (PokerHands.Straight(pPlayerHand) & PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nBoth players have a straight!");
return false;
}
// If there is a straight in the player's hand, the player won.
if (PokerHands.Straight(pPlayerHand))
{
Console.WriteLine("nYou have a straight!");
return true;
}
// If there is a straight in the computer's hand, the player lost.
if (PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nThe computer has a straight!");
return false;
}
#endregion
#region Three Of A Kind
// If there is a three of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.ThreeOfAKind(pPlayerHand) & PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a three of a kind!");
return false;
}
// If there is a three of a kind in the player's hand, the player won.
if (PokerHands.ThreeOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a three of a kind!");
return true;
}
// If there is a three of a kind in the computer's hand, the player lost.
if (PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has a three of a kind!");
return false;
}
#endregion
#region Two Pair
// If there is a two pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.TwoPair(pPlayerHand) & PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nBoth players have a two pair!");
return false;
}
// If there is a two pair in the player's hand, the player won.
if (PokerHands.TwoPair(pPlayerHand))
{
Console.WriteLine("nYou have a two pair!");
return true;
}
// If there is a two pair in the computer's hand, the player lost.
if (PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nThe computer has a two pair!");
return false;
}
#endregion
#region One Pair
// If there is a one pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.OnePair(pPlayerHand) & PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nBoth players have a one pair!");
return false;
}
// If there is a one pair in the player's hand, the player won.
if (PokerHands.OnePair(pPlayerHand))
{
Console.WriteLine("nYou have a one pair!");
return true;
}
// If there is a one pair in the computer's hand, the player lost.
if (PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nThe computer has a one pair!");
return false;
}
#endregion
// If the player's hand value is greater than the computer's hand value, the player won.
if (playerHandValue > computerHandValue)
{
return true;
}
// If the player's hand value is less than or equal to the computer's hand value, the player lost.
if (playerHandValue <= computerHandValue)
{
return false;
}
// Satisfies all code paths must return a value error.
else
{
return false;
}
} // end of CompareHands()
This is what the class diagram for the project looks like:
This is what the console output looks like:
My question is whether its possible to extract a method (or several) out of these if statements, and provided that it is possible, how would I go about doing so? I also appreciate any other advice that you can offer like the regions being bad, for example.
c# .net
asked 19 mins ago
Asel SAsel S
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Preface: I've perused the other related questions before creating this one but I believe that those solutions weren't applicable to my situation. I'll concede that its possible that I may not have understood a possible solution (if any).
I'm working on refactoring an old poker game that I created, which is a .NET Framework console application, and I came across this method.
/// <summary>
/// Evaluates the value of the player hand and computer hand.
/// </summary>
/// <param name="pComputerHand">The computer's current hand.</param>
/// <param name="pPlayerHand">The player's current hand.</param>
/// <returns>Returns true if the player won and false if the player lost. This value is stored in the the bool won variable.</returns>
private static bool CompareHands(SuperCard pComputerHand, SuperCard pPlayerHand)
{
// Stores the value of the player and computer hands.
int playerHandValue = 0;
int computerHandValue = 0;
// Evaluates the value of computer hand
foreach(SuperCard card in pComputerHand)
{
computerHandValue += (int)card.CardRank;
}
// Evaluates the value of player hand
foreach(SuperCard card in pPlayerHand)
{
playerHandValue += (int)card.CardRank;
}
// If there is a royal flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.RoyalFlush(pPlayerHand) & PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a royal flush!");
return false;
}
// If there is a royal flush in the player's hand, the player won.
if (PokerHands.RoyalFlush(pPlayerHand))
{
Console.WriteLine("nYou have a royal flush!");
return true;
}
// If there is a royal flush in the computer's hand, the player lost.
if (PokerHands.RoyalFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a royal flush!");
return false;
}
#region Straight Flush
// If there is a straight flush in the computer's hand and the player's hand, the player lost.
if (PokerHands.StraightFlush(pPlayerHand) & PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nBoth players have a straight flush!");
return false;
}
// If there is a straight flush in the player's hand, the player won.
if (PokerHands.StraightFlush(pPlayerHand))
{
Console.WriteLine("nYou have a straight flush!");
return true;
}
// If there is a straight flush in the computer's hand, the player lost.
if (PokerHands.StraightFlush(pComputerHand))
{
Console.WriteLine("nThe computer has a straight flush!");
return false;
}
#endregion
#region Four Of A Kind
// If there is a four of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.FourOfAKind(pPlayerHand) & PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a four of a kind!");
return false;
}
// If there is a four of a kind in the player's hand, the player won.
if (PokerHands.FourOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a four of a kind!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FourOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has four of a kind!");
return false;
}
#endregion
#region Full House
// If there is a full house in the computer's hand and the player's hand, the player lost.
if (PokerHands.FullHouse(pPlayerHand) & PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nBoth players have a full house!");
return false;
}
// If there is a full house in the player's hand, the player won.
if (PokerHands.FullHouse(pPlayerHand))
{
Console.WriteLine("nYou have a full house!");
return true;
}
// If there is a four of a kind in the computer's hand, the player lost.
if (PokerHands.FullHouse(pComputerHand))
{
Console.WriteLine("nThe computer has a full house!");
return false;
}
#endregion
#region Flush
// If there is a flush in the player hand and the computer hand, the player lost.
if (PokerHands.Flush(pPlayerHand) && PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nBoth players have a flush!");
return false;
}
// If there is a flush in the player hand, the player won.
if (PokerHands.Flush(pPlayerHand))
{
Console.WriteLine("nYou have a flush!");
return true;
}
// If there is a flush in the computer hand, the player lost.
if (PokerHands.Flush(pComputerHand))
{
Console.WriteLine("nThe computer has a flush!");
return false;
}
#endregion
#region Straight
// If there is a straight in the computer's hand and the player's hand, the player lost.
if (PokerHands.Straight(pPlayerHand) & PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nBoth players have a straight!");
return false;
}
// If there is a straight in the player's hand, the player won.
if (PokerHands.Straight(pPlayerHand))
{
Console.WriteLine("nYou have a straight!");
return true;
}
// If there is a straight in the computer's hand, the player lost.
if (PokerHands.Straight(pComputerHand))
{
Console.WriteLine("nThe computer has a straight!");
return false;
}
#endregion
#region Three Of A Kind
// If there is a three of a kind in the computer's hand and the player's hand, the player lost.
if (PokerHands.ThreeOfAKind(pPlayerHand) & PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nBoth players have a three of a kind!");
return false;
}
// If there is a three of a kind in the player's hand, the player won.
if (PokerHands.ThreeOfAKind(pPlayerHand))
{
Console.WriteLine("nYou have a three of a kind!");
return true;
}
// If there is a three of a kind in the computer's hand, the player lost.
if (PokerHands.ThreeOfAKind(pComputerHand))
{
Console.WriteLine("nThe computer has a three of a kind!");
return false;
}
#endregion
#region Two Pair
// If there is a two pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.TwoPair(pPlayerHand) & PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nBoth players have a two pair!");
return false;
}
// If there is a two pair in the player's hand, the player won.
if (PokerHands.TwoPair(pPlayerHand))
{
Console.WriteLine("nYou have a two pair!");
return true;
}
// If there is a two pair in the computer's hand, the player lost.
if (PokerHands.TwoPair(pComputerHand))
{
Console.WriteLine("nThe computer has a two pair!");
return false;
}
#endregion
#region One Pair
// If there is a one pair in the computer's hand and the player's hand, the player lost.
if (PokerHands.OnePair(pPlayerHand) & PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nBoth players have a one pair!");
return false;
}
// If there is a one pair in the player's hand, the player won.
if (PokerHands.OnePair(pPlayerHand))
{
Console.WriteLine("nYou have a one pair!");
return true;
}
// If there is a one pair in the computer's hand, the player lost.
if (PokerHands.OnePair(pComputerHand))
{
Console.WriteLine("nThe computer has a one pair!");
return false;
}
#endregion
// If the player's hand value is greater than the computer's hand value, the player won.
if (playerHandValue > computerHandValue)
{
return true;
}
// If the player's hand value is less than or equal to the computer's hand value, the player lost.
if (playerHandValue <= computerHandValue)
{
return false;
}
// Satisfies all code paths must return a value error.
else
{
return false;
}
} // end of CompareHands()
This is what the class diagram for the project looks like:
This is what the console output looks like:
My question is whether its possible to extract a method (or several) out of these if statements, and provided that it is possible, how would I go about doing so? I also appreciate any other advice that you can offer like the regions being bad, for example.
c# .net
c# .net
asked 19 mins ago
Asel SAsel S
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 19 mins ago
Asel SAsel S
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 19 mins ago
Asel SAsel S
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 19 mins ago
Asel SAsel S
12
asked 19 mins ago
Asel SAsel S
12
12
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Asel S is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216088%2frefactor-if-statements-that-check-for-different-conditions%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Asel S is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216088%2frefactor-if-statements-that-check-for-different-conditions%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
