Remove excessive whitespace from string
$begingroup$
Is that standards-compliant?
#include <string>
#include <algorithm>
#include <iostream>
#include <cctype>
std::string remove_excessive_ws(std::string const &str)
{
std::string result{ str };
auto end{ std::remove_if(std::begin(result), std::end(result),
(std::string::value_type const &ch) {
return std::isspace(static_cast<unsigned>(ch)) &&
(std::isspace(static_cast<unsigned>((&ch)[1])) || (&ch)[1] == '');
}
)
};
result.erase(end, std::end(result));
return result;
}
int main()
{
char const *foo{ "Hello World! " };
std::cout << '"' << remove_excessive_ws(foo) << ""n";
}
It's about accessing (&ch)[1]
. I think it should be legal, but I am not sure. After all std::find_if()
could copy the entity and pass it to the function and the pointer (&ch) + 1
might not be valid.
c++
$endgroup$
add a comment |
$begingroup$
Is that standards-compliant?
#include <string>
#include <algorithm>
#include <iostream>
#include <cctype>
std::string remove_excessive_ws(std::string const &str)
{
std::string result{ str };
auto end{ std::remove_if(std::begin(result), std::end(result),
(std::string::value_type const &ch) {
return std::isspace(static_cast<unsigned>(ch)) &&
(std::isspace(static_cast<unsigned>((&ch)[1])) || (&ch)[1] == '');
}
)
};
result.erase(end, std::end(result));
return result;
}
int main()
{
char const *foo{ "Hello World! " };
std::cout << '"' << remove_excessive_ws(foo) << ""n";
}
It's about accessing (&ch)[1]
. I think it should be legal, but I am not sure. After all std::find_if()
could copy the entity and pass it to the function and the pointer (&ch) + 1
might not be valid.
c++
$endgroup$
add a comment |
$begingroup$
Is that standards-compliant?
#include <string>
#include <algorithm>
#include <iostream>
#include <cctype>
std::string remove_excessive_ws(std::string const &str)
{
std::string result{ str };
auto end{ std::remove_if(std::begin(result), std::end(result),
(std::string::value_type const &ch) {
return std::isspace(static_cast<unsigned>(ch)) &&
(std::isspace(static_cast<unsigned>((&ch)[1])) || (&ch)[1] == '');
}
)
};
result.erase(end, std::end(result));
return result;
}
int main()
{
char const *foo{ "Hello World! " };
std::cout << '"' << remove_excessive_ws(foo) << ""n";
}
It's about accessing (&ch)[1]
. I think it should be legal, but I am not sure. After all std::find_if()
could copy the entity and pass it to the function and the pointer (&ch) + 1
might not be valid.
c++
$endgroup$
Is that standards-compliant?
#include <string>
#include <algorithm>
#include <iostream>
#include <cctype>
std::string remove_excessive_ws(std::string const &str)
{
std::string result{ str };
auto end{ std::remove_if(std::begin(result), std::end(result),
(std::string::value_type const &ch) {
return std::isspace(static_cast<unsigned>(ch)) &&
(std::isspace(static_cast<unsigned>((&ch)[1])) || (&ch)[1] == '');
}
)
};
result.erase(end, std::end(result));
return result;
}
int main()
{
char const *foo{ "Hello World! " };
std::cout << '"' << remove_excessive_ws(foo) << ""n";
}
It's about accessing (&ch)[1]
. I think it should be legal, but I am not sure. After all std::find_if()
could copy the entity and pass it to the function and the pointer (&ch) + 1
might not be valid.
c++
c++
edited 8 mins ago
Swordfish
asked 11 mins ago
SwordfishSwordfish
1477
1477
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214299%2fremove-excessive-whitespace-from-string%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214299%2fremove-excessive-whitespace-from-string%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown