Minimum number of parentheses to be removed to make a string of parentheses balanced
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}
$begingroup$
The task:
Given a string of parentheses, write a function to compute the minimum
number of parentheses to be removed to make the string valid (i.e.
each open parenthesis is eventually closed).
For example, given the string "()())()", you should return 1. Given
the string ")(", you should return 2, since we must remove all of
them.
const brackets = "()())()";
My functional solution:
const numberOfUnbalanced = brackets => Object.values(brackets
.split("")
.reduce((brackCounter, b) => {
b === "(" ? brackCounter.openBrackets++ :
brackCounter.openBrackets ? brackCounter.openBrackets-- :
brackCounter.closedBrackets++;
return brackCounter;
}, {openBrackets: 0, closedBrackets: 0}))
.reduce((sum, b) => sum + b, 0);
console.log(numberOfUnbalanced(brackets));
My imperative solution:
function numberOfUnbalanced2(brackets) {
let openBrackets = 0, closedBrackets = 0;
for (let i in brackets) {
brackets[i] === "(" ? openBrackets++ :
openBrackets ? openBrackets-- :
closedBrackets++;
}
return openBrackets + closedBrackets;
}
console.log(numberOfUnbalanced2(brackets));
Usually the functional approach is shorter and tend to be easier to understand in comparison to imperative approaches. However, in this case it doesn't have any advantage to the imperative approach. I guess it is due to the nested structure in the functional solution.
javascript algorithm programming-challenge functional-programming
asked 58 mins ago
thadeuszlaythadeuszlay
855516
$endgroup$
add a comment |
$begingroup$
The task:
Given a string of parentheses, write a function to compute the minimum
number of parentheses to be removed to make the string valid (i.e.
each open parenthesis is eventually closed).
For example, given the string "()())()", you should return 1. Given
the string ")(", you should return 2, since we must remove all of
them.
const brackets = "()())()";
My functional solution:
const numberOfUnbalanced = brackets => Object.values(brackets
.split("")
.reduce((brackCounter, b) => {
b === "(" ? brackCounter.openBrackets++ :
brackCounter.openBrackets ? brackCounter.openBrackets-- :
brackCounter.closedBrackets++;
return brackCounter;
}, {openBrackets: 0, closedBrackets: 0}))
.reduce((sum, b) => sum + b, 0);
console.log(numberOfUnbalanced(brackets));
My imperative solution:
function numberOfUnbalanced2(brackets) {
let openBrackets = 0, closedBrackets = 0;
for (let i in brackets) {
brackets[i] === "(" ? openBrackets++ :
openBrackets ? openBrackets-- :
closedBrackets++;
}
return openBrackets + closedBrackets;
}
console.log(numberOfUnbalanced2(brackets));
Usually the functional approach is shorter and tend to be easier to understand in comparison to imperative approaches. However, in this case it doesn't have any advantage to the imperative approach. I guess it is due to the nested structure in the functional solution.
javascript algorithm programming-challenge functional-programming
asked 58 mins ago
thadeuszlaythadeuszlay
855516
$endgroup$
add a comment |
$begingroup$
The task:
Given a string of parentheses, write a function to compute the minimum
number of parentheses to be removed to make the string valid (i.e.
each open parenthesis is eventually closed).
For example, given the string "()())()", you should return 1. Given
the string ")(", you should return 2, since we must remove all of
them.
const brackets = "()())()";
My functional solution:
const numberOfUnbalanced = brackets => Object.values(brackets
.split("")
.reduce((brackCounter, b) => {
b === "(" ? brackCounter.openBrackets++ :
brackCounter.openBrackets ? brackCounter.openBrackets-- :
brackCounter.closedBrackets++;
return brackCounter;
}, {openBrackets: 0, closedBrackets: 0}))
.reduce((sum, b) => sum + b, 0);
console.log(numberOfUnbalanced(brackets));
My imperative solution:
function numberOfUnbalanced2(brackets) {
let openBrackets = 0, closedBrackets = 0;
for (let i in brackets) {
brackets[i] === "(" ? openBrackets++ :
openBrackets ? openBrackets-- :
closedBrackets++;
}
return openBrackets + closedBrackets;
}
console.log(numberOfUnbalanced2(brackets));
Usually the functional approach is shorter and tend to be easier to understand in comparison to imperative approaches. However, in this case it doesn't have any advantage to the imperative approach. I guess it is due to the nested structure in the functional solution.
javascript algorithm programming-challenge functional-programming
asked 58 mins ago
thadeuszlaythadeuszlay
855516
$endgroup$
The task:
Given a string of parentheses, write a function to compute the minimum
number of parentheses to be removed to make the string valid (i.e.
each open parenthesis is eventually closed).
For example, given the string "()())()", you should return 1. Given
the string ")(", you should return 2, since we must remove all of
them.
const brackets = "()())()";
My functional solution:
const numberOfUnbalanced = brackets => Object.values(brackets
.split("")
.reduce((brackCounter, b) => {
b === "(" ? brackCounter.openBrackets++ :
brackCounter.openBrackets ? brackCounter.openBrackets-- :
brackCounter.closedBrackets++;
return brackCounter;
}, {openBrackets: 0, closedBrackets: 0}))
.reduce((sum, b) => sum + b, 0);
console.log(numberOfUnbalanced(brackets));
My imperative solution:
function numberOfUnbalanced2(brackets) {
let openBrackets = 0, closedBrackets = 0;
for (let i in brackets) {
brackets[i] === "(" ? openBrackets++ :
openBrackets ? openBrackets-- :
closedBrackets++;
}
return openBrackets + closedBrackets;
}
console.log(numberOfUnbalanced2(brackets));
Usually the functional approach is shorter and tend to be easier to understand in comparison to imperative approaches. However, in this case it doesn't have any advantage to the imperative approach. I guess it is due to the nested structure in the functional solution.
javascript algorithm programming-challenge functional-programming
javascript algorithm programming-challenge functional-programming
asked 58 mins ago
thadeuszlaythadeuszlay
855516
asked 58 mins ago
thadeuszlaythadeuszlay
855516
asked 58 mins ago
thadeuszlaythadeuszlay
855516
asked 58 mins ago
thadeuszlaythadeuszlay
855516
asked 58 mins ago
thadeuszlaythadeuszlay
855516
855516
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217242%2fminimum-number-of-parentheses-to-be-removed-to-make-a-string-of-parentheses-bala%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217242%2fminimum-number-of-parentheses-to-be-removed-to-make-a-string-of-parentheses-bala%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
