AST Visitor Pattern in Java
$begingroup$
I am trying to make a simple expression evaluator in Java using Jacc (a parser generator). I am done with the AST creation and now need to create an evaluator. For this I made a simple test to try to understand how visitors work. Here is my code
interface Visitor
{
public void visitB(B b);
public void visitC(C c);
public void visitD(D d);
}
class PrintVisitor implements Visitor
{
public void visitB(B b)
{
b.child1.accept(this);
b.child2.accept(this);
System.out.println("a B visited: " + b.name);
}
public void visitC(C c)
{
c.child.accept(this);
System.out.println("a C visited: " + c.name);
}
public void visitD(D d)
{
System.out.println("a D visited: " + d.name);
}
}
abstract class A
{
public String name;
abstract void accept(Visitor v);
}
class B extends A
{
public A child1;
public A child2;
public B(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitB(this);
}
}
class C extends A
{
public A child;
public C(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitC(this);
}
}
class D extends A
{
public D(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitD(this);
}
}
class Main
{
public static void main(String args)
{
B b1 = new B("b1");
B b2 = new B("b2");
C c1 = new C("c1");
C c2 = new C("c2");
D d1 = new D("d1");
D d2 = new D("d2");
D d3 = new D("d3");
D d4 = new D("d4");
/*
b1
/
c1 c2
/
b2 d2
/
d3 d4
*/
b1.child1 = c1;
b1.child2 = c2;
c1.child = b2;
c2.child = d2;
b2.child1 = d3;
b2.child2 = d4;
PrintVisitor v = new PrintVisitor();
b1.accept(v);
}
}
I would appreciate if you guys commented on my understanding of visitors.
java parsing visitor-pattern
$endgroup$
add a comment |
$begingroup$
I am trying to make a simple expression evaluator in Java using Jacc (a parser generator). I am done with the AST creation and now need to create an evaluator. For this I made a simple test to try to understand how visitors work. Here is my code
interface Visitor
{
public void visitB(B b);
public void visitC(C c);
public void visitD(D d);
}
class PrintVisitor implements Visitor
{
public void visitB(B b)
{
b.child1.accept(this);
b.child2.accept(this);
System.out.println("a B visited: " + b.name);
}
public void visitC(C c)
{
c.child.accept(this);
System.out.println("a C visited: " + c.name);
}
public void visitD(D d)
{
System.out.println("a D visited: " + d.name);
}
}
abstract class A
{
public String name;
abstract void accept(Visitor v);
}
class B extends A
{
public A child1;
public A child2;
public B(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitB(this);
}
}
class C extends A
{
public A child;
public C(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitC(this);
}
}
class D extends A
{
public D(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitD(this);
}
}
class Main
{
public static void main(String args)
{
B b1 = new B("b1");
B b2 = new B("b2");
C c1 = new C("c1");
C c2 = new C("c2");
D d1 = new D("d1");
D d2 = new D("d2");
D d3 = new D("d3");
D d4 = new D("d4");
/*
b1
/
c1 c2
/
b2 d2
/
d3 d4
*/
b1.child1 = c1;
b1.child2 = c2;
c1.child = b2;
c2.child = d2;
b2.child1 = d3;
b2.child2 = d4;
PrintVisitor v = new PrintVisitor();
b1.accept(v);
}
}
I would appreciate if you guys commented on my understanding of visitors.
java parsing visitor-pattern
$endgroup$
add a comment |
$begingroup$
I am trying to make a simple expression evaluator in Java using Jacc (a parser generator). I am done with the AST creation and now need to create an evaluator. For this I made a simple test to try to understand how visitors work. Here is my code
interface Visitor
{
public void visitB(B b);
public void visitC(C c);
public void visitD(D d);
}
class PrintVisitor implements Visitor
{
public void visitB(B b)
{
b.child1.accept(this);
b.child2.accept(this);
System.out.println("a B visited: " + b.name);
}
public void visitC(C c)
{
c.child.accept(this);
System.out.println("a C visited: " + c.name);
}
public void visitD(D d)
{
System.out.println("a D visited: " + d.name);
}
}
abstract class A
{
public String name;
abstract void accept(Visitor v);
}
class B extends A
{
public A child1;
public A child2;
public B(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitB(this);
}
}
class C extends A
{
public A child;
public C(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitC(this);
}
}
class D extends A
{
public D(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitD(this);
}
}
class Main
{
public static void main(String args)
{
B b1 = new B("b1");
B b2 = new B("b2");
C c1 = new C("c1");
C c2 = new C("c2");
D d1 = new D("d1");
D d2 = new D("d2");
D d3 = new D("d3");
D d4 = new D("d4");
/*
b1
/
c1 c2
/
b2 d2
/
d3 d4
*/
b1.child1 = c1;
b1.child2 = c2;
c1.child = b2;
c2.child = d2;
b2.child1 = d3;
b2.child2 = d4;
PrintVisitor v = new PrintVisitor();
b1.accept(v);
}
}
I would appreciate if you guys commented on my understanding of visitors.
java parsing visitor-pattern
$endgroup$
I am trying to make a simple expression evaluator in Java using Jacc (a parser generator). I am done with the AST creation and now need to create an evaluator. For this I made a simple test to try to understand how visitors work. Here is my code
interface Visitor
{
public void visitB(B b);
public void visitC(C c);
public void visitD(D d);
}
class PrintVisitor implements Visitor
{
public void visitB(B b)
{
b.child1.accept(this);
b.child2.accept(this);
System.out.println("a B visited: " + b.name);
}
public void visitC(C c)
{
c.child.accept(this);
System.out.println("a C visited: " + c.name);
}
public void visitD(D d)
{
System.out.println("a D visited: " + d.name);
}
}
abstract class A
{
public String name;
abstract void accept(Visitor v);
}
class B extends A
{
public A child1;
public A child2;
public B(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitB(this);
}
}
class C extends A
{
public A child;
public C(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitC(this);
}
}
class D extends A
{
public D(String name)
{
this.name = name;
}
@Override
void accept(Visitor v)
{
v.visitD(this);
}
}
class Main
{
public static void main(String args)
{
B b1 = new B("b1");
B b2 = new B("b2");
C c1 = new C("c1");
C c2 = new C("c2");
D d1 = new D("d1");
D d2 = new D("d2");
D d3 = new D("d3");
D d4 = new D("d4");
/*
b1
/
c1 c2
/
b2 d2
/
d3 d4
*/
b1.child1 = c1;
b1.child2 = c2;
c1.child = b2;
c2.child = d2;
b2.child1 = d3;
b2.child2 = d4;
PrintVisitor v = new PrintVisitor();
b1.accept(v);
}
}
I would appreciate if you guys commented on my understanding of visitors.
java parsing visitor-pattern
java parsing visitor-pattern
asked 15 mins ago
AnonimistaAnonimista
111
111
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215812%2fast-visitor-pattern-in-java%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215812%2fast-visitor-pattern-in-java%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown