PowerShell: is this an unorthodox way o use Write-Verbose?












0












$begingroup$


I'm new at PowerShell and I like it.



I had the change to write a script that uninstall Erlang and RabbitMQ and I want the same script to then remove the Erlang folder and the RabbitMQ folder.



But in order to do so I need the script to respect the tasks order.



My way out was to use Write-Verbose (line 13) so the script needs to wait for the task to end in order to pass to the next task:



# Let's set some verbosity
$VerbosePreference = 'Continue'

function Check_Program_Installed($programName){
$check = Get-ChildItem -Path "HKLM:SOFTWAREMicrosoftWindowsCurrentVersionUninstall", "HKLM:SOFTWAREWow6432NodeMicrosoftWindowsCurrentVersionUninstall" |
Get-ItemProperty | Where-Object {$_.DisplayName -like "*$programName*" } | Select-Object -Property DisplayName, UninstallString

If ($check.DisplayName) {
$result = $check.DisplayName
Write-Output "I found: $result, let's uninstall it!"
$uninst = $check.UninstallString

Write-Verbose $uninst
Start-Process -FilePath $uninst -ArgumentList "/qn" -Wait #-NoNewWindow

Check_Program_Installed($programName)
}
Else{
Write-Output "$programName is not installed"
}
}

# Erlang check and Uninstall
Write-Output "Checking if Erlang exist"
Check_Program_Installed("Erlang")
# RabbitMQ check and Uninstall
Write-Output "Checking if RabbitMQ exist"
Check_Program_Installed("Rabbit")

# These actions need to be executed ONLY after Erlang and RabbitMQ uninstall
Write-Output "Then we do action 1"
Start-Sleep -s 3
Write-Output "Then we do action 2"
Start-Sleep -s 3
Write-Output "Then we do action 3"
Start-Sleep -s 3
Write-Output "Then we do action 4"
Start-Sleep -s 3
Write-Output "Then we do action 5"


enter image description here



This is a very newbie approach but it's the only thing I came out with.



Is there a more elegant way to handle the task and avoid PowerShell to pass to the next task if the previous one isn't completed?



Thank you









share







New contributor




Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I'm new at PowerShell and I like it.



    I had the change to write a script that uninstall Erlang and RabbitMQ and I want the same script to then remove the Erlang folder and the RabbitMQ folder.



    But in order to do so I need the script to respect the tasks order.



    My way out was to use Write-Verbose (line 13) so the script needs to wait for the task to end in order to pass to the next task:



    # Let's set some verbosity
    $VerbosePreference = 'Continue'

    function Check_Program_Installed($programName){
    $check = Get-ChildItem -Path "HKLM:SOFTWAREMicrosoftWindowsCurrentVersionUninstall", "HKLM:SOFTWAREWow6432NodeMicrosoftWindowsCurrentVersionUninstall" |
    Get-ItemProperty | Where-Object {$_.DisplayName -like "*$programName*" } | Select-Object -Property DisplayName, UninstallString

    If ($check.DisplayName) {
    $result = $check.DisplayName
    Write-Output "I found: $result, let's uninstall it!"
    $uninst = $check.UninstallString

    Write-Verbose $uninst
    Start-Process -FilePath $uninst -ArgumentList "/qn" -Wait #-NoNewWindow

    Check_Program_Installed($programName)
    }
    Else{
    Write-Output "$programName is not installed"
    }
    }

    # Erlang check and Uninstall
    Write-Output "Checking if Erlang exist"
    Check_Program_Installed("Erlang")
    # RabbitMQ check and Uninstall
    Write-Output "Checking if RabbitMQ exist"
    Check_Program_Installed("Rabbit")

    # These actions need to be executed ONLY after Erlang and RabbitMQ uninstall
    Write-Output "Then we do action 1"
    Start-Sleep -s 3
    Write-Output "Then we do action 2"
    Start-Sleep -s 3
    Write-Output "Then we do action 3"
    Start-Sleep -s 3
    Write-Output "Then we do action 4"
    Start-Sleep -s 3
    Write-Output "Then we do action 5"


    enter image description here



    This is a very newbie approach but it's the only thing I came out with.



    Is there a more elegant way to handle the task and avoid PowerShell to pass to the next task if the previous one isn't completed?



    Thank you









    share







    New contributor




    Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I'm new at PowerShell and I like it.



      I had the change to write a script that uninstall Erlang and RabbitMQ and I want the same script to then remove the Erlang folder and the RabbitMQ folder.



      But in order to do so I need the script to respect the tasks order.



      My way out was to use Write-Verbose (line 13) so the script needs to wait for the task to end in order to pass to the next task:



      # Let's set some verbosity
      $VerbosePreference = 'Continue'

      function Check_Program_Installed($programName){
      $check = Get-ChildItem -Path "HKLM:SOFTWAREMicrosoftWindowsCurrentVersionUninstall", "HKLM:SOFTWAREWow6432NodeMicrosoftWindowsCurrentVersionUninstall" |
      Get-ItemProperty | Where-Object {$_.DisplayName -like "*$programName*" } | Select-Object -Property DisplayName, UninstallString

      If ($check.DisplayName) {
      $result = $check.DisplayName
      Write-Output "I found: $result, let's uninstall it!"
      $uninst = $check.UninstallString

      Write-Verbose $uninst
      Start-Process -FilePath $uninst -ArgumentList "/qn" -Wait #-NoNewWindow

      Check_Program_Installed($programName)
      }
      Else{
      Write-Output "$programName is not installed"
      }
      }

      # Erlang check and Uninstall
      Write-Output "Checking if Erlang exist"
      Check_Program_Installed("Erlang")
      # RabbitMQ check and Uninstall
      Write-Output "Checking if RabbitMQ exist"
      Check_Program_Installed("Rabbit")

      # These actions need to be executed ONLY after Erlang and RabbitMQ uninstall
      Write-Output "Then we do action 1"
      Start-Sleep -s 3
      Write-Output "Then we do action 2"
      Start-Sleep -s 3
      Write-Output "Then we do action 3"
      Start-Sleep -s 3
      Write-Output "Then we do action 4"
      Start-Sleep -s 3
      Write-Output "Then we do action 5"


      enter image description here



      This is a very newbie approach but it's the only thing I came out with.



      Is there a more elegant way to handle the task and avoid PowerShell to pass to the next task if the previous one isn't completed?



      Thank you









      share







      New contributor




      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I'm new at PowerShell and I like it.



      I had the change to write a script that uninstall Erlang and RabbitMQ and I want the same script to then remove the Erlang folder and the RabbitMQ folder.



      But in order to do so I need the script to respect the tasks order.



      My way out was to use Write-Verbose (line 13) so the script needs to wait for the task to end in order to pass to the next task:



      # Let's set some verbosity
      $VerbosePreference = 'Continue'

      function Check_Program_Installed($programName){
      $check = Get-ChildItem -Path "HKLM:SOFTWAREMicrosoftWindowsCurrentVersionUninstall", "HKLM:SOFTWAREWow6432NodeMicrosoftWindowsCurrentVersionUninstall" |
      Get-ItemProperty | Where-Object {$_.DisplayName -like "*$programName*" } | Select-Object -Property DisplayName, UninstallString

      If ($check.DisplayName) {
      $result = $check.DisplayName
      Write-Output "I found: $result, let's uninstall it!"
      $uninst = $check.UninstallString

      Write-Verbose $uninst
      Start-Process -FilePath $uninst -ArgumentList "/qn" -Wait #-NoNewWindow

      Check_Program_Installed($programName)
      }
      Else{
      Write-Output "$programName is not installed"
      }
      }

      # Erlang check and Uninstall
      Write-Output "Checking if Erlang exist"
      Check_Program_Installed("Erlang")
      # RabbitMQ check and Uninstall
      Write-Output "Checking if RabbitMQ exist"
      Check_Program_Installed("Rabbit")

      # These actions need to be executed ONLY after Erlang and RabbitMQ uninstall
      Write-Output "Then we do action 1"
      Start-Sleep -s 3
      Write-Output "Then we do action 2"
      Start-Sleep -s 3
      Write-Output "Then we do action 3"
      Start-Sleep -s 3
      Write-Output "Then we do action 4"
      Start-Sleep -s 3
      Write-Output "Then we do action 5"


      enter image description here



      This is a very newbie approach but it's the only thing I came out with.



      Is there a more elegant way to handle the task and avoid PowerShell to pass to the next task if the previous one isn't completed?



      Thank you







      powershell erlang rabbitmq





      share







      New contributor




      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 8 mins ago









      Francesco MantovaniFrancesco Mantovani

      101




      101




      New contributor




      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Francesco Mantovani is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Francesco Mantovani is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213847%2fpowershell-is-this-an-unorthodox-way-o-use-write-verbose%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Francesco Mantovani is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Francesco Mantovani is a new contributor. Be nice, and check out our Code of Conduct.













          Francesco Mantovani is a new contributor. Be nice, and check out our Code of Conduct.












          Francesco Mantovani is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213847%2fpowershell-is-this-an-unorthodox-way-o-use-write-verbose%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Terni

          A new problem with tex4ht and tikz

          Sun Ra