Simple pattern matching between two string inputs using Java (Google interview challenge)
0
$begingroup$
The interview question is:
Write a function
isMatch(without usingjava.util.Regex) that takes two strings as arguments:
s(a string to match), and
p(a regular expression pattern).
It should return a Boolean denoting whether
smatchesp.
pcan be composed of alphabetic characters and '*' (denoting that the previous character matches 0 or more times).
This is the code I have written:
private boolean isNextCharStarred(String s) {
return s.length() >= 2 && s.charAt(1) == '*';
}
private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
if (p.length() == 0) {
return true;
}
if (s.length() == 0) {
if (isNextCharStarred(p)) {
return recIsMatch(s, p.substring(2), true);
}
return p.length() == 0;
}
if (isNextCharStarred(p)) {
if (s.charAt(0) != p.charAt(0)) {
return recIsMatch(s, p.substring(2), true);
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
|| recIsMatch(s, p.substring(2), true);
}
if (s.charAt(0) == p.charAt(0)) {
return recIsMatch(s.substring(1), p.substring(1), true);
}
if (hasPatternBeenEaten) {
return false;
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
}
public boolean isMatch(String s, String p) {
return recIsMatch(s, p, false);
}
Are there any bugs? How could it be improved?
java strings interview-questions reinventing-the-wheel
edited 1 min ago
Cody Gray
3,434926
asked 4 hours ago
MFXMFX
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
The interview question is:
Write a function
isMatch(without usingjava.util.Regex) that takes two strings as arguments:
s(a string to match), and
p(a regular expression pattern).
It should return a Boolean denoting whether
smatchesp.
pcan be composed of alphabetic characters and '*' (denoting that the previous character matches 0 or more times).
This is the code I have written:
private boolean isNextCharStarred(String s) {
return s.length() >= 2 && s.charAt(1) == '*';
}
private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
if (p.length() == 0) {
return true;
}
if (s.length() == 0) {
if (isNextCharStarred(p)) {
return recIsMatch(s, p.substring(2), true);
}
return p.length() == 0;
}
if (isNextCharStarred(p)) {
if (s.charAt(0) != p.charAt(0)) {
return recIsMatch(s, p.substring(2), true);
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
|| recIsMatch(s, p.substring(2), true);
}
if (s.charAt(0) == p.charAt(0)) {
return recIsMatch(s.substring(1), p.substring(1), true);
}
if (hasPatternBeenEaten) {
return false;
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
}
public boolean isMatch(String s, String p) {
return recIsMatch(s, p, false);
}
Are there any bugs? How could it be improved?
java strings interview-questions reinventing-the-wheel
edited 1 min ago
Cody Gray
3,434926
asked 4 hours ago
MFXMFX
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
The interview question is:
Write a function
isMatch(without usingjava.util.Regex) that takes two strings as arguments:
s(a string to match), and
p(a regular expression pattern).
It should return a Boolean denoting whether
smatchesp.
pcan be composed of alphabetic characters and '*' (denoting that the previous character matches 0 or more times).
This is the code I have written:
private boolean isNextCharStarred(String s) {
return s.length() >= 2 && s.charAt(1) == '*';
}
private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
if (p.length() == 0) {
return true;
}
if (s.length() == 0) {
if (isNextCharStarred(p)) {
return recIsMatch(s, p.substring(2), true);
}
return p.length() == 0;
}
if (isNextCharStarred(p)) {
if (s.charAt(0) != p.charAt(0)) {
return recIsMatch(s, p.substring(2), true);
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
|| recIsMatch(s, p.substring(2), true);
}
if (s.charAt(0) == p.charAt(0)) {
return recIsMatch(s.substring(1), p.substring(1), true);
}
if (hasPatternBeenEaten) {
return false;
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
}
public boolean isMatch(String s, String p) {
return recIsMatch(s, p, false);
}
Are there any bugs? How could it be improved?
java strings interview-questions reinventing-the-wheel
edited 1 min ago
Cody Gray
3,434926
asked 4 hours ago
MFXMFX
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
The interview question is:
Write a function
isMatch(without usingjava.util.Regex) that takes two strings as arguments:
s(a string to match), and
p(a regular expression pattern).
It should return a Boolean denoting whether
smatchesp.
pcan be composed of alphabetic characters and '*' (denoting that the previous character matches 0 or more times).
This is the code I have written:
private boolean isNextCharStarred(String s) {
return s.length() >= 2 && s.charAt(1) == '*';
}
private boolean recIsMatch(String s, String p, boolean hasPatternBeenEaten) {
if (p.length() == 0) {
return true;
}
if (s.length() == 0) {
if (isNextCharStarred(p)) {
return recIsMatch(s, p.substring(2), true);
}
return p.length() == 0;
}
if (isNextCharStarred(p)) {
if (s.charAt(0) != p.charAt(0)) {
return recIsMatch(s, p.substring(2), true);
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten)
|| recIsMatch(s, p.substring(2), true);
}
if (s.charAt(0) == p.charAt(0)) {
return recIsMatch(s.substring(1), p.substring(1), true);
}
if (hasPatternBeenEaten) {
return false;
}
return recIsMatch(s.substring(1), p, hasPatternBeenEaten);
}
public boolean isMatch(String s, String p) {
return recIsMatch(s, p, false);
}
Are there any bugs? How could it be improved?
java strings interview-questions reinventing-the-wheel
java strings interview-questions reinventing-the-wheel
edited 1 min ago
Cody Gray
3,434926
asked 4 hours ago
MFXMFX
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 1 min ago
Cody Gray
3,434926
asked 4 hours ago
MFXMFX
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 1 min ago
Cody Gray
3,434926
edited 1 min ago
Cody Gray
3,434926
edited 1 min ago
Cody Gray
3,434926
3,434926
asked 4 hours ago
MFXMFX
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 4 hours ago
MFXMFX
1
asked 4 hours ago
MFXMFX
1
1
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
MFX is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
MFX is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215067%2fsimple-pattern-matching-between-two-string-inputs-using-java-google-interview-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
MFX is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
MFX is a new contributor. Be nice, and check out our Code of Conduct.
MFX is a new contributor. Be nice, and check out our Code of Conduct.
MFX is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215067%2fsimple-pattern-matching-between-two-string-inputs-using-java-google-interview-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
