Ruby Multi Line Blocks Usage
$begingroup$
According to the Ruby Style Guide and Airbnb Style Guide:
Prefer {...} over do...end for single-line blocks. Avoid using {...} for multi-line blocks (multiline chaining is always ugly).
Now, image the following functions which must return an array of hashes:
OPTION 1
def generate_fields_1
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
fields =
words.each do |word|
numbers.each do |number|
content = find_content(word, number)
next if content.nil?
fields << {
kind: word,
value: content
}
end
end
fields
end
OPTION 2
def generate_fields_2
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
{
kind: word,
value: content
}
end.compact
end.flatten
end
The result is an array of hashes of any length because it depends on the find_content function which might return a nil value.
[
{ kind: "", value: "BRL" },
{ kind: "", value: "AUS" },
{ kind: "", value: "PER" },
]
Both functions return the same result but I see a tricky situation. The second option is better for me because I don't have the field variable and is cleaner than option 1. However, option 1 is straightforward without any shady behaviour such as end.compact or end.flatten.
What is the most appropriate function between both options? Is there any other alternative which respects the guidelines and returns the same result? Thanks in advance.
ruby ruby-on-rails
asked 14 mins ago
tmmgarciatmmgarcia
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
According to the Ruby Style Guide and Airbnb Style Guide:
Prefer {...} over do...end for single-line blocks. Avoid using {...} for multi-line blocks (multiline chaining is always ugly).
Now, image the following functions which must return an array of hashes:
OPTION 1
def generate_fields_1
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
fields =
words.each do |word|
numbers.each do |number|
content = find_content(word, number)
next if content.nil?
fields << {
kind: word,
value: content
}
end
end
fields
end
OPTION 2
def generate_fields_2
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
{
kind: word,
value: content
}
end.compact
end.flatten
end
The result is an array of hashes of any length because it depends on the find_content function which might return a nil value.
[
{ kind: "", value: "BRL" },
{ kind: "", value: "AUS" },
{ kind: "", value: "PER" },
]
Both functions return the same result but I see a tricky situation. The second option is better for me because I don't have the field variable and is cleaner than option 1. However, option 1 is straightforward without any shady behaviour such as end.compact or end.flatten.
What is the most appropriate function between both options? Is there any other alternative which respects the guidelines and returns the same result? Thanks in advance.
ruby ruby-on-rails
asked 14 mins ago
tmmgarciatmmgarcia
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
According to the Ruby Style Guide and Airbnb Style Guide:
Prefer {...} over do...end for single-line blocks. Avoid using {...} for multi-line blocks (multiline chaining is always ugly).
Now, image the following functions which must return an array of hashes:
OPTION 1
def generate_fields_1
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
fields =
words.each do |word|
numbers.each do |number|
content = find_content(word, number)
next if content.nil?
fields << {
kind: word,
value: content
}
end
end
fields
end
OPTION 2
def generate_fields_2
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
{
kind: word,
value: content
}
end.compact
end.flatten
end
The result is an array of hashes of any length because it depends on the find_content function which might return a nil value.
[
{ kind: "", value: "BRL" },
{ kind: "", value: "AUS" },
{ kind: "", value: "PER" },
]
Both functions return the same result but I see a tricky situation. The second option is better for me because I don't have the field variable and is cleaner than option 1. However, option 1 is straightforward without any shady behaviour such as end.compact or end.flatten.
What is the most appropriate function between both options? Is there any other alternative which respects the guidelines and returns the same result? Thanks in advance.
ruby ruby-on-rails
asked 14 mins ago
tmmgarciatmmgarcia
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
According to the Ruby Style Guide and Airbnb Style Guide:
Prefer {...} over do...end for single-line blocks. Avoid using {...} for multi-line blocks (multiline chaining is always ugly).
Now, image the following functions which must return an array of hashes:
OPTION 1
def generate_fields_1
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
fields =
words.each do |word|
numbers.each do |number|
content = find_content(word, number)
next if content.nil?
fields << {
kind: word,
value: content
}
end
end
fields
end
OPTION 2
def generate_fields_2
words = ["foo", "bar", "bla"]
numbers = [1, 2, 3]
words.map do |word|
numbers.map do |number|
content = find_content(word, number)
next if content.nil?
{
kind: word,
value: content
}
end.compact
end.flatten
end
The result is an array of hashes of any length because it depends on the find_content function which might return a nil value.
[
{ kind: "", value: "BRL" },
{ kind: "", value: "AUS" },
{ kind: "", value: "PER" },
]
Both functions return the same result but I see a tricky situation. The second option is better for me because I don't have the field variable and is cleaner than option 1. However, option 1 is straightforward without any shady behaviour such as end.compact or end.flatten.
What is the most appropriate function between both options? Is there any other alternative which respects the guidelines and returns the same result? Thanks in advance.
ruby ruby-on-rails
ruby ruby-on-rails
asked 14 mins ago
tmmgarciatmmgarcia
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 14 mins ago
tmmgarciatmmgarcia
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 14 mins ago
tmmgarciatmmgarcia
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 14 mins ago
tmmgarciatmmgarcia
1
asked 14 mins ago
tmmgarciatmmgarcia
1
1
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
tmmgarcia is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216516%2fruby-multi-line-blocks-usage%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
tmmgarcia is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216516%2fruby-multi-line-blocks-usage%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
