firstDuplicate of array
$begingroup$
This question has been asked for other languages, but I haven't seen it for C++. Most notably here and here.
Given an array a that contains only numbers in the range from 1 to a.length, find the first duplicate number for which the second occurrence has the minimal index. In other words, if there are more than 1 duplicated numbers, return the number for which the second occurrence has a smaller index than the second occurrence of the other number does. If there are no such elements, return -1.
My tests are running correctly, but I'm getting a timeout from the website codesignalDotCom. I'm wondering what I'm doing that could be taking so much time, and what could be done to fix it.
int firstDuplicate(std::vector<int> a) {
std::vector<int> newVector;
std::cout << a.size() << std::endl;
for(int i = 0; i < a.size(); i++) {
if(std::find(newVector.begin(), newVector.end(), a.at(i)) != newVector.end()){
return a.at(i);
}
newVector.push_back(a.at(i));
}
return -1;
}
c++
asked 6 mins ago
trueCamelTypetrueCamelType
1283
$endgroup$
add a comment |
$begingroup$
This question has been asked for other languages, but I haven't seen it for C++. Most notably here and here.
Given an array a that contains only numbers in the range from 1 to a.length, find the first duplicate number for which the second occurrence has the minimal index. In other words, if there are more than 1 duplicated numbers, return the number for which the second occurrence has a smaller index than the second occurrence of the other number does. If there are no such elements, return -1.
My tests are running correctly, but I'm getting a timeout from the website codesignalDotCom. I'm wondering what I'm doing that could be taking so much time, and what could be done to fix it.
int firstDuplicate(std::vector<int> a) {
std::vector<int> newVector;
std::cout << a.size() << std::endl;
for(int i = 0; i < a.size(); i++) {
if(std::find(newVector.begin(), newVector.end(), a.at(i)) != newVector.end()){
return a.at(i);
}
newVector.push_back(a.at(i));
}
return -1;
}
c++
asked 6 mins ago
trueCamelTypetrueCamelType
1283
$endgroup$
add a comment |
$begingroup$
This question has been asked for other languages, but I haven't seen it for C++. Most notably here and here.
Given an array a that contains only numbers in the range from 1 to a.length, find the first duplicate number for which the second occurrence has the minimal index. In other words, if there are more than 1 duplicated numbers, return the number for which the second occurrence has a smaller index than the second occurrence of the other number does. If there are no such elements, return -1.
My tests are running correctly, but I'm getting a timeout from the website codesignalDotCom. I'm wondering what I'm doing that could be taking so much time, and what could be done to fix it.
int firstDuplicate(std::vector<int> a) {
std::vector<int> newVector;
std::cout << a.size() << std::endl;
for(int i = 0; i < a.size(); i++) {
if(std::find(newVector.begin(), newVector.end(), a.at(i)) != newVector.end()){
return a.at(i);
}
newVector.push_back(a.at(i));
}
return -1;
}
c++
asked 6 mins ago
trueCamelTypetrueCamelType
1283
$endgroup$
This question has been asked for other languages, but I haven't seen it for C++. Most notably here and here.
Given an array a that contains only numbers in the range from 1 to a.length, find the first duplicate number for which the second occurrence has the minimal index. In other words, if there are more than 1 duplicated numbers, return the number for which the second occurrence has a smaller index than the second occurrence of the other number does. If there are no such elements, return -1.
My tests are running correctly, but I'm getting a timeout from the website codesignalDotCom. I'm wondering what I'm doing that could be taking so much time, and what could be done to fix it.
int firstDuplicate(std::vector<int> a) {
std::vector<int> newVector;
std::cout << a.size() << std::endl;
for(int i = 0; i < a.size(); i++) {
if(std::find(newVector.begin(), newVector.end(), a.at(i)) != newVector.end()){
return a.at(i);
}
newVector.push_back(a.at(i));
}
return -1;
}
c++
c++
asked 6 mins ago
trueCamelTypetrueCamelType
1283
asked 6 mins ago
trueCamelTypetrueCamelType
1283
asked 6 mins ago
trueCamelTypetrueCamelType
1283
asked 6 mins ago
trueCamelTypetrueCamelType
1283
asked 6 mins ago
trueCamelTypetrueCamelType
1283
1283
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214100%2ffirstduplicate-of-array%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214100%2ffirstduplicate-of-array%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
