Shuffling a deck of cards
$begingroup$
I've written a function to sort an array that'd simulate shuffling a deck of cards in the way of if you had [1,2,3,4,5] on one side and [6,7,8,9,0] on the other and it becomes [1, 6, 2, 7, 3, 8, 4, 9, 5, 0].
The code works, but I'm wondering how it can be cleaned up and be more performant without the need for three additional arrays and to see if it can be done on the cards array itself.
let cards = [1,2,3,4,5,6,7,8,9,0];
const shuffle = cards => {
const shuffled = ;
const l = cards.slice(0, cards.length / 2);
const r = cards.slice(cards.length / 2, cards.length);
if (l.length === r.length) {
for (let i = 0; i < l.length; i++) {
shuffled.push(l[i], r[i]);
}
}
return shuffled;
}
shuffle(a);javascript shuffle
edited 16 mins ago
Jamal♦
30.3k11117227
asked 48 mins ago
totalnoobtotalnoob
1435
$endgroup$
add a comment |
$begingroup$
I've written a function to sort an array that'd simulate shuffling a deck of cards in the way of if you had [1,2,3,4,5] on one side and [6,7,8,9,0] on the other and it becomes [1, 6, 2, 7, 3, 8, 4, 9, 5, 0].
The code works, but I'm wondering how it can be cleaned up and be more performant without the need for three additional arrays and to see if it can be done on the cards array itself.
let cards = [1,2,3,4,5,6,7,8,9,0];
const shuffle = cards => {
const shuffled = ;
const l = cards.slice(0, cards.length / 2);
const r = cards.slice(cards.length / 2, cards.length);
if (l.length === r.length) {
for (let i = 0; i < l.length; i++) {
shuffled.push(l[i], r[i]);
}
}
return shuffled;
}
shuffle(a);javascript shuffle
edited 16 mins ago
Jamal♦
30.3k11117227
asked 48 mins ago
totalnoobtotalnoob
1435
$endgroup$
add a comment |
$begingroup$
I've written a function to sort an array that'd simulate shuffling a deck of cards in the way of if you had [1,2,3,4,5] on one side and [6,7,8,9,0] on the other and it becomes [1, 6, 2, 7, 3, 8, 4, 9, 5, 0].
The code works, but I'm wondering how it can be cleaned up and be more performant without the need for three additional arrays and to see if it can be done on the cards array itself.
let cards = [1,2,3,4,5,6,7,8,9,0];
const shuffle = cards => {
const shuffled = ;
const l = cards.slice(0, cards.length / 2);
const r = cards.slice(cards.length / 2, cards.length);
if (l.length === r.length) {
for (let i = 0; i < l.length; i++) {
shuffled.push(l[i], r[i]);
}
}
return shuffled;
}
shuffle(a);javascript shuffle
edited 16 mins ago
Jamal♦
30.3k11117227
asked 48 mins ago
totalnoobtotalnoob
1435
$endgroup$
I've written a function to sort an array that'd simulate shuffling a deck of cards in the way of if you had [1,2,3,4,5] on one side and [6,7,8,9,0] on the other and it becomes [1, 6, 2, 7, 3, 8, 4, 9, 5, 0].
The code works, but I'm wondering how it can be cleaned up and be more performant without the need for three additional arrays and to see if it can be done on the cards array itself.
let cards = [1,2,3,4,5,6,7,8,9,0];
const shuffle = cards => {
const shuffled = ;
const l = cards.slice(0, cards.length / 2);
const r = cards.slice(cards.length / 2, cards.length);
if (l.length === r.length) {
for (let i = 0; i < l.length; i++) {
shuffled.push(l[i], r[i]);
}
}
return shuffled;
}
shuffle(a);let cards = [1,2,3,4,5,6,7,8,9,0];
const shuffle = cards => {
const shuffled = ;
const l = cards.slice(0, cards.length / 2);
const r = cards.slice(cards.length / 2, cards.length);
if (l.length === r.length) {
for (let i = 0; i < l.length; i++) {
shuffled.push(l[i], r[i]);
}
}
return shuffled;
}
shuffle(a);let cards = [1,2,3,4,5,6,7,8,9,0];
const shuffle = cards => {
const shuffled = ;
const l = cards.slice(0, cards.length / 2);
const r = cards.slice(cards.length / 2, cards.length);
if (l.length === r.length) {
for (let i = 0; i < l.length; i++) {
shuffled.push(l[i], r[i]);
}
}
return shuffled;
}
shuffle(a);javascript shuffle
javascript shuffle
edited 16 mins ago
Jamal♦
30.3k11117227
asked 48 mins ago
totalnoobtotalnoob
1435
edited 16 mins ago
Jamal♦
30.3k11117227
asked 48 mins ago
totalnoobtotalnoob
1435
edited 16 mins ago
Jamal♦
30.3k11117227
edited 16 mins ago
Jamal♦
30.3k11117227
edited 16 mins ago
Jamal♦
30.3k11117227
30.3k11117227
asked 48 mins ago
totalnoobtotalnoob
1435
asked 48 mins ago
totalnoobtotalnoob
1435
asked 48 mins ago
totalnoobtotalnoob
1435
1435
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212504%2fshuffling-a-deck-of-cards%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212504%2fshuffling-a-deck-of-cards%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
