Gfrktyl

I am new to PHP and am trying to create a highly secure login system using PHP and MySQLi. I tried searching a lot for the different approaches. Finally, I found one.

Is this code is safe or prone to security threats? Please suggest some modifications, if needed, in order to enhance security, along with some other best practices if you know.

function login($email, $password, $mysqli) {

    // Using prepared statements means that SQL injection is not possible. `enter code here`

    if ($stmt = $mysqli->prepare("SELECT id, username, password 

        FROM members

       WHERE email = ?

        LIMIT 1")) {

        $stmt->bind_param('s', $email);  // Bind "$email" to parameter.

        $stmt->execute();    // Execute the prepared query.

        $stmt->store_result();



        // get variables from result.

        $stmt->bind_result($user_id, $username, $db_password);

        $stmt->fetch();



        if ($stmt->num_rows == 1) {

            // If the user exists we check if the account is locked

            // from too many login attempts 



            if (checkbrute($user_id, $mysqli) == true) {

                // Account is locked 

                // Send an email to user saying their account is locked

                return false;

            } else {

                // Check if the password in the database matches

                // the password the user submitted. We are using

                // the password_verify function to avoid timing attacks.

                if (password_verify($password, $db_password)) {

                    // Password is correct!

                    // Get the user-agent string of the user.

                    $user_browser = $_SERVER['HTTP_USER_AGENT'];

                    // XSS protection as we might print this value

                    $user_id = preg_replace("/[^0-9]+/", "", $user_id);

                    $_SESSION['user_id'] = $user_id;

                    // XSS protection as we might print this value

                    $username = preg_replace("/[^a-zA-Z0-9_-]+/", 

                                                                "", 

                                                                $username);

                    $_SESSION['username'] = $username;

                    $_SESSION['login_string'] = hash('sha512', 

                              $db_password . $user_browser);

                    // Login successful.

                    return true;

                } else {

                    // Password is not correct

                    // We record this attempt in the database

                    $now = time();

                    $mysqli->query("INSERT INTO login_attempts(user_id, time)

                                    VALUES ('$user_id', '$now')");

                    return false;

                }

            }

        } else {

            // No user exists.

            return false;

        }

    }

}