Optimization for Kattis Problem 'Mali'
$begingroup$
So I was doing this problem on Kattis, Mali. Use this link to get to the problem: https://open.kattis.com/problems/mali. I'm fairly sure I can get the right answer 100% of the time, but the code exceeds the time limit of one second. I was wondering if you guys could help me optimize my code to help it run in time, or say my piece of code is trash and post your own solution. Nevertheless, if you could explain why my code is inefficient, that would be of great help. Thanks in advance.
#include <iostream>
#include <vector>
int main() {
int x, c = 0, big = 0;
std::cin >> x;
std::vector<int> as, bs;
for (int i = 0; i < x; i++) {
bool founda = false, foundb = false;
int a, b;
std::cin >> a >> b;
c++;
if (c == 1) {
as.push_back(a);
bs.push_back(b);
}
else {
for (int i = 0; i < c; i++) {
if (as[i] < a || i == c-1) {
as.insert(as.begin()+i, a);
founda = true;
}
if (bs[i] < b || i == c-1) {
bs.insert(bs.begin()+i, b);
foundb = true;
}
if (founda == true && foundb == true)
break;
}
}
for (int i = 0; i < c; i++) {
if (as[i] + bs[c-1-i] > big)
big = as[i] + bs[c-1-i];
}
std::cout << big << std::endl;
}
}
c++ performance programming-challenge
asked 13 mins ago
Griffin WongGriffin Wong
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
So I was doing this problem on Kattis, Mali. Use this link to get to the problem: https://open.kattis.com/problems/mali. I'm fairly sure I can get the right answer 100% of the time, but the code exceeds the time limit of one second. I was wondering if you guys could help me optimize my code to help it run in time, or say my piece of code is trash and post your own solution. Nevertheless, if you could explain why my code is inefficient, that would be of great help. Thanks in advance.
#include <iostream>
#include <vector>
int main() {
int x, c = 0, big = 0;
std::cin >> x;
std::vector<int> as, bs;
for (int i = 0; i < x; i++) {
bool founda = false, foundb = false;
int a, b;
std::cin >> a >> b;
c++;
if (c == 1) {
as.push_back(a);
bs.push_back(b);
}
else {
for (int i = 0; i < c; i++) {
if (as[i] < a || i == c-1) {
as.insert(as.begin()+i, a);
founda = true;
}
if (bs[i] < b || i == c-1) {
bs.insert(bs.begin()+i, b);
foundb = true;
}
if (founda == true && foundb == true)
break;
}
}
for (int i = 0; i < c; i++) {
if (as[i] + bs[c-1-i] > big)
big = as[i] + bs[c-1-i];
}
std::cout << big << std::endl;
}
}
c++ performance programming-challenge
asked 13 mins ago
Griffin WongGriffin Wong
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
So I was doing this problem on Kattis, Mali. Use this link to get to the problem: https://open.kattis.com/problems/mali. I'm fairly sure I can get the right answer 100% of the time, but the code exceeds the time limit of one second. I was wondering if you guys could help me optimize my code to help it run in time, or say my piece of code is trash and post your own solution. Nevertheless, if you could explain why my code is inefficient, that would be of great help. Thanks in advance.
#include <iostream>
#include <vector>
int main() {
int x, c = 0, big = 0;
std::cin >> x;
std::vector<int> as, bs;
for (int i = 0; i < x; i++) {
bool founda = false, foundb = false;
int a, b;
std::cin >> a >> b;
c++;
if (c == 1) {
as.push_back(a);
bs.push_back(b);
}
else {
for (int i = 0; i < c; i++) {
if (as[i] < a || i == c-1) {
as.insert(as.begin()+i, a);
founda = true;
}
if (bs[i] < b || i == c-1) {
bs.insert(bs.begin()+i, b);
foundb = true;
}
if (founda == true && foundb == true)
break;
}
}
for (int i = 0; i < c; i++) {
if (as[i] + bs[c-1-i] > big)
big = as[i] + bs[c-1-i];
}
std::cout << big << std::endl;
}
}
c++ performance programming-challenge
asked 13 mins ago
Griffin WongGriffin Wong
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
So I was doing this problem on Kattis, Mali. Use this link to get to the problem: https://open.kattis.com/problems/mali. I'm fairly sure I can get the right answer 100% of the time, but the code exceeds the time limit of one second. I was wondering if you guys could help me optimize my code to help it run in time, or say my piece of code is trash and post your own solution. Nevertheless, if you could explain why my code is inefficient, that would be of great help. Thanks in advance.
#include <iostream>
#include <vector>
int main() {
int x, c = 0, big = 0;
std::cin >> x;
std::vector<int> as, bs;
for (int i = 0; i < x; i++) {
bool founda = false, foundb = false;
int a, b;
std::cin >> a >> b;
c++;
if (c == 1) {
as.push_back(a);
bs.push_back(b);
}
else {
for (int i = 0; i < c; i++) {
if (as[i] < a || i == c-1) {
as.insert(as.begin()+i, a);
founda = true;
}
if (bs[i] < b || i == c-1) {
bs.insert(bs.begin()+i, b);
foundb = true;
}
if (founda == true && foundb == true)
break;
}
}
for (int i = 0; i < c; i++) {
if (as[i] + bs[c-1-i] > big)
big = as[i] + bs[c-1-i];
}
std::cout << big << std::endl;
}
}
c++ performance programming-challenge
c++ performance programming-challenge
asked 13 mins ago
Griffin WongGriffin Wong
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 13 mins ago
Griffin WongGriffin Wong
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 13 mins ago
Griffin WongGriffin Wong
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 13 mins ago
Griffin WongGriffin Wong
1
asked 13 mins ago
Griffin WongGriffin Wong
1
1
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Griffin Wong is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Griffin Wong is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216695%2foptimization-for-kattis-problem-mali%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Griffin Wong is a new contributor. Be nice, and check out our Code of Conduct.
Griffin Wong is a new contributor. Be nice, and check out our Code of Conduct.
Griffin Wong is a new contributor. Be nice, and check out our Code of Conduct.
Griffin Wong is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216695%2foptimization-for-kattis-problem-mali%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
