Fill out a spiral matrix












1












$begingroup$


I got this question during my interview:




Given an integer N, output an N x N spiral matrix with integers 1 through N.



Examples: Input: 3



Output: [[1, 2, 3],
[8, 9, 4],
[7, 6, 5]]



Input: 1



output: matrix filled out as a spiral [[1]]




/*PSEUDO:
rowMin = 0
rowMax = n - 1
colMin = 0
colMax = n - 1
counter = 1
matrix =
create the matrix:
loop from 0 to n - 1
array
loop from 0 to n-1
push 0 into array
while rowMin <= rowMax and colMin <= colMax
loop on rowMin from colMin to colMax. col
matrix[rowMin][col] becomes counter++
rowMin++
loop on colMax and from rowMin to rowMax. row
matrix[row][colMax] becomes counter++
colMax--
loop on rowMax from colMax to colMin. col
matrix[rowMax][col] becomes counter++
rowMax--
loop on colMin from rowMax to rowMin. row
matrix[row][colMin] becomes counter++
colMin++
return matrix
*/


const spiralMatrix = (n) => {
const matrix = ;
let rowMin = 0,
rowMax = n - 1,
colMin = 0,
colMax = n - 1,
counter = 1;

for (let i = 0; i < n; i++) {
matrix.push(new Array(n).fill(0));
}

while (rowMin <= rowMax && colMin <= colMax) {
for (let col = colMin; col <= colMax; col++) {
matrix[rowMin][col] = counter++;
}
rowMin++;
for (let row = rowMin; row <= rowMax; row++) {
matrix[row][colMax] = counter++;
}
colMax--;
for (let col = colMax; col >= colMin; col--) {
matrix[rowMax][col] = counter++;
}
rowMax--;
for (let row = rowMax; row >= rowMin; row--) {
matrix[row][colMin] = counter++;
}
colMin++;
}

return matrix;
}

console.log(spiralMatrix(10));









share|improve this question











$endgroup$












  • $begingroup$
    it would be interesting to see this problem solved without random access. Left to right, top to bottom, in the same order you'd output to a terminal.
    $endgroup$
    – Oh My Goodness
    18 hours ago
















1












$begingroup$


I got this question during my interview:




Given an integer N, output an N x N spiral matrix with integers 1 through N.



Examples: Input: 3



Output: [[1, 2, 3],
[8, 9, 4],
[7, 6, 5]]



Input: 1



output: matrix filled out as a spiral [[1]]




/*PSEUDO:
rowMin = 0
rowMax = n - 1
colMin = 0
colMax = n - 1
counter = 1
matrix =
create the matrix:
loop from 0 to n - 1
array
loop from 0 to n-1
push 0 into array
while rowMin <= rowMax and colMin <= colMax
loop on rowMin from colMin to colMax. col
matrix[rowMin][col] becomes counter++
rowMin++
loop on colMax and from rowMin to rowMax. row
matrix[row][colMax] becomes counter++
colMax--
loop on rowMax from colMax to colMin. col
matrix[rowMax][col] becomes counter++
rowMax--
loop on colMin from rowMax to rowMin. row
matrix[row][colMin] becomes counter++
colMin++
return matrix
*/


const spiralMatrix = (n) => {
const matrix = ;
let rowMin = 0,
rowMax = n - 1,
colMin = 0,
colMax = n - 1,
counter = 1;

for (let i = 0; i < n; i++) {
matrix.push(new Array(n).fill(0));
}

while (rowMin <= rowMax && colMin <= colMax) {
for (let col = colMin; col <= colMax; col++) {
matrix[rowMin][col] = counter++;
}
rowMin++;
for (let row = rowMin; row <= rowMax; row++) {
matrix[row][colMax] = counter++;
}
colMax--;
for (let col = colMax; col >= colMin; col--) {
matrix[rowMax][col] = counter++;
}
rowMax--;
for (let row = rowMax; row >= rowMin; row--) {
matrix[row][colMin] = counter++;
}
colMin++;
}

return matrix;
}

console.log(spiralMatrix(10));









share|improve this question











$endgroup$












  • $begingroup$
    it would be interesting to see this problem solved without random access. Left to right, top to bottom, in the same order you'd output to a terminal.
    $endgroup$
    – Oh My Goodness
    18 hours ago














1












1








1





$begingroup$


I got this question during my interview:




Given an integer N, output an N x N spiral matrix with integers 1 through N.



Examples: Input: 3



Output: [[1, 2, 3],
[8, 9, 4],
[7, 6, 5]]



Input: 1



output: matrix filled out as a spiral [[1]]




/*PSEUDO:
rowMin = 0
rowMax = n - 1
colMin = 0
colMax = n - 1
counter = 1
matrix =
create the matrix:
loop from 0 to n - 1
array
loop from 0 to n-1
push 0 into array
while rowMin <= rowMax and colMin <= colMax
loop on rowMin from colMin to colMax. col
matrix[rowMin][col] becomes counter++
rowMin++
loop on colMax and from rowMin to rowMax. row
matrix[row][colMax] becomes counter++
colMax--
loop on rowMax from colMax to colMin. col
matrix[rowMax][col] becomes counter++
rowMax--
loop on colMin from rowMax to rowMin. row
matrix[row][colMin] becomes counter++
colMin++
return matrix
*/


const spiralMatrix = (n) => {
const matrix = ;
let rowMin = 0,
rowMax = n - 1,
colMin = 0,
colMax = n - 1,
counter = 1;

for (let i = 0; i < n; i++) {
matrix.push(new Array(n).fill(0));
}

while (rowMin <= rowMax && colMin <= colMax) {
for (let col = colMin; col <= colMax; col++) {
matrix[rowMin][col] = counter++;
}
rowMin++;
for (let row = rowMin; row <= rowMax; row++) {
matrix[row][colMax] = counter++;
}
colMax--;
for (let col = colMax; col >= colMin; col--) {
matrix[rowMax][col] = counter++;
}
rowMax--;
for (let row = rowMax; row >= rowMin; row--) {
matrix[row][colMin] = counter++;
}
colMin++;
}

return matrix;
}

console.log(spiralMatrix(10));









share|improve this question











$endgroup$




I got this question during my interview:




Given an integer N, output an N x N spiral matrix with integers 1 through N.



Examples: Input: 3



Output: [[1, 2, 3],
[8, 9, 4],
[7, 6, 5]]



Input: 1



output: matrix filled out as a spiral [[1]]




/*PSEUDO:
rowMin = 0
rowMax = n - 1
colMin = 0
colMax = n - 1
counter = 1
matrix =
create the matrix:
loop from 0 to n - 1
array
loop from 0 to n-1
push 0 into array
while rowMin <= rowMax and colMin <= colMax
loop on rowMin from colMin to colMax. col
matrix[rowMin][col] becomes counter++
rowMin++
loop on colMax and from rowMin to rowMax. row
matrix[row][colMax] becomes counter++
colMax--
loop on rowMax from colMax to colMin. col
matrix[rowMax][col] becomes counter++
rowMax--
loop on colMin from rowMax to rowMin. row
matrix[row][colMin] becomes counter++
colMin++
return matrix
*/


const spiralMatrix = (n) => {
const matrix = ;
let rowMin = 0,
rowMax = n - 1,
colMin = 0,
colMax = n - 1,
counter = 1;

for (let i = 0; i < n; i++) {
matrix.push(new Array(n).fill(0));
}

while (rowMin <= rowMax && colMin <= colMax) {
for (let col = colMin; col <= colMax; col++) {
matrix[rowMin][col] = counter++;
}
rowMin++;
for (let row = rowMin; row <= rowMax; row++) {
matrix[row][colMax] = counter++;
}
colMax--;
for (let col = colMax; col >= colMin; col--) {
matrix[rowMax][col] = counter++;
}
rowMax--;
for (let row = rowMax; row >= rowMin; row--) {
matrix[row][colMin] = counter++;
}
colMin++;
}

return matrix;
}

console.log(spiralMatrix(10));






javascript






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 11 mins ago









Jamal

30.4k11121227




30.4k11121227










asked 22 hours ago









NinjaGNinjaG

825632




825632












  • $begingroup$
    it would be interesting to see this problem solved without random access. Left to right, top to bottom, in the same order you'd output to a terminal.
    $endgroup$
    – Oh My Goodness
    18 hours ago


















  • $begingroup$
    it would be interesting to see this problem solved without random access. Left to right, top to bottom, in the same order you'd output to a terminal.
    $endgroup$
    – Oh My Goodness
    18 hours ago
















$begingroup$
it would be interesting to see this problem solved without random access. Left to right, top to bottom, in the same order you'd output to a terminal.
$endgroup$
– Oh My Goodness
18 hours ago




$begingroup$
it would be interesting to see this problem solved without random access. Left to right, top to bottom, in the same order you'd output to a terminal.
$endgroup$
– Oh My Goodness
18 hours ago










1 Answer
1






active

oldest

votes


















2












$begingroup$

Seems mostly solid to me. I just have two small remarks:






const spiralMatrix = (n) => {



I'm not a big fan of using the arrow syntax here. The arrow syntax is (mostly) used for inline functions. For a "top level" function I'd prefer a normal, more readable (and hoisted) function declaration:



function spiralMatrix(n) {


The only disadvantage I see is that const prevents accidental overwriting, which I don't see as an serious problem in this case.





And .fill(0) during initialization of the arrays is unnecessary.






share|improve this answer









$endgroup$













    Your Answer





    StackExchange.ifUsing("editor", function () {
    return StackExchange.using("mathjaxEditing", function () {
    StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
    StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
    });
    });
    }, "mathjax-editing");

    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "196"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: false,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: null,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215902%2ffill-out-a-spiral-matrix%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    2












    $begingroup$

    Seems mostly solid to me. I just have two small remarks:






    const spiralMatrix = (n) => {



    I'm not a big fan of using the arrow syntax here. The arrow syntax is (mostly) used for inline functions. For a "top level" function I'd prefer a normal, more readable (and hoisted) function declaration:



    function spiralMatrix(n) {


    The only disadvantage I see is that const prevents accidental overwriting, which I don't see as an serious problem in this case.





    And .fill(0) during initialization of the arrays is unnecessary.






    share|improve this answer









    $endgroup$


















      2












      $begingroup$

      Seems mostly solid to me. I just have two small remarks:






      const spiralMatrix = (n) => {



      I'm not a big fan of using the arrow syntax here. The arrow syntax is (mostly) used for inline functions. For a "top level" function I'd prefer a normal, more readable (and hoisted) function declaration:



      function spiralMatrix(n) {


      The only disadvantage I see is that const prevents accidental overwriting, which I don't see as an serious problem in this case.





      And .fill(0) during initialization of the arrays is unnecessary.






      share|improve this answer









      $endgroup$
















        2












        2








        2





        $begingroup$

        Seems mostly solid to me. I just have two small remarks:






        const spiralMatrix = (n) => {



        I'm not a big fan of using the arrow syntax here. The arrow syntax is (mostly) used for inline functions. For a "top level" function I'd prefer a normal, more readable (and hoisted) function declaration:



        function spiralMatrix(n) {


        The only disadvantage I see is that const prevents accidental overwriting, which I don't see as an serious problem in this case.





        And .fill(0) during initialization of the arrays is unnecessary.






        share|improve this answer









        $endgroup$



        Seems mostly solid to me. I just have two small remarks:






        const spiralMatrix = (n) => {



        I'm not a big fan of using the arrow syntax here. The arrow syntax is (mostly) used for inline functions. For a "top level" function I'd prefer a normal, more readable (and hoisted) function declaration:



        function spiralMatrix(n) {


        The only disadvantage I see is that const prevents accidental overwriting, which I don't see as an serious problem in this case.





        And .fill(0) during initialization of the arrays is unnecessary.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered 15 hours ago









        RoToRaRoToRa

        6,3981336




        6,3981336






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Code Review Stack Exchange!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            Use MathJax to format equations. MathJax reference.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215902%2ffill-out-a-spiral-matrix%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Список кардиналов, возведённых папой римским Каликстом III

            Deduzione

            Mysql.sock missing - “Can't connect to local MySQL server through socket”